[kcron] [Bug 442845] Task scheduler: crashes if user discards printing crontab

2021-09-27 Thread Oleg Solovyov
https://bugs.kde.org/show_bug.cgi?id=442845

Oleg Solovyov  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/syst
   ||em/kcron/commit/884a2d1c98a
   ||c1f633d63eb8e58a91f26544d94
   ||82
 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #5 from Oleg Solovyov  ---
Git commit 884a2d1c98ac1f633d63eb8e58a91f26544d9482 by Oleg Solovyov.
Committed on 24/09/2021 at 15:36.
Pushed by mlaurent into branch 'master'.

Don't set option tabs

QPrintDialog deletes all tabs upon destructing, which causes double-free
error.

M  +0-1src/crontabPrinter.cpp

https://invent.kde.org/system/kcron/commit/884a2d1c98ac1f633d63eb8e58a91f26544d9482

-- 
You are receiving this mail because:
You are watching all bug changes.

[kcron] [Bug 442845] Task scheduler: crashes if user discards printing crontab

2021-09-24 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=442845

Bug Janitor Service  changed:

   What|Removed |Added

 Status|REPORTED|ASSIGNED
 Ever confirmed|0   |1

--- Comment #4 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/system/kcron/-/merge_requests/1

-- 
You are receiving this mail because:
You are watching all bug changes.

[kcron] [Bug 442845] Task scheduler: crashes if user discards printing crontab

2021-09-24 Thread Oleg Solovyov
https://bugs.kde.org/show_bug.cgi?id=442845

--- Comment #3 from Oleg Solovyov  ---
(In reply to Tommaso Massimi from comment #2)
> then (crontabPrinter.cpp:60)
>   printDialog->setOptionTabs(QList() << mCrontabWidget);

Maybe we can remove this line?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kcron] [Bug 442845] Task scheduler: crashes if user discards printing crontab

2021-09-24 Thread Tommaso Massimi
https://bugs.kde.org/show_bug.cgi?id=442845

Tommaso Massimi  changed:

   What|Removed |Added

 CC||tmass...@gmail.com

--- Comment #2 from Tommaso Massimi  ---
> I don't understand why CrontabWidget d-tor is called

here a CrontabPrinter is create, and a CrontabWidget is passed to the c-tor

void CrontabWidget::print()
{
CrontabPrinter printer(this);

and named mCrontabWidget

CrontabPrinter::CrontabPrinter(CrontabWidget *crontabWidget)
: mCrontabWidget(crontabWidget)

then (crontabPrinter.cpp:60)
  printDialog->setOptionTabs(QList() << mCrontabWidget);

probably when the printDialog d-tor is called (crontabPrinter.cpp:64),
mCrontabWidget d-tor is called

-- 
You are receiving this mail because:
You are watching all bug changes.

[kcron] [Bug 442845] Task scheduler: crashes if user discards printing crontab

2021-09-23 Thread Oleg Solovyov
https://bugs.kde.org/show_bug.cgi?id=442845

--- Comment #1 from Oleg Solovyov  ---
That's what happens when I press "Cancel" on print dialog:

#0  CrontabWidget::~CrontabWidget (this=0x55fb59f0, __in_chrg=) at ./src/crontabWidget.cpp:75
#1  0x768df39e in QObjectPrivate::deleteChildren
(this=this@entry=0x55e78bd0) at kernel/qobject.cpp:2104
#2  0x775076a6 in QWidget::~QWidget (this=0x5567e550,
__in_chrg=) at kernel/qwidget.cpp:1522
#3  0x776828bd in QStackedWidget::~QStackedWidget (this=0x5567e550,
__in_chrg=)
at widgets/qstackedwidget.cpp:145
#4  0x768df39e in QObjectPrivate::deleteChildren
(this=this@entry=0x57c267b0) at kernel/qobject.cpp:2104
#5  0x775076a6 in QWidget::~QWidget (this=0x55ecbf60,
__in_chrg=) at kernel/qwidget.cpp:1522
#6  0x776a5aad in QTabWidget::~QTabWidget (this=0x55ecbf60,
__in_chrg=)
at widgets/qtabwidget.cpp:372
#7  0x768df39e in QObjectPrivate::deleteChildren
(this=this@entry=0x5599d790) at kernel/qobject.cpp:2104
#8  0x775076a6 in QWidget::~QWidget (this=0x560e9b50,
__in_chrg=) at kernel/qwidget.cpp:1522
#9  0x7750789d in QWidget::~QWidget (this=0x560e9b50,
__in_chrg=) at kernel/qwidget.cpp:1400
#10 0x768df39e in QObjectPrivate::deleteChildren
(this=this@entry=0x5812b790) at kernel/qobject.cpp:2104
#11 0x775076a6 in QWidget::~QWidget (this=0x57c99590,
__in_chrg=) at kernel/qwidget.cpp:1522
#12 0x750c77ad in QPrintDialog::~QPrintDialog() () from
/lib/x86_64-linux-gnu/libQt5PrintSupport.so.5
#13 0x7fffabfbf967 in CrontabPrinter::start
(this=this@entry=0x7fffcc10) at ./src/crontabPrinter.cpp:64
#14 0x7fffabfbb247 in CrontabWidget::print (this=) at
./src/crontabWidget.cpp:368

I don't understand why CrontabWidget d-tor is called

-- 
You are receiving this mail because:
You are watching all bug changes.

[kcron] [Bug 442845] Task scheduler: crashes if user discards printing crontab

2021-09-23 Thread Oleg Solovyov
https://bugs.kde.org/show_bug.cgi?id=442845

Oleg Solovyov  changed:

   What|Removed |Added

Product|systemsettings  |kcron
   Assignee|plasma-b...@kde.org |g...@meyer.net
  Component|generic-crash   |general

-- 
You are receiving this mail because:
You are watching all bug changes.