[kdenlive] [Bug 356493] [Patch included] "Save Layout As" menu option in menu bar redundant? Suggest removing "Save Layout As" sub-menu text

[emohr]

https://bugs.kde.org/show_bug.cgi?id=356493

emohr  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/mult
   ||imedia/kdenlive/-/commit/0a
   ||93ade47d8c539ddf31e5ff5a639
   ||2ab42179782
 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED
   Version Fixed In||20.08

--- Comment #18 from emohr  ---
New layout function with preset layouts, customized layout and save as will
come with 20.08.

We close this bug. If it still appears in the latest version, please feel free
to re-open it and update the affected version number.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdenlive] [Bug 356493] [Patch included] "Save Layout As" menu option in menu bar redundant? Suggest removing "Save Layout As" sub-menu text

[emohr]

https://bugs.kde.org/show_bug.cgi?id=356493

emohr  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|REPORTED|CONFIRMED
 CC||fritzib...@gmx.net
  Flags||Brainstorm+

--- Comment #17 from emohr  ---
see here: https://invent.kde.org/kde/kdenlive/-/issues/407

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdenlive] [Bug 356493] [Patch included] "Save Layout As" menu option in menu bar redundant? Suggest removing "Save Layout As" sub-menu text

[Simon Andric]

https://bugs.kde.org/show_bug.cgi?id=356493

Simon Andric  changed:

   What|Removed |Added

 CC||simonandr...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdenlive] [Bug 356493] [Patch included] "Save Layout As" menu option in menu bar redundant? Suggest removing "Save Layout As" sub-menu text

[Jean-Baptiste Mardelle]

https://bugs.kde.org/show_bug.cgi?id=356493

--- Comment #16 from Jean-Baptiste Mardelle  ---
Yes, I was also thinking about it. Shouldn't be hard.
in layoutmanagement.cpp at line 27, we gave:

KActionCategory *layoutActions = new KActionCategory(i18n("Layouts"),
pCore->window()->actionCollection());

Which puts items in a "Layout" category. So instead we can simply create 2
categories: "Load Layout" and "Save Layout", and put the actions in the correct
category.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdenlive] [Bug 356493] [Patch included] "Save Layout As" menu option in menu bar redundant? Suggest removing "Save Layout As" sub-menu text

[Jesse]

https://bugs.kde.org/show_bug.cgi?id=356493

--- Comment #15 from Jesse  ---
Could we possibly sub-categorize each of them in the Configure shortcuts
window?

For example:
Layouts
- Save Layout
- - Layout 1
- - Layout 2
- - Layout 3
- - Layout 4
- Load Layout
- - Layout 1
- - Layout 2
- - Layout 3
- - Layout 4

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdenlive] [Bug 356493] [Patch included] "Save Layout As" menu option in menu bar redundant? Suggest removing "Save Layout As" sub-menu text

[Jesse]

https://bugs.kde.org/show_bug.cgi?id=356493

--- Comment #14 from Jesse  ---
Ashark, you're right about the optimized code. I replaced "setText(i18n("%1",
layoutName))" with "setText(layoutName). Apprecaite the guidance, there.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdenlive] [Bug 356493] [Patch included] "Save Layout As" menu option in menu bar redundant? Suggest removing "Save Layout As" sub-menu text

[Jesse]

https://bugs.kde.org/show_bug.cgi?id=356493

--- Comment #13 from Jesse  ---
(And sorry, the bug tracker isn't emailing me when a new comment appears on a
bug I'm following. Not sure why, so I have to check bugs for new comments,
manually.)

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdenlive] [Bug 356493] [Patch included] "Save Layout As" menu option in menu bar redundant? Suggest removing "Save Layout As" sub-menu text

[Jesse]

https://bugs.kde.org/show_bug.cgi?id=356493

--- Comment #12 from Jesse  ---
Thanks JB and Ashark. I definitely see the concern, there. Give me a bit to see
if I can come up with a creative solution.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdenlive] [Bug 356493] [Patch included] "Save Layout As" menu option in menu bar redundant? Suggest removing "Save Layout As" sub-menu text

[Ashark]

https://bugs.kde.org/show_bug.cgi?id=356493

--- Comment #11 from Ashark  ---
Created attachment 107297
  --> https://bugs.kde.org/attachment.cgi?id=107297=edit
Screenshot of layouts in shortcut menu after patch

In shortcuts menu it will be difficult to differentiate actions for layouts.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdenlive] [Bug 356493] [Patch included] "Save Layout As" menu option in menu bar redundant? Suggest removing "Save Layout As" sub-menu text

[Ashark]

https://bugs.kde.org/show_bug.cgi?id=356493

--- Comment #10 from Ashark  ---
Yes, layouts will appear without differentiate. See attached screenshot.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdenlive] [Bug 356493] [Patch included] "Save Layout As" menu option in menu bar redundant? Suggest removing "Save Layout As" sub-menu text

[Jean-Baptiste Mardelle]

https://bugs.kde.org/show_bug.cgi?id=356493

--- Comment #9 from Jean-Baptiste Mardelle  ---
My only concern with this is that if I remember correctly, loading and saving
layouts can be assigned shortcuts. Currently, the "save as" part in the name
helps differentiate between the load and save actions in the shortcut dialog.
If we remove "save as", i am afraid both load and save actions will appear
under "layout 1" in the shortcut dialog. Can uou check that ?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdenlive] [Bug 356493] [Patch included] "Save Layout As" menu option in menu bar redundant? Suggest removing "Save Layout As" sub-menu text

[Jesse]

https://bugs.kde.org/show_bug.cgi?id=356493

Jesse  changed:

   What|Removed |Added

Summary|"Save Layout As" menu   |[Patch included] "Save
   |option in menu bar  |Layout As" menu option in
   |redundant? Suggest removing |menu bar redundant? Suggest
   |"Save Layout As" sub-menu   |removing "Save Layout As"
   |text|sub-menu text

-- 
You are receiving this mail because:
You are watching all bug changes.