[kdeplasma-addons] [Bug 452596] Comics widget does not show image
https://bugs.kde.org/show_bug.cgi?id=452596 --- Comment #14 from Nate Graham --- Yes, today's is quite gorgeous! I wish I could ever see it in person, but alas I live in the northern hemisphere and my wee telescope is probably too small anyway. -- You are receiving this mail because: You are watching all bug changes.
[kdeplasma-addons] [Bug 452596] Comics widget does not show image
https://bugs.kde.org/show_bug.cgi?id=452596 --- Comment #13 from Twisted Lucidity --- Just to confirm that everything is working again. The APOD picture today is simply stunning, almost like it is having a wee celebration. :-) -- You are receiving this mail because: You are watching all bug changes.
[kdeplasma-addons] [Bug 452596] Comics widget does not show image
https://bugs.kde.org/show_bug.cgi?id=452596 Nate Graham changed: What|Removed |Added CC||ge...@electron.me.uk --- Comment #12 from Nate Graham --- *** Bug 453179 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[kdeplasma-addons] [Bug 452596] Comics widget does not show image
https://bugs.kde.org/show_bug.cgi?id=452596 Nate Graham changed: What|Removed |Added Version Fixed In||5.24.5 -- You are receiving this mail because: You are watching all bug changes.
[kdeplasma-addons] [Bug 452596] Comics widget does not show image
https://bugs.kde.org/show_bug.cgi?id=452596
Alexander Lohnau changed:
What|Removed |Added
Latest Commit|https://invent.kde.org/fram |https://invent.kde.org/plas
|eworks/plasma-framework/com |ma/kdeplasma-addons/commit/
|mit/c90e49cc98769ca5b9275c0 |27710b95a3fd53019b4b053cbdf
|89880b3d64f1689c5 |720354fd939d2
--- Comment #11 from Alexander Lohnau ---
Git commit 27710b95a3fd53019b4b053cbdf720354fd939d2 by Alexander Lohnau.
Committed on 17/04/2022 at 04:45.
Pushed by alex into branch 'Plasma/5.24'.
Remove unneeded check for comic Dataengine being valid
We do not really care, if the metadata of the plugin is valid, as long as we
can
properly create the dataengine from it.
Test Plan:
With plasma-frameworks master, and this on Plasma/5.24 based revision, the
dataengine can properly be loaded.
When intenitionally exporting a defunct plugin:
```cpp
class Dummy : public QObject
{
Q_OBJECT
public:
Dummy(QObject *parent, const QVariantList ) {
}
};
K_PLUGIN_CLASS_WITH_JSON(Dummy, "plasma-dataengine-comic.json")
```
The applet does not crash.
M +2-2applets/comic/comic.cpp
M +1-1applets/comic/comicarchivejob.cpp
https://invent.kde.org/plasma/kdeplasma-addons/commit/27710b95a3fd53019b4b053cbdf720354fd939d2
--
You are receiving this mail because:
You are watching all bug changes.
[kdeplasma-addons] [Bug 452596] Comics widget does not show image
https://bugs.kde.org/show_bug.cgi?id=452596 Alexander Lohnau changed: What|Removed |Added Latest Commit||https://invent.kde.org/fram ||eworks/plasma-framework/com ||mit/c90e49cc98769ca5b9275c0 ||89880b3d64f1689c5 Status|REPORTED|RESOLVED Resolution|--- |FIXED --- Comment #10 from Alexander Lohnau --- Git commit c90e49cc98769ca5b9275c089880b3d64f1689c5 by Alexander Lohnau. Committed on 17/04/2022 at 13:09. Pushed by alex into branch 'master'. Fix check for argument length in DataEngine loader After i wrote the initial patch, we decided that the plasma-frameworks internal code which dumped the entire KPluginMetaData object as a variant map in the args could be removed. However, this change was not applied to the sanity check in the latest revision of the MR. M +1-1src/plasma/dataengine.cpp https://invent.kde.org/frameworks/plasma-framework/commit/c90e49cc98769ca5b9275c089880b3d64f1689c5 -- You are receiving this mail because: You are watching all bug changes.
[kdeplasma-addons] [Bug 452596] Comics widget does not show image
https://bugs.kde.org/show_bug.cgi?id=452596 --- Comment #9 from Kishore Gopalakrishnan --- (In reply to Alexander Lohnau from comment #8) > For whatever reasons the automatic mention of the MR did not work. Here is > the fix: > https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/508 Thanks, building from your branch fixes the issue for me. -- You are receiving this mail because: You are watching all bug changes.
[kdeplasma-addons] [Bug 452596] Comics widget does not show image
https://bugs.kde.org/show_bug.cgi?id=452596 --- Comment #8 from Alexander Lohnau --- For whatever reasons the automatic mention of the MR did not work. Here is the fix: https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/508 -- You are receiving this mail because: You are watching all bug changes.
[kdeplasma-addons] [Bug 452596] Comics widget does not show image
https://bugs.kde.org/show_bug.cgi?id=452596 --- Comment #7 from Kishore Gopalakrishnan --- (In reply to Kishore Gopalakrishnan from comment #6) > Reverting this commit (on v5.93.0) fixes the issue for me: > > commit 1ec7b42cad83121cf6b212e61ce1cd555b5b > Author: Alexander Lohnau > Date: Sun Mar 6 16:40:43 2022 +0100 > > Port dateengine away from inperformant KPluginInfo hack > > We do not need to create a QVariantList only to later create a > KPluginMetaData > object from it. > > > (cherry picked from commit af5785be6ac4bf5e383eba9b10dec392231d59f3) > > src/plasma/dataengine.cpp | 6 +- > src/plasma/dataengine.h | 2 +- > src/plasma/pluginloader.cpp | 2 +- > 3 files changed, 7 insertions(+), 3 deletions(-) Forgot to mention, this is on the plasma-framework repo -- You are receiving this mail because: You are watching all bug changes.
[kdeplasma-addons] [Bug 452596] Comics widget does not show image
https://bugs.kde.org/show_bug.cgi?id=452596 --- Comment #6 from Kishore Gopalakrishnan --- Reverting this commit (on v5.93.0) fixes the issue for me: commit 1ec7b42cad83121cf6b212e61ce1cd555b5b Author: Alexander Lohnau Date: Sun Mar 6 16:40:43 2022 +0100 Port dateengine away from inperformant KPluginInfo hack We do not need to create a QVariantList only to later create a KPluginMetaData object from it. (cherry picked from commit af5785be6ac4bf5e383eba9b10dec392231d59f3) src/plasma/dataengine.cpp | 6 +- src/plasma/dataengine.h | 2 +- src/plasma/pluginloader.cpp | 2 +- 3 files changed, 7 insertions(+), 3 deletions(-) -- You are receiving this mail because: You are watching all bug changes.
[kdeplasma-addons] [Bug 452596] Comics widget does not show image
https://bugs.kde.org/show_bug.cgi?id=452596 --- Comment #5 from Kishore Gopalakrishnan --- Created attachment 148190 --> https://bugs.kde.org/attachment.cgi?id=148190=edit Output when running plasmashell from the terminal @Alexander Lohnau, I went to kdebugsettings and clicked the 'enable all debug' button. After a reboot, output from plasmashell stopped appearing in my system logs (not sure if that's a bug in the way kdebugsettings sets things, or if it's expected behaviour). On killing plasmashell and starting it again from a terminal, this is the text output I got (attached file). -- You are receiving this mail because: You are watching all bug changes.
[kdeplasma-addons] [Bug 452596] Comics widget does not show image
https://bugs.kde.org/show_bug.cgi?id=452596 --- Comment #4 from Kishore Gopalakrishnan --- (In reply to Alexander Lohnau from comment #3) > The "Unable to find service type for service" parts can be safely ignored, > because the conversion still works file (fixed in master for some time now). > Please install kdebugsettings, enable full debug for ork.kde.plasma.comic. > Then you should get more detailed logs. > > >noticed after update last night. > > What version did you update from? This happened for me after a frameworks update (5.92 -> 5.93). Downgrading plasma-framework to 5.92 fixed the issue for me. -- You are receiving this mail because: You are watching all bug changes.
[kdeplasma-addons] [Bug 452596] Comics widget does not show image
https://bugs.kde.org/show_bug.cgi?id=452596 Kishore Gopalakrishnan changed: What|Removed |Added CC||kishor...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[kdeplasma-addons] [Bug 452596] Comics widget does not show image
https://bugs.kde.org/show_bug.cgi?id=452596 --- Comment #3 from Alexander Lohnau --- The "Unable to find service type for service" parts can be safely ignored, because the conversion still works file (fixed in master for some time now). Please install kdebugsettings, enable full debug for ork.kde.plasma.comic. Then you should get more detailed logs. >noticed after update last night. What version did you update from? -- You are receiving this mail because: You are watching all bug changes.
[kdeplasma-addons] [Bug 452596] Comics widget does not show image
https://bugs.kde.org/show_bug.cgi?id=452596 Alexander Lohnau changed: What|Removed |Added Assignee|notm...@gmail.com |alexander.loh...@gmx.de -- You are receiving this mail because: You are watching all bug changes.
[kdeplasma-addons] [Bug 452596] Comics widget does not show image
https://bugs.kde.org/show_bug.cgi?id=452596
--- Comment #2 from Twisted Lucidity ---
Thanks for replying, Alexander.
I meant the plain "Garfield" plugin by mfuchs: https://store.kde.org/p/1080450
I removed all comic plugins.
I also ran a full update (no changes were made).
I added "Square root of Garfield".
This failed to show any strip.
Log:
Apr 15 08:13:52 neon plasmashell[2204]: Either no identifier was
specified or the engine could not be created: id "garfield-sromg" engine valid:
false
Apr 15 08:13:52 neon plasmashell[2204]: "garfield-sromg" has a newer
strip.
Apr 15 08:13:52 neon plasmashell[2204]: "pageRetrieved - id: 1"
Apr 15 08:13:52 neon plasmashell[2204]: "Next identifier: 47131"
Apr 15 08:13:52 neon plasmashell[2204]: "Previous identifier: 4712"
Apr 15 08:13:52 neon plasmashell[2204]:
"https://www.mezzacotta.net/garfield/comics/4713.png;
Apr 15 08:13:52 neon plasmashell[2204]: "pageRetrieved - id: 0"
Apr 15 08:13:52 neon plasmashell[2204]: "Last identifier: 4713"
Apr 15 08:13:52 neon plasmashell[2204]: "pageRetrieved - id: 2"
Apr 15 08:13:51 neon plasmashell[2204]: kf.coreaddons.desktopparser:
Unable to find service type for service "Plasma/Comic" listed in
"/home/name/.local/share/plasma/comics/garfield-sromg/metadata.desktop" -
service type search directories were ("/home/name/.local/share",
"/usr/share/plasma", "/usr/local/share", "/usr/share",
"/var/lib/snapd/desktop")
Apr 15 08:13:51 neon plasmashell[2204]: kf.coreaddons.desktopparser:
Unable to find service type for service "Plasma/Comic" listed in
"/home/name/.local/share/plasma/comics/garfield-sromg//metadata.desktop" -
service type search directories were ("/home/name/.local/share",
"/usr/share/plasma", "/usr/local/share", "/usr/share",
"/var/lib/snapd/desktop")
Apr 15 08:13:51 neon plasmashell[2204]: Either no identifier was
specified or the engine could not be created: id "garfield-sromg" engine valid:
false
Apr 15 08:13:51 neon plasmashell[2204]: qml:
onCurrentTabChanged:garfield-sromg
Apr 15 08:13:51 neon plasmashell[2204]: kf.coreaddons.desktopparser:
Unable to find service type for service "Plasma/Comic" listed in
"/home/name/.local/share/plasma/comics/garfield-sromg/metadata.desktop" -
service type search directories were ("/home/name/.local/share",
"/usr/share/plasma", "/usr/local/share", "/usr/share",
"/var/lib/snapd/desktop")
Apr 15 08:13:51 neon plasmashell[2204]: kf.coreaddons.desktopparser:
Unable to find service type for service "Plasma/Comic" listed in
"/home/name/.local/share/plasma/comics/garfield-sromg/metadata.desktop" -
service type search directories were ("/home/name/.local/share",
"/usr/share/plasma", "/usr/local/share", "/usr/share",
"/var/lib/snapd/desktop")
Apr 15 08:13:51 neon plasmashell[2204]: kf.coreaddons.desktopparser:
Unable to find service type for service "Plasma/Comic" listed in
"/home/name/.local/share/plasma/comics/garfield-sromg//metadata.desktop" -
service type search directories were ("/home/name/.local/share",
"/usr/share/plasma", "/usr/local/share", "/usr/share",
"/var/lib/snapd/desktop")
Apr 15 08:13:51 neon plasmashell[2204]: Either no identifier was
specified or the engine could not be created: id "" engine valid: false
Apr 15 08:13:49 neon plasmashell[2204]: qt.qpa.xcb: QXcbConnection: XCB
error: 152 (Unknown), sequence: 13257, resource id: 54526115, major code: 144
(Unknown), minor code: 2
Apr 15 08:13:49 neon plasmashell[2204]: qt.qpa.xcb: QXcbConnection: XCB
error: 3 (BadWindow), sequence: 13256, resource id: 54526101, major code: 143
(Unknown), minor code: 3
Apr 15 08:13:49 neon plasmashell[2204]: qt.qpa.xcb: QXcbConnection: XCB
error: 3 (BadWindow), sequence: 13255, resource id: 54526101, major code: 2
(ChangeWindowAttributes), minor code: 0
Apr 15 08:13:49 neon plasmashell[2204]: qt.qpa.xcb: QXcbConnection: XCB
error: 9 (BadDrawable), sequence: 13254, resource id: 54526101, major code: 144
(Unknown), minor code: 1
Apr 15 08:13:49 neon plasmashell[2204]: qt.qpa.xcb: QXcbConnection: XCB
error: 3 (BadWindow), sequence: 13253, resource id: 54526101, major code: 143
(Unknown), minor code: 1
Apr 15 08:13:49 neon plasmashell[2204]: qt.qpa.xcb: QXcbConnection: XCB
error: 3 (BadWindow), sequence: 13252, resource id: 54526101, major code: 3
(GetWindowAttributes), minor code: 0
Apr 15 08:13:46 neon plasmashell[2204]: kf.coreaddons.desktopparser:
Unable to find service type for service "Plasma/Comic" listed in
"/home/name/.local/share/plasma/comics/garfield-sromg/metadata.desktop" -
service type search directories were ("/home/name/.local/share",
"/usr/share/plasma", "/usr/local/share", "/usr/share",
"/var/lib/snapd/desktop")
Apr 15 08:13:46 neon plasmashell[2204]: kf.coreaddons.desktopparser:
Unable to find service type for service "Plasma/Comic" listed in
[kdeplasma-addons] [Bug 452596] Comics widget does not show image
https://bugs.kde.org/show_bug.cgi?id=452596 --- Comment #1 from Alexander Lohnau --- The issue is that a path generated by the plugin is not considered a valid URL. The plugin requests "http://es.xkcd.com../../site_media/strips/survivorship_bias.png; as a URL, which is not considered valid. This malformed value comes from the source of the website. >Other affected strips include APOD, Calvin and Hobbes, Dilbert, and Garfield You mean "Square Root of Minus Garfield"? That works fine for me. I did some big refactorings lately to the code. Maybe you have a case where one malformed comic plugin blocks the entire applet? Please try disabling the xkcd plugin, restart plasmashell and try the other comics. -- You are receiving this mail because: You are watching all bug changes.
[kdeplasma-addons] [Bug 452596] Comics widget does not show image
https://bugs.kde.org/show_bug.cgi?id=452596 Nate Graham changed: What|Removed |Added CC||alexander.loh...@gmx.de, ||n...@kde.org, ||qydwhotm...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
