[kdevelop] [Bug 376586] Kdevelop crashes during parsing on large PHP projects/files [DeclarationBuilder::inferArgumentsFromCall]

[Kevin Funk]

https://bugs.kde.org/show_bug.cgi?id=376586

Kevin Funk  changed:

   What|Removed |Added

  Latest Commit||https://commits.kde.org/kde
   ||velop/8f62583027a7d0ce89d09
   ||93bcb205fdda7317be6
 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED
   Version Fixed In||5.1.0

--- Comment #12 from Kevin Funk  ---
Git commit 8f62583027a7d0ce89d0993bcb205fdda7317be6 by Kevin Funk.
Committed on 12/03/2017 at 21:27.
Pushed by kfunk into branch '5.1'.

qmljs: Fix crash access internal function context

Fix crash accessing non-existent internal function context.
Unfortunately the reporter can't provide any test QML/JS files.

Note: kdevplatform duchain still warns when encountering function decls
without valid internal function context. This scenario should never
happen to begin with.
  kdevplatform.language: Import of function declaration without internal
function context encountered!
FIXED-IN: 5.1.0

M  +1-1languages/qmljs/duchain/declarationbuilder.cpp

https://commits.kde.org/kdevelop/8f62583027a7d0ce89d0993bcb205fdda7317be6

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 376586] Kdevelop crashes during parsing on large PHP projects/files [DeclarationBuilder::inferArgumentsFromCall]

[robert]

https://bugs.kde.org/show_bug.cgi?id=376586

--- Comment #11 from robert  ---
Sorry for my late reply, had a busy week :/

Can confirm, with the patch the latest code from git compiles and does not
crash when background parser is enabled.

here is some console output when starting kdevelop

kdevelop
kdevplatform.serialization: version-hint not found, seems to be an old version
kdevplatform.serialization: "The data-repository at
/home/buchinger/.cache/kdevduchain/kdevelop-{a8bcc2d5-005a-4a9a-9448-f2b870d9b819}
has to be cleared."
Waiting for already running kbuildsycoca5 to finish.
Not loading plugin named "KDevNinjaBuilder" because it has been disabled!
Invalid return type in method "core"
Invalid return type in method "core"
kdevplatform.language: Document got removed during parse job creation:
"/usr/share/kdevqmljssupport/nodejsmodules/__builtin_ecmascript.js"
kdevplatform.language: Import of function declaration without internal function
context encountered!
kdevplatform.language: Import of function declaration without internal function
context encountered!
kdevplatform.language: Import of function declaration without internal function
context encountered!
kdevplatform.language: Import of function declaration without internal function
context encountered!
kdevplatform.language: Import of function declaration without internal function
context encountered!
kdevplatform.language: Import of function declaration without internal function
context encountered!
kdevplatform.language: Import of function declaration without internal function
context encountered!
kdevplatform.language: Import of function declaration without internal function
context encountered!

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 376586] Kdevelop crashes during parsing on large PHP projects/files [DeclarationBuilder::inferArgumentsFromCall]

[Kevin Funk]

https://bugs.kde.org/show_bug.cgi?id=376586

--- Comment #10 from Kevin Funk  ---
@robert: Any luck to test my patch?

I'd really like to fix this before the 5.1.0 release, which is about to happen
this weekend.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 376586] Kdevelop crashes during parsing on large PHP projects/files [DeclarationBuilder::inferArgumentsFromCall]

[Kevin Funk]

https://bugs.kde.org/show_bug.cgi?id=376586

Kevin Funk  changed:

   What|Removed |Added

   Severity|normal  |crash

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 376586] Kdevelop crashes during parsing on large PHP projects/files [DeclarationBuilder::inferArgumentsFromCall]

[Kevin Funk]

https://bugs.kde.org/show_bug.cgi?id=376586

Kevin Funk  changed:

   What|Removed |Added

   Priority|NOR |HI
   Keywords||release_blocker

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 376586] Kdevelop crashes during parsing on large PHP projects/files [DeclarationBuilder::inferArgumentsFromCall]

[robert]

https://bugs.kde.org/show_bug.cgi?id=376586

--- Comment #9 from robert  ---
@kevin
no sorry the project is not public. will check if its always the same file that
causes a crash.


also, will try to build the latest git version of kdevelop and kdevplatform and
keep you informed about it.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 376586] Kdevelop crashes during parsing on large PHP projects/files [DeclarationBuilder::inferArgumentsFromCall]

[Kevin Funk]

https://bugs.kde.org/show_bug.cgi?id=376586

Kevin Funk  changed:

   What|Removed |Added

   Target Milestone|--- |5.1.0

--- Comment #8 from Kevin Funk  ---
@robert: Does this patch in kdevelop.git fix your issue?

@steckdenis: Opinions?

diff --git a/languages/qmljs/duchain/declarationbuilder.cpp
b/languages/qmljs/duchain/declarationbuilder.cpp
index fb0cb5d..b1e2b0e 100644
--- a/languages/qmljs/duchain/declarationbuilder.cpp
+++ b/languages/qmljs/duchain/declarationbuilder.cpp
@@ -330,7 +330,7 @@ void
DeclarationBuilder::inferArgumentsFromCall(QmlJS::AST::Node* base, QmlJS::A

 auto func_declaration =
dynamic_cast(func_type->declaration(topContext()));

-if (!func_declaration) {
+if (!func_declaration || !func_declaration->internalContext()) {
 return;
 }

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 376586] Kdevelop crashes during parsing on large PHP projects/files [DeclarationBuilder::inferArgumentsFromCall]

[Kevin Funk]

https://bugs.kde.org/show_bug.cgi?id=376586

Kevin Funk  changed:

   What|Removed |Added

 CC||steckde...@yahoo.fr

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 376586] Kdevelop crashes during parsing on large PHP projects/files [DeclarationBuilder::inferArgumentsFromCall]

[Kevin Funk]

https://bugs.kde.org/show_bug.cgi?id=376586

--- Comment #7 from Kevin Funk  ---
@robert: Also, for work-arounding the crash you can start KDevelop just like
this:
  KDEV_DISABLE_PLUGINS=kdevqmljs kdevelop ...

This will disable the QML/JS language support

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 376586] Kdevelop crashes during parsing on large PHP projects/files [DeclarationBuilder::inferArgumentsFromCall]

[Kevin Funk]

https://bugs.kde.org/show_bug.cgi?id=376586

Kevin Funk  changed:

   What|Removed |Added

Summary|Kdevelop crashes during |Kdevelop crashes during
   |parsing on large PHP|parsing on large PHP
   |projects/files  |projects/files
   ||[DeclarationBuilder::inferA
   ||rgumentsFromCall]

--- Comment #6 from Kevin Funk  ---
Pasting backtrace of crashing thread inline to make it appear in searches:

Thread 11 (Thread 0x7fec7a194700 (LWP 17234)):
[KCrash Handler]
#6  0x7fec64cdb7a7 in
DeclarationBuilder::inferArgumentsFromCall(QmlJS::AST::Node*,
QmlJS::AST::ArgumentList*) (this=0x7fec7a193bc0, base=,
arguments=0x7fec61703338) at
/tmp/build/kdevelop/src/kdevelop-5.0.4/languages/qmljs/duchain/declarationbuilder.cpp:338
#7  0x7fec64cdbd61 in
DeclarationBuilder::visit(QmlJS::AST::CallExpression*) (this=,
node=) at
/tmp/build/kdevelop/src/kdevelop-5.0.4/languages/qmljs/duchain/declarationbuilder.cpp:474
#8  0x7fec64d06fb0 in
QmlJS::AST::CallExpression::accept0(QmlJS::AST::Visitor*) (this=0x7fec61703440,
visitor=0x7fec7a193c18) at
/tmp/build/kdevelop/src/kdevelop-5.0.4/languages/qmljs/libs/qmljs/parser/qmljsast.cpp:301
#9  0x7fec64d0694c in QmlJS::AST::Node::accept(QmlJS::AST::Visitor*)
(this=0x7fec61703440, visitor=0x7fec7a193c18) at
/tmp/build/kdevelop/src/kdevelop-5.0.4/languages/qmljs/libs/qmljs/parser/qmljsast.cpp:42
#10 0x7fec64cd95ff in ContextBuilder::findType(QmlJS::AST::Node*)
(this=this@entry=0x7fec7a193bc0, node=0x7fec61703440) at
/tmp/build/kdevelop/src/kdevelop-5.0.4/languages/qmljs/duchain/contextbuilder.cpp:61
#11 0x7fec64cdc2aa in
DeclarationBuilder::visit(QmlJS::AST::ReturnStatement*) (this=0x7fec7a193bc0,
node=0x7fec61703480) at
/tmp/build/kdevelop/src/kdevelop-5.0.4/languages/qmljs/duchain/declarationbuilder.cpp:277
#12 0x7fec64d07e58 in
QmlJS::AST::ReturnStatement::accept0(QmlJS::AST::Visitor*)
(this=0x7fec61703480, visitor=0x7fec7a193c18) at
/tmp/build/kdevelop/src/kdevelop-5.0.4/languages/qmljs/libs/qmljs/parser/qmljsast.cpp:611
#13 0x7fec64d0694c in QmlJS::AST::Node::accept(QmlJS::AST::Visitor*)
(this=0x7fec61703480, visitor=0x7fec7a193c18) at
/tmp/build/kdevelop/src/kdevelop-5.0.4/languages/qmljs/libs/qmljs/parser/qmljsast.cpp:42
#14 0x7fec64d08733 in QmlJS::AST::Node::accept(QmlJS::AST::Node*,
QmlJS::AST::Visitor*) (visitor=0x7fec7a193c18, node=) at
/tmp/build/kdevelop/src/kdevelop-5.0.4/languages/qmljs/libs/qmljs/parser/qmljsast.cpp:50
#15 0x7fec64d08733 in
QmlJS::AST::StatementSourceElement::accept0(QmlJS::AST::Visitor*)
(this=0x7fec617034b8, visitor=0x7fec7a193c18) at
/tmp/build/kdevelop/src/kdevelop-5.0.4/languages/qmljs/libs/qmljs/parser/qmljsast.cpp:796
#16 0x7fec64d0694c in QmlJS::AST::Node::accept(QmlJS::AST::Visitor*)
(this=0x7fec617034b8, visitor=0x7fec7a193c18) at
/tmp/build/kdevelop/src/kdevelop-5.0.4/languages/qmljs/libs/qmljs/parser/qmljsast.cpp:42
#17 0x7fec64d08649 in QmlJS::AST::Node::accept(QmlJS::AST::Node*,
QmlJS::AST::Visitor*) (visitor=0x7fec7a193c18, node=) at
/tmp/build/kdevelop/src/kdevelop-5.0.4/languages/qmljs/libs/qmljs/parser/qmljsast.cpp:50
#18 0x7fec64d08649 in
QmlJS::AST::SourceElements::accept0(QmlJS::AST::Visitor*) (this=0x7fec617034d0,
visitor=0x7fec7a193c18) at
/tmp/build/kdevelop/src/kdevelop-5.0.4/languages/qmljs/libs/qmljs/parser/qmljsast.cpp:777
#19 0x7fec64d0694c in QmlJS::AST::Node::accept(QmlJS::AST::Visitor*)
(this=0x7fec617034d0, visitor=0x7fec7a193c18) at
/tmp/build/kdevelop/src/kdevelop-5.0.4/languages/qmljs/libs/qmljs/parser/qmljsast.cpp:42
#20 0x7fec64d08563 in QmlJS::AST::Node::accept(QmlJS::AST::Node*,
QmlJS::AST::Visitor*) (visitor=0x7fec7a193c18, node=) at
/tmp/build/kdevelop/src/kdevelop-5.0.4/languages/qmljs/libs/qmljs/parser/qmljsast.cpp:50
#21 0x7fec64d08563 in
QmlJS::AST::FunctionBody::accept0(QmlJS::AST::Visitor*) (this=0x7fec617034f0,
visitor=0x7fec7a193c18) at
/tmp/build/kdevelop/src/kdevelop-5.0.4/languages/qmljs/libs/qmljs/parser/qmljsast.cpp:758
#22 0x7fec64d0694c in QmlJS::AST::Node::accept(QmlJS::AST::Visitor*)
(this=0x7fec617034f0, visitor=0x7fec7a193c18) at
/tmp/build/kdevelop/src/kdevelop-5.0.4/languages/qmljs/libs/qmljs/parser/qmljsast.cpp:42
#23 0x7fec64d08dca in QmlJS::AST::Node::accept(QmlJS::AST::Node*,
QmlJS::AST::Visitor*) (node=, visitor=) at
/tmp/build/kdevelop/src/kdevelop-5.0.4/languages/qmljs/libs/qmljs/parser/qmljsast.cpp:50
#24 0x7fec64ce3dc9 in
DeclarationBuilder::declareFunction(QmlJS::AST::Node*,
bool, KDevelop::QualifiedIdentifier const&, KDevelop::RangeInRevision const&,
QmlJS::AST::Node*, KDevelop::RangeInRevision const&, QmlJS::AST::Node*,
KDevelop::RangeInRevision const&) (this=this@entry=0x7fec7a193bc0,
node=node@entry=0x7fec61703508,

[kdevelop] [Bug 376586] Kdevelop crashes during parsing on large PHP projects/files

[Kevin Funk]

https://bugs.kde.org/show_bug.cgi?id=376586

Kevin Funk  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|RESOLVED|REOPENED
 Resolution|WAITINGFORINFO  |---

--- Comment #5 from Kevin Funk  ---
@robert: Is that project public so we can try to reproduce ourselves?

If not, could you please post the ~100 last lines of the stdout/stderr KDevelop
before it crashes? It should tell which file it currently tries to parse
(that's an indicator which file to send us for a minimal working example).

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 376586] Kdevelop crashes during parsing on large PHP projects/files

[robert]

https://bugs.kde.org/show_bug.cgi?id=376586

--- Comment #4 from robert  ---
latest build still crashing (kdevelop 5.0.4)

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 376586] Kdevelop crashes during parsing on large PHP projects/files

[robert]

https://bugs.kde.org/show_bug.cgi?id=376586

robert  changed:

   What|Removed |Added

Version|5.0.3   |5.0.4

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 376586] Kdevelop crashes during parsing on large PHP projects/files

[robert]

https://bugs.kde.org/show_bug.cgi?id=376586

--- Comment #3 from robert  ---
Created attachment 104379
  --> https://bugs.kde.org/attachment.cgi?id=104379=edit
crash log for kdevelop 5.0.4 (rebuilt with makepkg options=(debug !strip) )

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 376586] Kdevelop crashes during parsing on large PHP projects/files

[robert]

https://bugs.kde.org/show_bug.cgi?id=376586

--- Comment #2 from robert  ---
I will try without rebuilding my whole dev space.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 376586] Kdevelop crashes during parsing on large PHP projects/files

[Kevin Funk]

https://bugs.kde.org/show_bug.cgi?id=376586

Kevin Funk  changed:

   What|Removed |Added

  Component|Language Support: PHP   |Language Support:
   ||QML/JavaScript

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 376586] Kdevelop crashes during parsing on large PHP projects/files

[Kevin Funk]

https://bugs.kde.org/show_bug.cgi?id=376586

Kevin Funk  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |WAITINGFORINFO

--- Comment #1 from Kevin Funk  ---
Crash inside the QML/JS parser plugin:

Thread 10 (Thread 0x7fe1abfff700 (LWP 1979)):
[KCrash Handler]
#6  0x7fe1a8b3d11a in  () at
/usr/lib/qt/plugins/kdevplatform/25/kdevqmljslanguagesupport.so
#7  0x7fe1a8b3d691 in  () at
/usr/lib/qt/plugins/kdevplatform/25/kdevqmljslanguagesupport.so
#8  0x7fe1a8b6c038 in  () at
/usr/lib/qt/plugins/kdevplatform/25/kdevqmljslanguagesupport.so
#9  0x7fe1a8b6db3c in  () at
/usr/lib/qt/plugins/kdevplatform/25/kdevqmljslanguagesupport.so
#10 0x7fe1a8b3b37c in  () at
/usr/lib/qt/plugins/kdevplatform/25/kdevqmljslanguagesupport.so
#11 0x7fe1a8b3db5a in  () at
/usr/lib/qt/plugins/kdevplatform/25/kdevqmljslanguagesupport.so


Could you please try to instal debugging symbols for this plugin and try to
reproduce the crash? Please send the backtrace another time.

See:
https://community.kde.org/Guidelines_and_HOWTOs/Debugging/How_to_create_useful_crash_reports

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 376586] Kdevelop crashes during parsing on large PHP projects/files

[robert]

https://bugs.kde.org/show_bug.cgi?id=376586

robert  changed:

   What|Removed |Added

   Platform|Other   |Archlinux Packages

-- 
You are receiving this mail because:
You are watching all bug changes.