[kdevelop] [Bug 391127] svn+ssh doesn't work with password auth

[Kevin Funk]

https://bugs.kde.org/show_bug.cgi?id=391127

Kevin Funk  changed:

   What|Removed |Added

 CC||mcgu...@kde.org

--- Comment #10 from Kevin Funk  ---
*** Bug 184845 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 391127] svn+ssh doesn't work with password auth

[Christoph Roick]

https://bugs.kde.org/show_bug.cgi?id=391127

--- Comment #9 from Christoph Roick  ---
@Kevin: I'm not fully convinced.
One problem is, that SSH_ASKPASS is ignored if a terminal is set [1]. So one
would have to trick ssh into believing that there is no terminal; which is
explained in [1].
Interestingly ssh-askpass is not part of my system (probably due to relying on
the environment variable). That's where the idea of making KDevelop itself some
kind of default askpass program was coming from.

Nevertheless, setting the environment variable to some default value would
surely be a start.

[1] https://unix.stackexchange.com/a/272524

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 391127] svn+ssh doesn't work with password auth

[Kevin Funk]

https://bugs.kde.org/show_bug.cgi?id=391127

--- Comment #8 from Kevin Funk  ---
@Christoph: Well, see the code I linked to. QtCreator does just use platform
defaults (and also respects the SSH_ASKPASS env var if available).

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 391127] svn+ssh doesn't work with password auth

[Christoph Roick]

https://bugs.kde.org/show_bug.cgi?id=391127

--- Comment #7 from Christoph Roick  ---
Ok, but what should it be set to? KDevelop doesn't really know what kind of
program could be used to query a password, no?
Maybe a call to KDevelop itself with a new parameter could be used? Like:

SSH_ASKPASS="kdevelop --query-pw"

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 391127] svn+ssh doesn't work with password auth

[Kevin Funk]

https://bugs.kde.org/show_bug.cgi?id=391127

Kevin Funk  changed:

   What|Removed |Added

   Keywords||junior-jobs
 Ever confirmed|0   |1
 Status|UNCONFIRMED |CONFIRMED

--- Comment #6 from Kevin Funk  ---
Sounds like a feasible approach. Some other *cough*QtCreator*cough* famous IDE
does that as well. [1]

That's a great junior job. So in case you're interested in getting this fixed
this is also something you could work on!

[1] See: 
 
https://github.com/qt-creator/qt-creator/blob/master/src/plugins/vcsbase/commonvcssettings.cpp#L45
(and related lines in that file)

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 391127] svn+ssh doesn't work with password auth

[Matthew Trescott]

https://bugs.kde.org/show_bug.cgi?id=391127

--- Comment #5 from Matthew Trescott  ---
Couldn't you set SSH_ASKPASS with putenv() before calling SVN-related
functions? I imagine ssh is a child process started by svn...?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 391127] svn+ssh doesn't work with password auth

[Christoph Roick]

https://bugs.kde.org/show_bug.cgi?id=391127

--- Comment #4 from Christoph Roick  ---
You are right, when run from a terminal, the password seems to be always
requested there inside (which is not specific for svn).
I was referring to having SSH_ASKPASS=ksshaskpass set for the environment, when
starting the usual way.

The point is, that the SVN library never gives a response to KDevelop
requesting a password, since it directly calls ssh. And ssh prompts for the
password in the terminal if there is one or uses SSH_ASKPASS otherwise.

I don't see how this could easily be fixed. Maybe consider setting the
environment variable as a workaround.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 391127] svn+ssh doesn't work with password auth

[Matthew Trescott]

https://bugs.kde.org/show_bug.cgi?id=391127

--- Comment #3 from Matthew Trescott  ---
Well, I wasn't running KDevelop in a terminal before and unfortunately I don't
remember what the error was, but I'm certain it was because I couldn't enter my
password for SVN. I didn't have any error this time because I was able to enter
my password, but even though I used SSH_ASKPASS=ksshaskpass kdevelop the prompt
was still in the terminal rather than as a dialog. I don't think it should be
necessary to change environment variables or run the IDE from a terminal just
to enter your SVN password though---KDevelop should be smart enough to find an
ssh askpass program if there isn't one specified in an environment variable.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 391127] svn+ssh doesn't work with password auth

[Christoph Roick]

https://bugs.kde.org/show_bug.cgi?id=391127

--- Comment #2 from Christoph Roick  ---
Using "SSH_ASKPASS=ksshaskpass"
(https://wiki.archlinux.org/index.php/KDE_Wallet) or "SSH_ASKPASS=" (password
will be asked in the terminal) I cannot confirm the issue. Some problems were
fixed in commit 9fd4f6c25f6c712a76672e0b3acbefef7d4fd155, but they are not
directly related to ssh authentication.

What kind of error do you get?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevelop] [Bug 391127] svn+ssh doesn't work with password auth

[Kevin Funk]

https://bugs.kde.org/show_bug.cgi?id=391127

Kevin Funk  changed:

   What|Removed |Added

 CC||chris...@gmx.de

--- Comment #1 from Kevin Funk  ---
CC'ing Christoph who might be interested in looking at this.

-- 
You are receiving this mail because:
You are watching all bug changes.