[kdevplatform] [Bug 374351] Purpose: send to ReviewBoard doesn't work on OS X and (sometimes) causes a crash on exit

2016-12-31 Thread RJVB 
https://bugs.kde.org/show_bug.cgi?id=374351

RJVB  changed:

   What|Removed |Added

 Status|NEEDSINFO   |RESOLVED
  Latest Commit||https://commits.kde.org/pur
   ||pose/3b558384a367ad1a9005ae
   ||00a9b53f1a922520fc
 Resolution|LATER   |FIXED

--- Comment #6 from RJVB  ---
Git commit 3b558384a367ad1a9005ae00a9b53f1a922520fc by René J.V. Bertin.
Committed on 31/12/2016 at 19:25.
Pushed by rjvbb into branch 'master'.

purposeprocess should be a nongui executable

Mark purposeprocess as a nongui executable to prevent building it
as an app bundle on Mac.

M  +1-0CMakeLists.txt
M  +1-0src/CMakeLists.txt

https://commits.kde.org/purpose/3b558384a367ad1a9005ae00a9b53f1a922520fc

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevplatform] [Bug 374351] Purpose: send to ReviewBoard doesn't work on OS X and (sometimes) causes a crash on exit

2016-12-31 Thread Aleix Pol 
https://bugs.kde.org/show_bug.cgi?id=374351

--- Comment #5 from Aleix Pol  ---
Whichever you feel most comfortable with

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevplatform] [Bug 374351] Purpose: send to ReviewBoard doesn't work on OS X and (sometimes) causes a crash on exit

2016-12-31 Thread RJVB 
https://bugs.kde.org/show_bug.cgi?id=374351

--- Comment #4 from RJVB  ---
To be certain: submit for review or commit directly?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevplatform] [Bug 374351] Purpose: send to ReviewBoard doesn't work on OS X and (sometimes) causes a crash on exit

2016-12-31 Thread Aleix Pol 
https://bugs.kde.org/show_bug.cgi?id=374351

Aleix Pol  changed:

   What|Removed |Added

 CC||aleix...@kde.org

--- Comment #3 from Aleix Pol  ---
Can you please submit that patch?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevplatform] [Bug 374351] Purpose: send to ReviewBoard doesn't work on OS X and (sometimes) causes a crash on exit

2016-12-30 Thread Kevin Funk 
https://bugs.kde.org/show_bug.cgi?id=374351

Kevin Funk  changed:

   What|Removed |Added

 CC||aleix...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevplatform] [Bug 374351] Purpose: send to ReviewBoard doesn't work on OS X and (sometimes) causes a crash on exit

2016-12-30 Thread RJVB 
https://bugs.kde.org/show_bug.cgi?id=374351

--- Comment #2 from RJVB  ---
Created attachment 103098
  --> https://bugs.kde.org/attachment.cgi?id=103098=edit
purposeprocess is a nongui exec

purposeprocess must not be built as an app bundle on OS X, but as a regular
executable that will be installed on the path.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevplatform] [Bug 374351] Purpose: send to ReviewBoard doesn't work on OS X and (sometimes) causes a crash on exit

2016-12-30 Thread RJVB 
https://bugs.kde.org/show_bug.cgi?id=374351

RJVB  changed:

   What|Removed |Added

 Resolution|--- |LATER
 Status|UNCONFIRMED |NEEDSINFO

--- Comment #1 from RJVB  ---
I think this was operator error; I forgot to apply a patch which explains why
the executable wasn't found.

Uploading works again, but the dialog is still sized wrong each time I open it
(vertical height too small).

-- 
You are receiving this mail because:
You are watching all bug changes.