[kdevplatform] [Bug 374458] Crash when dragging launches in Launch Configuration

[Aetf]

https://bugs.kde.org/show_bug.cgi?id=374458

Aetf <7437...@gmail.com> changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED
   Version Fixed In||5.1

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevplatform] [Bug 374458] Crash when dragging launches in Launch Configuration

[Aetf]

https://bugs.kde.org/show_bug.cgi?id=374458

--- Comment #9 from Aetf <7437...@gmail.com> ---
Francis could you try https://phabricator.kde.org/D4555 and see if it works for
you?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevplatform] [Bug 374458] Crash when dragging launches in Launch Configuration

[Aetf]

https://bugs.kde.org/show_bug.cgi?id=374458

--- Comment #8 from Aetf <7437...@gmail.com> ---
Oh I see. Didn't know much about git describe before. ;P

Now I can finally reproduce the crash. Launcher items are in fact not
draggable. But the crash happens when you click & hold the cursor, then move
from a top-level item to its child item, e.g. Debug mode. And it only happens
under the following condition:

1. The top-level item must have a child. (Compiled binary, Plasmoid launcher)
2. The child item must be a debug configuration with GDB selected. LLDB won't
trigger the crash

The crash happens because the code tries to set 'gdb' as launch configuration
type on the wrong item. However this is before
`LaunchConfiguration::launcherForMode` got called.

I don't know how the 'gdb' type string was generated yet. I'm still tracing
down the logic when changing pages in the dialog.

Will report back with more info later.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevplatform] [Bug 374458] Crash when dragging launches in Launch Configuration

[Francis Herne]

https://bugs.kde.org/show_bug.cgi?id=374458

--- Comment #7 from Francis Herne  ---
`git describe` adds the leading 'g' for whatever reason; you must checkout
either the full string ("v5.0.80-70-gd270016ad") or skip the 'g' ("d270016ad").

That's "Remove no longer needed spacer, now that we are a QFormLayout".

I have no other versions installed and don't use makepkg, only
`cmake`->`make`->`make install`. No local patches currently.

I do have the [testing] repo enabled, but the bug's been there for at least a
few weeks so the versions I had originally will be in stable by now.

For exactly what I'm doing, see the attachment.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevplatform] [Bug 374458] Crash when dragging launches in Launch Configuration

[Francis Herne]

https://bugs.kde.org/show_bug.cgi?id=374458

--- Comment #6 from Francis Herne  ---
Created attachment 103945
  --> https://bugs.kde.org/attachment.cgi?id=103945=edit
Dragging in launch dialog, causing a crash

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevplatform] [Bug 374458] Crash when dragging launches in Launch Configuration

[Aetf]

https://bugs.kde.org/show_bug.cgi?id=374458

--- Comment #5 from Aetf <7437...@gmail.com> ---
Hmm, that's weird. I'm on Arch x86_64 too, with qt 5.8.0. And it works normally
with today's 5.1 branch HEAD:

kdevplatform: 3e2549d39
kdevelop: 2c1a1fd7f6

And in fact I can't find commit gd270016ad or g2c1a1fd7f6 in the repo...

>From your version string I guess you used makepkg to build & install? Is there
anything special in the PKGBUILD?

For sanity check, is there another different version of kdevelop in your
system? And just in case, we are talking about the tree view in the "Launch
Configurations" dialog which is opened when you click "Run -> Configure
Launches...", right?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevplatform] [Bug 374458] Crash when dragging launches in Launch Configuration

[Francis Herne]

https://bugs.kde.org/show_bug.cgi?id=374458

--- Comment #4 from Francis Herne  ---
Still draggable (and crashy) here with yesterday's kdevplatform/kdevelop
5.1-git.

On Arch x86_64 with:

kdevplatform v5.0.80-70-gd270016ad
kdevelop v5.0.80-35-g2c1a1fd7f6
qt 5.8.0

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevplatform] [Bug 374458] Crash when dragging launches in Launch Configuration

[Aetf]

https://bugs.kde.org/show_bug.cgi?id=374458

--- Comment #3 from Aetf <7437...@gmail.com> ---
I just tested on the latest 5.1 branch. They are not draggable any more. IMO
that makes sense because launches are associated with one project and there's
no point to drag them around.

Francis, can you reproduce this now?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevplatform] [Bug 374458] Crash when dragging launches in Launch Configuration

[Kevin Funk]

https://bugs.kde.org/show_bug.cgi?id=374458

Kevin Funk  changed:

   What|Removed |Added

 CC||7437...@gmail.com

--- Comment #2 from Kevin Funk  ---
Likely caused by:

commit 2fc1720781e8744c9df4a44cd943322889a55300
Author: Peifeng Yu <7437...@gmail.com>
Date:   Mon Sep 5 13:15:11 2016 -0400

Use GDB as default debugger backend

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevplatform] [Bug 374458] Crash when dragging launches in Launch Configuration

[Kevin Funk]

https://bugs.kde.org/show_bug.cgi?id=374458

Kevin Funk  changed:

   What|Removed |Added

 Status|UNCONFIRMED |CONFIRMED
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevplatform] [Bug 374458] Crash when dragging launches in Launch Configuration

[Francis Herne]

https://bugs.kde.org/show_bug.cgi?id=374458

Francis Herne  changed:

   What|Removed |Added

   Keywords||regression

--- Comment #1 from Francis Herne  ---
This doesn't occur in 5.0.3 (the tree objects aren't draggable at all).

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdevplatform] [Bug 374458] Crash when dragging launches in Launch Configuration

[Sven Brauch]

https://bugs.kde.org/show_bug.cgi?id=374458

Sven Brauch  changed:

   What|Removed |Added

 CC||m...@svenbrauch.de
Version|unspecified |5.0.80

-- 
You are receiving this mail because:
You are watching all bug changes.