[frameworks-kio] [Bug 125102] Cancelling move/copy operation leaves target incomplete

[Méven Car]

https://bugs.kde.org/show_bug.cgi?id=125102

Méven Car  changed:

   What|Removed |Added

 CC||mcpatn...@gmail.com

--- Comment #11 from Méven Car  ---
*** Bug 148429 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 125102] Cancelling move/copy operation leaves target incomplete

[Ralf Habacker]

https://bugs.kde.org/show_bug.cgi?id=125102

--- Comment #10 from Ralf Habacker  ---
Git commit 04580cac31b1f1a1491a1fc54cfc4c724ce50cd9 by Ralf Habacker.
Committed on 27/04/2019 at 01:26.
Pushed by habacker into branch 'Applications/19.04'.

file import: do not use overwritten temporary file

We checked if the temporary file we created still exists after its creation,
yet in the meantime we have already copied to it (which overwrites it):
KIO::FileCopyJob *job = KIO::file_copy(url, dest, -1, KIO::Overwrite);

Instead of the temporary file, check if the regular file we use later on
exists.

This bug is a result of fixing bug 125102.
Related: bug 406574
FIXED-IN:2.28.0 (KDE Applications 19.04.0)

Reviewed By: habacker
Differential Revision: https://phabricator.kde.org/D20775

M  +4-4umbrello/umldoc.cpp

https://commits.kde.org/umbrello/04580cac31b1f1a1491a1fc54cfc4c724ce50cd9

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 125102] Cancelling move/copy operation leaves target incomplete

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=125102

Nate Graham  changed:

   What|Removed |Added

   Version Fixed In|5.56|5.57

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 125102] Cancelling move/copy operation leaves target incomplete

[Chinmoy Ranjan Pradhan]

https://bugs.kde.org/show_bug.cgi?id=125102

Chinmoy Ranjan Pradhan  changed:

   What|Removed |Added

   Version Fixed In||5.56
  Latest Commit||https://commits.kde.org/kio
   ||/f34c2cf0abf12a96806f9eaac5
   ||153dd764ea2215
 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED

--- Comment #9 from Chinmoy Ranjan Pradhan  ---
Git commit f34c2cf0abf12a96806f9eaac5153dd764ea2215 by Chinmoy Ranjan Pradhan.
Committed on 03/03/2019 at 08:56.
Pushed by chinmoyr into branch 'master'.

Make file overwrite a bit safer

Summary:
Instead of truncating the existing file, a separate copy of the source file in
the
destination folder is created. If the copy was successfully created, the
existing
destination file is replaced with it. If in middle of creating the separate
copy the
disk runs out of space then an attempt is made to delete the existing
destination.
After that is done the copy operation is resumed.
FIXED-IN: 5.56

Test Plan: Unit testing and manual testing done.

Reviewers: dfaure, ngraham

Reviewed By: dfaure, ngraham

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D19080

M  +47   -0autotests/jobtest.cpp
M  +2-0autotests/jobtest.h
M  +42   -16   src/ioslaves/file/file_unix.cpp

https://commits.kde.org/kio/f34c2cf0abf12a96806f9eaac5153dd764ea2215

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 125102] Cancelling move/copy operation leaves target incomplete

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=125102

Nate Graham  changed:

   What|Removed |Added

 CC||safa1996alful...@gmail.com

--- Comment #8 from Nate Graham  ---
*** Bug 398337 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 125102] Cancelling move/copy operation leaves target incomplete

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=125102

Nate Graham  changed:

   What|Removed |Added

 CC||bryanfr...@hotmail.com

--- Comment #7 from Nate Graham  ---
*** Bug 290065 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 125102] Cancelling move/copy operation leaves target incomplete

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=125102

Nate Graham  changed:

   What|Removed |Added

  Component|general |general
Product|kio |frameworks-kio
 Status|UNCONFIRMED |CONFIRMED
 CC||kdelibs-b...@kde.org,
   ||n...@kde.org
   Keywords||usability
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are watching all bug changes.

[kio] [Bug 125102] Cancelling move/copy operation leaves target incomplete

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=125102

Nate Graham  changed:

   What|Removed |Added

 CC||bugsefor...@gmx.com

--- Comment #6 from Nate Graham  ---
*** Bug 383764 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[kio] [Bug 125102] Cancelling move/copy operation leaves target incomplete

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=125102

--- Comment #5 from tesfab...@gmail.com ---
(In reply to tesfabpel from comment #4)
> This bug is still present on Dolphin 5.24.0 with frameworks 5.7.0 running on
> Archlinux 64bit...
> 
> Any news on this? It's very dangerous!
> Thanks :)

Sorry... Dolphin 16.04.3 with frameworks 5.24.0 and Qt 5.7.0...

-- 
You are receiving this mail because:
You are watching all bug changes.

[kio] [Bug 125102] Cancelling move/copy operation leaves target incomplete

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=125102

--- Comment #4 from tesfab...@gmail.com ---
This bug is still present on Dolphin 5.24.0 with frameworks 5.7.0 running on
Archlinux 64bit...

Any news on this? It's very dangerous!
Thanks :)

-- 
You are receiving this mail because:
You are watching all bug changes.