[kmail2] [Bug 379997] Always "Akonadi not started" overlay on reboot

[David Faure]

https://bugs.kde.org/show_bug.cgi?id=379997

David Faure  changed:

   What|Removed |Added

  Latest Commit|https://commits.kde.org/ako |https://commits.kde.org/ako
   |nadi/f8d59a48e68fc89949bd16 |nadi/10db44a34c4fa0d0907bdc
   |cf97097f207f609324  |1abfec674fed920dcf

--- Comment #3 from David Faure  ---
Git commit 10db44a34c4fa0d0907bdc1abfec674fed920dcf by David Faure.
Committed on 09/12/2017 at 20:58.
Pushed by dfaure into branch 'Applications/17.12'.

ErrorOverlay: don't show by mistake if called with Running twice.

Summary:
If serverStateChanged(Running) is called twice, the first time
this would hide the overlay and set mOverlayActive=false,
so the second time this goes into the else branch, which
shows the overlay...

The reason it's called twice isn't because ServerManager
emits stateChanged(Running) twice, obviously (it only emits on actual
change). The reason is that the ErrorOverlay constructor calls
serverStateChanged(state) and connects to ::stateChanged.
It can happen that for this initial state, ServerManager::state() finds
out "Running" before ServerManager gets a chance to notice by itself
and emit stateChanged().

Test Plan:
Found with debug output, during session startup,
over many weeks (it's clearly a race condition).

Reviewers: dvratil, vkrause

Reviewed By: dvratil

Subscribers: #kde_pim

Tags: #kde_pim

Differential Revision: https://phabricator.kde.org/D9264

(cherry picked from commit f8d59a48e68fc89949bd16cf97097f207f609324)

M  +7-5src/widgets/erroroverlay.cpp

https://commits.kde.org/akonadi/10db44a34c4fa0d0907bdc1abfec674fed920dcf

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmail2] [Bug 379997] Always "Akonadi not started" overlay on reboot

[David Faure]

https://bugs.kde.org/show_bug.cgi?id=379997

David Faure  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
  Latest Commit||https://commits.kde.org/ako
   ||nadi/f8d59a48e68fc89949bd16
   ||cf97097f207f609324
 Resolution|--- |FIXED

--- Comment #2 from David Faure  ---
Git commit f8d59a48e68fc89949bd16cf97097f207f609324 by David Faure.
Committed on 09/12/2017 at 20:58.
Pushed by dfaure into branch 'master'.

ErrorOverlay: don't show by mistake if called with Running twice.

Summary:
If serverStateChanged(Running) is called twice, the first time
this would hide the overlay and set mOverlayActive=false,
so the second time this goes into the else branch, which
shows the overlay...

The reason it's called twice isn't because ServerManager
emits stateChanged(Running) twice, obviously (it only emits on actual
change). The reason is that the ErrorOverlay constructor calls
serverStateChanged(state) and connects to ::stateChanged.
It can happen that for this initial state, ServerManager::state() finds
out "Running" before ServerManager gets a chance to notice by itself
and emit stateChanged().

Test Plan:
Found with debug output, during session startup,
over many weeks (it's clearly a race condition).

Reviewers: dvratil, vkrause

Reviewed By: dvratil

Subscribers: #kde_pim

Tags: #kde_pim

Differential Revision: https://phabricator.kde.org/D9264

M  +7-5src/widgets/erroroverlay.cpp

https://commits.kde.org/akonadi/f8d59a48e68fc89949bd16cf97097f207f609324

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmail2] [Bug 379997] Always "Akonadi not started" overlay on reboot

[David Faure]

https://bugs.kde.org/show_bug.cgi?id=379997

--- Comment #1 from David Faure  ---
Pending fix: https://phabricator.kde.org/D9264

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmail2] [Bug 379997] Always "Akonadi not started" overlay on reboot

[David Faure]

https://bugs.kde.org/show_bug.cgi?id=379997

David Faure  changed:

   What|Removed |Added

 CC||fa...@kde.org
 Status|UNCONFIRMED |CONFIRMED
 Ever confirmed|0   |1
   Assignee|kdepim-b...@kde.org |fa...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmail2] [Bug 379997] Always "Akonadi not started" overlay on reboot

[ml]

https://bugs.kde.org/show_bug.cgi?id=379997

ml  changed:

   What|Removed |Added

 CC||iivan...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.