[kmymoney4] [Bug 361021] CSV importer: The transaction has missing assignment of...

[Ralf Habacker]

https://bugs.kde.org/show_bug.cgi?id=361021

Ralf Habacker  changed:

   What|Removed |Added

   Version Fixed In|5.0.0   |4.8.0

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmymoney4] [Bug 361021] CSV importer: The transaction has missing assignment of...

[Ralf Habacker]

https://bugs.kde.org/show_bug.cgi?id=361021

Ralf Habacker  changed:

   What|Removed |Added

 CC||ralf.habac...@freenet.de
   Version Fixed In||5.0.0

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmymoney4] [Bug 361021] CSV importer: The transaction has missing assignment of...

[allan via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361021

--- Comment #14 from allan  ---
Just to note that I discovered a possible problem with this, and documented it,
in error, in https://bugs.kde.org/show_bug.cgi?id=362139, comment #7.  See
there for follow up.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmymoney4] [Bug 361021] CSV importer: The transaction has missing assignment of...

[NSLW via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361021

NSLW  changed:

   What|Removed |Added

  Latest Commit|http://commits.kde.org/kmym |http://commits.kde.org/kmym
   |oney/7d7e398cf180b21f3ab9e9 |oney/9b054dac7c81131a31c4af
   |0c5184290aced161a0  |e57b589750208ddd6f

--- Comment #13 from NSLW  ---
Git commit 9b054dac7c81131a31c4afe57b589750208ddd6f by Łukasz Wojniłowicz.
Committed on 08/05/2016 at 07:14.
Pushed by wojnilowicz into branch 'frameworks'.

Add fee for buy and sell operation in the right way

Fee should be added to buy and substracted from sell
operations. Difference between balance for banking and investment
account should include fees.
REVIEW: 127711

M  +18   -18   kmymoney/converter/mymoneystatementreader.cpp
M  +6-4kmymoney/plugins/csvimport/investprocessing.cpp

http://commits.kde.org/kmymoney/9b054dac7c81131a31c4afe57b589750208ddd6f

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmymoney4] [Bug 361021] CSV importer: The transaction has missing assignment of...

[NSLW via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361021

NSLW  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED
  Latest Commit||http://commits.kde.org/kmym
   ||oney/7d7e398cf180b21f3ab9e9
   ||0c5184290aced161a0

--- Comment #12 from NSLW  ---
Git commit 7d7e398cf180b21f3ab9e90c5184290aced161a0 by Łukasz Wojniłowicz.
Committed on 08/05/2016 at 07:02.
Pushed by wojnilowicz into branch 'master'.

Add fee for buy and sell operation in the right way

Fee should be added to buy and substracted from sell
operations. Difference between balance for banking and investment
account should include fees.
REVIEW: 127711

M  +18   -18   kmymoney/converter/mymoneystatementreader.cpp
M  +6-4kmymoney/plugins/csvimport/investprocessing.cpp

http://commits.kde.org/kmymoney/7d7e398cf180b21f3ab9e90c5184290aced161a0

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmymoney4] [Bug 361021] CSV importer: The transaction has missing assignment of...

[NSLW via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361021

--- Comment #11 from NSLW  ---
(In reply to allan from comment #10)
> (In reply to NSLW from comment #9)
> > (In reply to allan from comment #8)
> > > (In reply to NSLW from comment #0)
> > > > Buy transactions imported by CSV importer always have missing assignment
> > > 
> > > It's not correct to say that they '...always have missing assignment'  it 
> > > is
> > > only under certain conditions.
> > 
> > For me it always has missing assignment during import from CSV and empty
> > ledger. Do you know conditions under which it doesn't happen?
> 
> Yes.  Often, the problem is that a Buy/Sell/ReinvDiv, which involve funds
> transfers, does not have the name of the relevant checking/brokerage account
> provided.  During CSV import of these types, an extra dialog opens that asks
> for the name of the checking/brokerage account that is to be used.  If this
> is correctly entered, then the transaction is not unbalanced. In general, I
> do not have a problem, over many years,  with missing assignments.

I enter the name of checking/brokerage account always correctly and only once
for every CSV file. I always have wrong amounts, even for transactions that
show as balanced.
Can you provide investment statement, you don't have problems with?

> > (In reply to allan from comment #7)
> > > There is also another issue, with fees sometimes getting the wrong sign,
> > > which I identified in https://bugs.kde.org/show_bug.cgi?id=360129.  I 
> > > think
> > > the patch in this current bug may be related.
> > 
> > According to my research bug #360129 can be independently fixed from this
> > bug and this bug can be independently fixed from bug #360129.
> > Moreover through simple sign changes in my patch I can cause both operations
> > to display warning about assignment and not only for sell operations.
> > How do you see them correlated?
> 
> I don't see the two bugs as related, except that
> https://bugs.kde.org/show_bug.cgi?id=361029 highlighted the fee sign issue. 
> I'm assuming/hoping that your patch here is for that same problem.  I
> haven't yet had a chance to look into it.

Yes, that's the same issue but the other report supposed to concern other bug,
so patch for this bug doesn't fix the other bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmymoney4] [Bug 361021] CSV importer: The transaction has missing assignment of...

[NSLW via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361021

--- Comment #9 from NSLW  ---
(In reply to allan from comment #8)
> (In reply to NSLW from comment #0)
> > Buy transactions imported by CSV importer always have missing assignment
> 
> It's not correct to say that they '...always have missing assignment'  it is
> only under certain conditions.

For me it always has missing assignment during import from CSV and empty
ledger. Do you know conditions under which it doesn't happen?

(In reply to allan from comment #7)
> There is also another issue, with fees sometimes getting the wrong sign,
> which I identified in https://bugs.kde.org/show_bug.cgi?id=360129.  I think
> the patch in this current bug may be related.

According to my research bug #360129 can be independently fixed from this bug
and this bug can be independently fixed from bug #360129.
Moreover through simple sign changes in my patch I can cause both operations to
display warning about assignment and not only for sell operations.
How do you see them correlated?

Nevertheless, Allan please analyze this and another bug with patches for them.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmymoney4] [Bug 361021] CSV importer: The transaction has missing assignment of...

[allan via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361021

--- Comment #8 from allan  ---
(In reply to NSLW from comment #0)
> Buy transactions imported by CSV importer always have missing assignment

It's not correct to say that they '...always have missing assignment'  it is
only under certain conditions.

> (see attachment).
> 
> Reproducible: Always
> 
> Steps to Reproduce:
> 1. file->import csv
> 2. choose investment
> 3. create new profile
> 4. open "test file.csv" and assign columns to values (see attachment)
> 5. FieldDelimiter to comma
> 6. TextDelimiter to double quotes
> 7. DecimalSymbol to comma
> 8. ImportCSV
> 
> Actual Results:  
> In ledger:
> All buy operations have missing assignment
> On home page:
> Balance for banking and investment account are equal.
> 
> Expected Results:  
> In ledger:
> All operations should have assignment
> On home page:
> Balance for banking and investment account should be equal only in special
> cases. Correct difference in balance is shown in attachment.
> 
> To get good balance without the need of patching one has to double click
> every operation in ledger and press enter button. Upon completion column
> value will have exact same values as column from patched KMM.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmymoney4] [Bug 361021] CSV importer: The transaction has missing assignment of...

[allan via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361021

--- Comment #7 from allan  ---
(In reply to Jack from comment #5)
> Without looking at the details, I believe this is not a problem with the CSV
> importer, but with any KMM import of an investment transaction which
> requires a brokerage account for transfer of funds.

That's not exactly true.  I've just done a QIF import of a Buy transaction, as
a test, and that correctly identified the checking account to be used.

There is also another issue, with fees sometimes getting the wrong sign, which
I identified in https://bugs.kde.org/show_bug.cgi?id=360129.  I think the patch
in this current bug may be related.

>  (I have it with OFX
> import.) The issue is that when KMM imports an investment transaction, it
> does not specify the brokerage account, so the missing assignment refers to
> the amount which would go to that account.  When you edit the transaction,
> KMM automatically enters the brokerage account, so the error disappears.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmymoney4] [Bug 361021] CSV importer: The transaction has missing assignment of...

[NSLW via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361021

--- Comment #6 from NSLW  ---
(In reply to Jack from comment #5)
> Without looking at the details, I believe this is not a problem with the CSV
> importer, but with any KMM import of an investment transaction which
> requires a brokerage account for transfer of funds.  (I have it with OFX
> import.) The issue is that when KMM imports an investment transaction, it
> does not specify the brokerage account, so the missing assignment refers to
> the amount which would go to that account.  When you edit the transaction,
> KMM automatically enters the brokerage account, so the error disappears.

It makes no sense for me that sell operations are properly assigned and buy
operation not. Which error do you refer to Jack?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmymoney4] [Bug 361021] CSV importer: The transaction has missing assignment of...

[Jack via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361021

--- Comment #5 from Jack  ---
Without looking at the details, I believe this is not a problem with the CSV
importer, but with any KMM import of an investment transaction which requires a
brokerage account for transfer of funds.  (I have it with OFX import.) The
issue is that when KMM imports an investment transaction, it does not specify
the brokerage account, so the missing assignment refers to the amount which
would go to that account.  When you edit the transaction, KMM automatically
enters the brokerage account, so the error disappears.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmymoney4] [Bug 361021] CSV importer: The transaction has missing assignment of...

[NSLW via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361021

--- Comment #4 from NSLW  ---
Created attachment 98106
  --> https://bugs.kde.org/attachment.cgi?id=98106=edit
[PATCH] Add fee for buy and sell operation in the right way

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmymoney4] [Bug 361021] CSV importer: The transaction has missing assignment of...

[NSLW via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361021

--- Comment #3 from NSLW  ---
Created attachment 98105
  --> https://bugs.kde.org/attachment.cgi?id=98105=edit
Problem description

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmymoney4] [Bug 361021] CSV importer: The transaction has missing assignment of...

[NSLW via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361021

--- Comment #2 from NSLW  ---
Created attachment 98104
  --> https://bugs.kde.org/attachment.cgi?id=98104=edit
Column Assignment for CSV file

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmymoney4] [Bug 361021] CSV importer: The transaction has missing assignment of...

[NSLW via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361021

--- Comment #1 from NSLW  ---
Created attachment 98103
  --> https://bugs.kde.org/attachment.cgi?id=98103=edit
CSV Test File

-- 
You are receiving this mail because:
You are watching all bug changes.