[kmymoney4] [Bug 365133] Consistency check failure: currency of a category has no price set for 1900-01-01

2017-01-21 Thread Thomas Baumgart 
https://bugs.kde.org/show_bug.cgi?id=365133

Thomas Baumgart  changed:

   What|Removed |Added

   Version Fixed In||4.8.1

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmymoney4] [Bug 365133] Consistency check failure: currency of a category has no price set for 1900-01-01

2017-01-20 Thread Albert Astals Cid 
https://bugs.kde.org/show_bug.cgi?id=365133

Albert Astals Cid  changed:

   What|Removed |Added

  Latest Commit|https://commits.kde.org/kmy |https://commits.kde.org/kmy
   |money/5ee94f58c7b43e5640bac |money/365c0f4fa75a291ff7447
   |ce754c1e7a6720c7c5f |123cd0ca7b10c41f2bd

--- Comment #4 from Albert Astals Cid  ---
Git commit 365c0f4fa75a291ff7447123cd0ca7b10c41f2bd by Albert Astals Cid, on
behalf of Mark Jones.
Committed on 21/01/2017 at 00:19.
Pushed by aacid into branch 'master'.

Exclude IncomeExpense categories from opening date price consistency check
REVIEW: 129702

M  +4-1kmymoney/mymoney/mymoneyfile.cpp

https://commits.kde.org/kmymoney/365c0f4fa75a291ff7447123cd0ca7b10c41f2bd

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmymoney4] [Bug 365133] Consistency check failure: currency of a category has no price set for 1900-01-01

2017-01-20 Thread Albert Astals Cid 
https://bugs.kde.org/show_bug.cgi?id=365133

Albert Astals Cid  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|UNCONFIRMED |RESOLVED
  Latest Commit||https://commits.kde.org/kmy
   ||money/5ee94f58c7b43e5640bac
   ||ce754c1e7a6720c7c5f

--- Comment #3 from Albert Astals Cid  ---
Git commit 5ee94f58c7b43e5640bacce754c1e7a6720c7c5f by Albert Astals Cid, on
behalf of Mark Jones.
Committed on 21/01/2017 at 00:16.
Pushed by aacid into branch '4.8'.

Exclude IncomeExpense categories from opening date price consistency check
REVIEW: 129702

M  +4-1kmymoney/mymoney/mymoneyfile.cpp

https://commits.kde.org/kmymoney/5ee94f58c7b43e5640bacce754c1e7a6720c7c5f

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmymoney4] [Bug 365133] Consistency check failure: currency of a category has no price set for 1900-01-01

2016-12-24 Thread Thomas Baumgart 
https://bugs.kde.org/show_bug.cgi?id=365133

--- Comment #2 from Thomas Baumgart  ---
I currently don't see a problem with the proposed fix and don't expect any
side-effects either. So please go ahead and submit your review request.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmymoney4] [Bug 365133] Consistency check failure: currency of a category has no price set for 1900-01-01

2016-12-23 Thread bugzilla_noreply 
https://bugs.kde.org/show_bug.cgi?id=365133

m...@azu.ca changed:

   What|Removed |Added

 CC||m...@azu.ca

--- Comment #1 from m...@azu.ca ---
I have a fix for this bug but I am concerned about potential side-effects. My
fix is to exclude accounts of type IncomeExpense from the consistency check for
missing prices on the opening date (mymoneyfile.cpp:2337). 

Is there any reason that a IncomeExpense category in a foreign (non-base)
currency would require a price on the 'fake' account opening date of
1900-01-01? If not, I'll submit a review request.

-- 
You are receiving this mail because:
You are watching all bug changes.