[kmymoney4] [Bug 372547] Unable to load some investments on KF5

[Ralf Habacker]

https://bugs.kde.org/show_bug.cgi?id=372547

Ralf Habacker  changed:

   What|Removed |Added

   Version Fixed In||5.0
 CC||ralf.habac...@freenet.de

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmymoney4] [Bug 372547] Unable to load some investments on KF5

[NSLW]

https://bugs.kde.org/show_bug.cgi?id=372547

NSLW  changed:

   What|Removed |Added

  Latest Commit||https://commits.kde.org/kmy
   ||money/90e906fdadb22ec572c1e
   ||3f9324297943e5a930f
 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

--- Comment #5 from NSLW  ---
Git commit 90e906fdadb22ec572c1e3f9324297943e5a930f by Łukasz Wojniłowicz.
Committed on 17/02/2017 at 20:15.
Pushed by wojnilowicz into branch 'master'.

Allow importing single security investment statements

Summary:
Reuse security dialog to get imported security information.

Signed-off-by: Łukasz Wojniłowicz 

Reviewers: #kmymoney

Differential Revision: https://phabricator.kde.org/D4446

Signed-off-by: Łukasz Wojniłowicz 

M  +57   -5kmymoney/plugins/csvimport/investmentwizardpage.cpp
M  +6-0kmymoney/plugins/csvimport/investmentwizardpage.h

https://commits.kde.org/kmymoney/90e906fdadb22ec572c1e3f9324297943e5a930f

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmymoney4] [Bug 372547] Unable to load some investments on KF5

[allan]

https://bugs.kde.org/show_bug.cgi?id=372547

--- Comment #4 from allan  ---
(In reply to NSLW from comment #3)
> Hi Allan,
> As stated earlier, filter lineedits weren't essential to import so they were
> removed. If you used them to manually enter name and symbol of securities,
> then their name should be appropriate.

If your investment import files contain the security information in columns,
then yes, the line edit for the security name is not needed, as you say. 
However, that's not my situation.  In my case, the security name is on one of
the several header rows, so it has to be entered manually.  Therefore it is
essential to have the line edit restored.
> In current situation I suggest separate dialog for manually entering name
> and symbol of security which would pop up during transition to next wizard
> page in case name and symbol combobox would be empty. I don't need it right
> now and there is still workaround.
> Cheers
> Łukasz

I've reorganised the UI to accommodate this.  I tried having an additional row,
but that made the appearance too dissimilar to the other wizard pages, so what
I've done is move the comboboxes about to make room, while trying to keep
associated fields close together.  I don't really like the idea of a
supplementary window to catch 'forgotten bits.'

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmymoney4] [Bug 372547] Unable to load some investments on KF5

[NSLW]

https://bugs.kde.org/show_bug.cgi?id=372547

NSLW  changed:

   What|Removed |Added

 CC||lukasz.wojnilow...@gmail.co
   ||m

--- Comment #3 from NSLW  ---
Hi Allan,
As stated earlier, filter lineedits weren't essential to import so they were
removed. If you used them to manually enter name and symbol of securities, then
their name should be appropriate.
In current situation I suggest separate dialog for manually entering name and
symbol of security which would pop up during transition to next wizard page in
case name and symbol combobox would be empty. I don't need it right now and
there is still workaround.
Cheers
Łukasz

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmymoney4] [Bug 372547] Unable to load some investments on KF5

[allan]

https://bugs.kde.org/show_bug.cgi?id=372547

--- Comment #2 from allan  ---
@ lukasz.wojnilow...@gmail.com

Hi Łukasz/Anyone, Do you have any interest in resolving this issue?
I've had a first go at restoring the widgets that were removed and have had to
reorganise some of the others, trying to keep together those logically related.

If you are still interested, I can add attachments here.  I've not had
time/opportunity to look into revising the coding.
Allan

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmymoney4] [Bug 372547] Unable to load some investments on KF5

[allan]

https://bugs.kde.org/show_bug.cgi?id=372547

--- Comment #1 from allan  ---
See Review Request 129003: Separate investment page item 6). 23 September.

6) removed name and security filter lineedits, because they aren't
essential/usefull to import,

These fields are essential should the input file (eg. Fidelity UK) not have
columns for these fields.

I have only recently been able to try rev 4.100.

-- 
You are receiving this mail because:
You are watching all bug changes.