[kmymoney4] [Bug 373550] Display the sum of sub-categories when category is expanded

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=373550

Albert Astals Cid  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED
  Latest Commit||https://commits.kde.org/kmy
   ||money/31f8fff27a58badfad3cc
   ||1a6e804df5c59e09421

--- Comment #9 from Albert Astals Cid  ---
Git commit 31f8fff27a58badfad3cc1a6e804df5c59e09421 by Albert Astals Cid, on
behalf of Marc Hübner.
Committed on 21/01/2017 at 00:07.
Pushed by aacid into branch 'master'.

Display the sum of sub-categories when category is expanded

Adds a new column to the categories view. The (previously existing) "total"
column does now always hold the summed value (no matter whether a subtotal
position is expanded or collapsed). The new "posted amount" column only holds
the value that was assigned to the category directly (that is, without
subcategories).
REVIEW: 129852

M  +12   -2kmymoney/models/accountsmodel.cpp
M  +1-0kmymoney/models/accountsmodel.h

https://commits.kde.org/kmymoney/31f8fff27a58badfad3cc1a6e804df5c59e09421

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmymoney4] [Bug 373550] Display the sum of sub-categories when category is expanded

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=373550

--- Comment #8 from mahue...@gmail.com ---
just did. Review request no. is #129852.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmymoney4] [Bug 373550] Display the sum of sub-categories when category is expanded

[Thomas Baumgart]

https://bugs.kde.org/show_bug.cgi?id=373550

Thomas Baumgart  changed:

   What|Removed |Added

   Severity|normal  |wishlist

--- Comment #7 from Thomas Baumgart  ---
Please feel free to provide a patch on https://git.reviewboard.kde.org/ against
the KMyMoney master branch (KF5 version).  4.8 is frozen for new features.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmymoney4] [Bug 373550] Display the sum of sub-categories when category is expanded

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=373550

--- Comment #6 from mahue...@gmail.com ---
Created attachment 103336
  --> https://bugs.kde.org/attachment.cgi?id=103336=edit
expanded view

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmymoney4] [Bug 373550] Display the sum of sub-categories when category is expanded

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=373550

--- Comment #5 from mahue...@gmail.com ---
Created attachment 103335
  --> https://bugs.kde.org/attachment.cgi?id=103335=edit
collapsed view

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmymoney4] [Bug 373550] Display the sum of sub-categories when category is expanded

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=373550

mahue...@gmail.com changed:

   What|Removed |Added

 CC||mahue...@gmail.com

--- Comment #3 from mahue...@gmail.com ---
One way to tackle this could be to display  posted amounts ("directly assigned
splits") and calculated totals in different columns (please see attached
screenshots). That way, the toggling for the totals is not required anymore, as
both figures are visible at once. Would change existing look & feel though...

I can submit a patch/review request for that kind of behavior, if
wanted/required.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmymoney4] [Bug 373550] Display the sum of sub-categories when category is expanded

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=373550

--- Comment #4 from mahue...@gmail.com ---
Created attachment 103334
  --> https://bugs.kde.org/attachment.cgi?id=103334=edit
postings made for illustration

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmymoney4] [Bug 373550] Display the sum of sub-categories when category is expanded

[Jack]

https://bugs.kde.org/show_bug.cgi?id=373550

Jack  changed:

   What|Removed |Added

 CC|ostroffjh@users.sourceforge |
   |.net|

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmymoney4] [Bug 373550] Display the sum of sub-categories when category is expanded

[Jack]

https://bugs.kde.org/show_bug.cgi?id=373550

Jack  changed:

   What|Removed |Added

 CC||ostroffjh@users.sourceforge
   ||.net

--- Comment #2 from Jack  ---
I have not actually looked at the report recently - but could the cumulative
total be displayed differently - for example [Including all subcategories:
$234.54] where I mean for that text and brackets to be displayed.  That way you
can see both per category and rolled up at the same time, but be sure which is
which.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kmymoney4] [Bug 373550] Display the sum of sub-categories when category is expanded

[Thomas Baumgart]

https://bugs.kde.org/show_bug.cgi?id=373550

--- Comment #1 from Thomas Baumgart  ---
This will have side effects, as you can assign splits to that category.

When expanded, the amount of each account itself is displayed, when collapsed,
the sum of all accounts is displayed.

Your request will brake this functionality.

-- 
You are receiving this mail because:
You are watching all bug changes.