[kompare] [Bug 249976] kompare complains about malformed diffs
https://bugs.kde.org/show_bug.cgi?id=249976 mikz...@gmail.com changed: What|Removed |Added CC||mikz...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[kompare] [Bug 249976] kompare complains about malformed diffs
https://bugs.kde.org/show_bug.cgi?id=249976 Mathias Homann changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |INTENTIONAL --- Comment #29 from Mathias Homann --- actually that last comment's invalid - the reason for the error *was* because of some binary files... -- You are receiving this mail because: You are watching all bug changes.
[kompare] [Bug 249976] kompare complains about malformed diffs
https://bugs.kde.org/show_bug.cgi?id=249976 --- Comment #28 from Mathias Homann --- by the way, my script to run diff with LANG="" doesn't help anymore for some reason. -- You are receiving this mail because: You are watching all bug changes.
[kompare] [Bug 249976] kompare complains about malformed diffs
https://bugs.kde.org/show_bug.cgi?id=249976 Mathias Homann changed: What|Removed |Added Resolution|INTENTIONAL |--- Status|RESOLVED|REOPENED --- Comment #27 from Mathias Homann --- (In reply to Kevin Kofler from comment #26) > But Kompare can also be used to view diffs that are already in a .diff file. > I cannot control how diff was run in that case. ...in which case we can tell the user about it. But that's no reason not to "do it right" when you *can* control how diff is run. -- You are receiving this mail because: You are watching all bug changes.
[kompare] [Bug 249976] kompare complains about malformed diffs
https://bugs.kde.org/show_bug.cgi?id=249976 Kevin Kofler changed: What|Removed |Added CC||kevin.kof...@chello.at --- Comment #26 from Kevin Kofler --- But Kompare can also be used to view diffs that are already in a .diff file. I cannot control how diff was run in that case. -- You are receiving this mail because: You are watching all bug changes.
[kompare] [Bug 249976] kompare complains about malformed diffs
https://bugs.kde.org/show_bug.cgi?id=249976 Kevin Kofler changed: What|Removed |Added CC|kevin.kof...@chello.at | -- You are receiving this mail because: You are watching all bug changes.
[kompare] [Bug 249976] kompare complains about malformed diffs
https://bugs.kde.org/show_bug.cgi?id=249976 --- Comment #25 from Mathias Homann --- guess i didn't make myself clear enough: if kompare has problems with non-english output from diff, then kompare should run diff in a way that ensures english output. -- You are receiving this mail because: You are watching all bug changes.
[kompare] [Bug 249976] kompare complains about malformed diffs
https://bugs.kde.org/show_bug.cgi?id=249976 --- Comment #24 from Kevin Kofler --- That would not help with diffs coming from elsewhere (possibly downloaded from the Internet) that you open in Kompare. -- You are receiving this mail because: You are watching all bug changes.
[kompare] [Bug 249976] kompare complains about malformed diffs
https://bugs.kde.org/show_bug.cgi?id=249976 --- Comment #23 from Mathias Homann --- (In reply to Kevin Kofler from comment #22) > parse the translated messages... NOW we are finally getting somewhere. I created a script that unsets LANG and then just calls diff with all argumets passed to it, and told kompare to use that script instead of the regular diff command, and voila, no more "malformed diff" errors anymore. Don't even have to exclude image files by pattern anymore. maybe that script should be part of kompare... #!/bin/bash unset LANG /usr/bin/diff $@ sits in ~/bin on my home folder, and due to my $PATH gets preference before /usr/bin/diff... -- You are receiving this mail because: You are watching all bug changes.
[kompare] [Bug 249976] kompare complains about malformed diffs
https://bugs.kde.org/show_bug.cgi?id=249976 --- Comment #22 from Kevin Kofler --- And strictly speaking, the warning is actually correct, because the differing binary files cannot be displayed in the diff viewer. (We cannot even show which files differ because we cannot parse the translated messages.) -- You are receiving this mail because: You are watching all bug changes.
[kompare] [Bug 249976] kompare complains about malformed diffs
https://bugs.kde.org/show_bug.cgi?id=249976 Kevin Kofler changed: What|Removed |Added Resolution|--- |INTENTIONAL Status|REOPENED|RESOLVED --- Comment #21 from Kevin Kofler --- It complains about diff reporting that binary files differ, in a translated message that is not reasonably machine-parsable. I have no way to distinguish this from actually invalid diffs where some parts cannot be displayed. Hence, warning the user about the unparsable lines is by design. -- You are receiving this mail because: You are watching all bug changes.
[kompare] [Bug 249976] kompare complains about malformed diffs
https://bugs.kde.org/show_bug.cgi?id=249976 --- Comment #20 from Kevin Kofler --- *** Bug 339002 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[kompare] [Bug 249976] kompare complains about malformed diffs
https://bugs.kde.org/show_bug.cgi?id=249976 --- Comment #19 from Mathias Homann --- Created attachment 129754 --> https://bugs.kde.org/attachment.cgi?id=129754=edit a diff generated by dif -burNE that kompare chokes on -- You are receiving this mail because: You are watching all bug changes.
[kompare] [Bug 249976] kompare complains about malformed diffs
https://bugs.kde.org/show_bug.cgi?id=249976 Mathias Homann changed: What|Removed |Added Version|4.0.0 |4.1.3 -- You are receiving this mail because: You are watching all bug changes.
[kompare] [Bug 249976] kompare complains about malformed diffs
https://bugs.kde.org/show_bug.cgi?id=249976 --- Comment #18 from Mathias Homann --- kompare 4.1.3, bug is still there. -- You are receiving this mail because: You are watching all bug changes.
