[konsole] [Bug 345403] "Terminal Size" setting in profile ignored

[Andrey]

https://bugs.kde.org/show_bug.cgi?id=345403

Andrey  changed:

   What|Removed |Added

   See Also||https://bugs.kde.org/show_b
   ||ug.cgi?id=439339

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 345403] "Terminal Size" setting in profile ignored

[Andrey]

https://bugs.kde.org/show_bug.cgi?id=345403

Andrey  changed:

   What|Removed |Added

 CC||butir...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 345403] "Terminal Size" setting in profile ignored

[Simon Andric via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=345403

Simon Andric  changed:

   What|Removed |Added

 CC||simonandr...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 345403] "Terminal Size" setting in profile ignored

[Radics Péter via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=345403

--- Comment #38 from Radics Péter  ---
(In reply to Albert Astals Cid from comment #37)
> Radics, i suggest opening a new bug with a clearer description for that
> "ignores menubar" part

Done, see bug 359662.

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 345403] "Terminal Size" setting in profile ignored

[Albert Astals Cid via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=345403

Albert Astals Cid  changed:

   What|Removed |Added

 CC||aa...@kde.org

--- Comment #37 from Albert Astals Cid  ---
Radics, i suggest opening a new bug with a clearer description for that
"ignores menubar" part

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 345403] "Terminal Size" setting in profile ignored

[Radics Péter via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=345403

--- Comment #36 from Radics Péter  ---
(In reply to subdiff from comment #35)

Yes, I can use the workaround for now (in fact, I have been using another
workaround on my main computer until now ;), just wanted to let you know that
the fix is not "perfect" :)

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 345403] "Terminal Size" setting in profile ignored

[subdiff via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=345403

--- Comment #35 from subdiff  ---
Thanks for feedback. Did I understand correctly that this is only a non
critical problem because there is the workaround of just applying some
different size (in your case 80x23 instead of 80x25)?

In this case I would ignore that for the moment, because there seems to be some
bigger transition going on in the Konsole Source (moving away from
KUniqueApplication), which also could affect our fix for this bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 345403] "Terminal Size" setting in profile ignored

[Radics Péter via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=345403

--- Comment #34 from Radics Péter  ---
The setting works again, but it doesn't take into account if the menu bar is
disabled or not (apparently it always assumes that it is enabled and calculates
the size based on that).

I have the menu bar disabled, thus I have to set the size to 80x23 to get a
80x25 window.  If I turn the menubar on, I'll get a 80x23 window with menubar
(as set in the settings).

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 345403] "Terminal Size" setting in profile ignored

[Kurt Hindenburg via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=345403

--- Comment #33 from Kurt Hindenburg  ---
Git commit 1e211482566edb9194f34755b823bd98f15c6f25 by Kurt Hindenburg.
Committed on 06/02/2016 at 15:11.
Pushed by hindenburg into branch 'Applications/15.12'.

Allow profile's termainal size to work again

When Konsole Settings -> 'Use current window size on next startup' is
disabled, use the Profile's terminal size for new windows.

Many thanks to Roman Gilg (subdiff gmail com) for research and patch.

If there are no further issues, I'll commit to 15.12 branch (should go
.2 release).

REVIEW: 126924
(cherry picked from commit 55f02e5b8e3e2395050940c33c97306311192e18)

M  +24   -7src/Application.cpp
M  +2-1src/Application.h

http://commits.kde.org/konsole/1e211482566edb9194f34755b823bd98f15c6f25

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 345403] "Terminal Size" setting in profile ignored

[Kurt Hindenburg via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=345403

Kurt Hindenburg  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 345403] "Terminal Size" setting in profile ignored

[Torsten Römer via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=345403

--- Comment #31 from Torsten Römer  ---
Cheers Roman and Kurt!

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 345403] "Terminal Size" setting in profile ignored

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=345403

--- Comment #32 from jeremy9...@gmail.com ---
Maybe we should mark it as FIXED ?

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 345403] "Terminal Size" setting in profile ignored

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=345403

--- Comment #30 from jeremy9...@gmail.com ---
Thank you very very much Roman Gilg (subdiff) !

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 345403] "Terminal Size" setting in profile ignored

[Kurt Hindenburg via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=345403

--- Comment #29 from Kurt Hindenburg  ---
Git commit 55f02e5b8e3e2395050940c33c97306311192e18 by Kurt Hindenburg.
Committed on 30/01/2016 at 17:09.
Pushed by hindenburg into branch 'master'.

Allow profile's termainal size to work again

When Konsole Settings -> 'Use current window size on next startup' is
disabled, use the Profile's terminal size for new windows.

Many thanks to Roman Gilg (subdiff gmail com) for research and patch.

If there are no further issues, I'll commit to 15.12 branch (should go
.2 release).

REVIEW: 126924

M  +24   -7src/Application.cpp
M  +2-1src/Application.h

http://commits.kde.org/konsole/55f02e5b8e3e2395050940c33c97306311192e18

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 345403] "Terminal Size" setting in profile ignored

[Terry Barnaby via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=345403

--- Comment #28 from Terry Barnaby  ---
Thanks for the patch. I have created an updated kconsole5 rpm with this and am
trying it out now.
So far its appears to work fine :)

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 345403] "Terminal Size" setting in profile ignored

[subdiff via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=345403

subdiff  changed:

   What|Removed |Added

 CC||subd...@gmail.com

--- Comment #27 from subdiff  ---
Hi!

FYI I requested a review for a possible fix:
https://git.reviewboard.kde.org/r/126924/
The maintainer Kurt plans to look on the patch in the next few days. But I have
not much experience in coding KDE stuff. So don't expect the fix to be perfect.
It could also be the case, that it's not acceptable at all.

You can still try it out though if you wish to by downloading the diff and
compiling Konsole yourself with the patch (git apply mypatch). In any case, if
there is something you want to have changed about the patch, just tell me.

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 345403] "Terminal Size" setting in profile ignored

[Terry Barnaby via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=345403

Terry Barnaby  changed:

   What|Removed |Added

 CC||te...@beam.ltd.uk

--- Comment #26 from Terry Barnaby  ---
Another reminder that this is causing users pain.

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 345403] "Terminal Size" setting in profile ignored

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=345403

--- Comment #25 from jeremy9...@gmail.com ---
A reminder for this that need to be fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 345403] "Terminal Size" setting in profile ignored

[Glenn Holmer via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=345403

--- Comment #23 from Glenn Holmer  ---
It's not good to have non-working configuration options in such a high-profile
Plasma app. Won't someone please address this?

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 345403] "Terminal Size" setting in profile ignored

[Radics Péter via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=345403

--- Comment #24 from Radics Péter  ---
Could someone just review the change proposed by Daniel Scharrer? (Just check
if it doesn't cause any serious damage, and apply it as a quick-fix until
someone can look into the issue deeper).

This issue is really annoying...

 in Comment 17(In reply to Daniel Scharrer from comment #17)
> Created attachment 95952 [details]
> Workaround to force the terminal size from the profile
> 
> I'm not familiar enough with the code to provide a proper fix, but at least
> this patch makes konsole usable again for me. It breaks the "Use current
> window size on next startup" option though.

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 345403] "Terminal Size" setting in profile ignored

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=345403

--- Comment #21 from jeremy9...@gmail.com ---
Nobody seem to care about this little bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 345403] "Terminal Size" setting in profile ignored

[Philip Smith via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=345403

Philip Smith  changed:

   What|Removed |Added

 CC||p...@mssl.ucl.ac.uk

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 345403] "Terminal Size" setting in profile ignored

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=345403

--- Comment #20 from jeremy9...@gmail.com ---
15.12 release is almost here. Maybe for 15.12.1 ?

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 345403] "Terminal Size" setting in profile ignored

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=345403

--- Comment #18 from jeremy9...@gmail.com ---
It's a 10 months bug that seems to be an easy one to fix.
Can it be fixed please for the 15.12 release ?
Thank you !

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 345403] "Terminal Size" setting in profile ignored

[Daniel Scharrer via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=345403

--- Comment #17 from Daniel Scharrer  ---
Created attachment 95952
  --> https://bugs.kde.org/attachment.cgi?id=95952=edit
Workaround to force the terminal size from the profile

I'm not familiar enough with the code to provide a proper fix, but at least
this patch makes konsole usable again for me. It breaks the "Use current window
size on next startup" option though.

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 345403] "Terminal Size" setting in profile ignored

[Daniel Scharrer via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=345403

Daniel Scharrer  changed:

   What|Removed |Added

 CC||dan...@constexpr.org

-- 
You are receiving this mail because:
You are watching all bug changes.