[konsole] [Bug 407084] Changed behavior of profile shortcuts in Konsole
https://bugs.kde.org/show_bug.cgi?id=407084 Nate Graham changed: What|Removed |Added Version Fixed In||19.08 Resolution|INTENTIONAL |FIXED -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 407084] Changed behavior of profile shortcuts in Konsole
https://bugs.kde.org/show_bug.cgi?id=407084 --- Comment #16 from Kamil Dudka --- (In reply to Wolfgang Bauer from comment #15) > The change already has been reverted for 19.08: Perfect. Thanks for the good news! > https://cgit.kde.org/konsole.git/commit/?h=Applications/19.08=a1b64d7956485c6358bd2cccabde3843c1d314eb Thanks for the reference! I applied the patch locally and konsole now works as expected. -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 407084] Changed behavior of profile shortcuts in Konsole
https://bugs.kde.org/show_bug.cgi?id=407084 Wolfgang Bauer changed: What|Removed |Added CC||wba...@tmo.at --- Comment #15 from Wolfgang Bauer --- (In reply to Kamil Dudka from comment #14) > Could you please restore the original behavior that I used to use for a > decade or so? The change already has been reverted for 19.08: https://bugs.kde.org/show_bug.cgi?id=407076#c3 https://bugs.kde.org/show_bug.cgi?id=408217#c5 https://cgit.kde.org/konsole.git/commit/?h=Applications/19.08=a1b64d7956485c6358bd2cccabde3843c1d314eb -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 407084] Changed behavior of profile shortcuts in Konsole
https://bugs.kde.org/show_bug.cgi?id=407084 Kamil Dudka changed: What|Removed |Added CC||kdu...@redhat.com --- Comment #14 from Kamil Dudka --- I did not even realize this could have been intentional. I though I hit some window redraw bug in compositor or something. It took me hours to google this bug report because I did not know what to look for. I had profiles like "default", "root shell", "Fedora VM", "CentOS VM", "Debian VM" and have been using the profile shortcuts to quickly fire up a new session of the chosen kind. After the update, the shortcuts only change the title of my konsole window without any other (useful) effect. Moreover, it is quite dangerous when I have root shell of my bare metal machine in a tab named "Fedora VM". Could you please restore the original behavior that I used to use for a decade or so? -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 407084] Changed behavior of profile shortcuts in Konsole
https://bugs.kde.org/show_bug.cgi?id=407084 Achim Bohnet changed: What|Removed |Added CC||a...@mpe.mpg.de --- Comment #13 from Achim Bohnet --- Intentional does not automatically imply that it's the right thing(tm). It broke existing work-flow: Now one is forced to use a submenu (long in mycase) instead of a shortcut to open a new-tab with a predefined command. See e.g. #407076 #408217 See Darin suggestion at https://bugs.kde.org/show_bug.cgi?id=408217#c3 Good summary. And an possible solution. -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 407084] Changed behavior of profile shortcuts in Konsole
https://bugs.kde.org/show_bug.cgi?id=407084 --- Comment #12 from Mykola Krachkovsky --- Created attachment 119867 --> https://bugs.kde.org/attachment.cgi?id=119867=edit Current not finished patch Question is about literals in profileShortcutGroupName -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 407084] Changed behavior of profile shortcuts in Konsole
https://bugs.kde.org/show_bug.cgi?id=407084 --- Comment #11 from tcanabr...@kde.org --- Can we take a look at the code to understand the behavioral change you are testing? Em seg, 6 de mai de 2019 às 12:19, Mykola Krachkovsky < bugzilla_nore...@kde.org> escreveu: > https://bugs.kde.org/show_bug.cgi?id=407084 > > --- Comment #10 from Mykola Krachkovsky --- > So, I'm trying to implement this feature, currently in the middle of > solving > this problem. But there is one easy for implementing but principal decision > should be made — konsolerc file before and currently has one section > [Profile > Shortcuts], I'm introducing another, but which variant should be accepted: > > 1. [Profile Shortcuts] is used for new tab (as before 19.04). > [Apply Profile Shortcuts] is introduced to apply profile. > pros: no breakage for people who will update from 18.xx to future 19.xx, > just > new feature. > cons: double breakage for people with rolling updates. > > 2. [Profile Shortcuts] is used to apply profile (as in 19.04). > [Profile New Tab Shortcuts] is introduced to create new tab with profile. > > I'm personally for the 1st variant, but it's not very important to me as > it's > easily fixable (just rename group in config file). > > -- > You are receiving this mail because: > You are the assignee for the bug. -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 407084] Changed behavior of profile shortcuts in Konsole
https://bugs.kde.org/show_bug.cgi?id=407084 --- Comment #10 from Mykola Krachkovsky --- So, I'm trying to implement this feature, currently in the middle of solving this problem. But there is one easy for implementing but principal decision should be made — konsolerc file before and currently has one section [Profile Shortcuts], I'm introducing another, but which variant should be accepted: 1. [Profile Shortcuts] is used for new tab (as before 19.04). [Apply Profile Shortcuts] is introduced to apply profile. pros: no breakage for people who will update from 18.xx to future 19.xx, just new feature. cons: double breakage for people with rolling updates. 2. [Profile Shortcuts] is used to apply profile (as in 19.04). [Profile New Tab Shortcuts] is introduced to create new tab with profile. I'm personally for the 1st variant, but it's not very important to me as it's easily fixable (just rename group in config file). -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 407084] Changed behavior of profile shortcuts in Konsole
https://bugs.kde.org/show_bug.cgi?id=407084 tcanabr...@kde.org changed: What|Removed |Added CC||tcanabr...@kde.org --- Comment #9 from tcanabr...@kde.org --- not revert, rework. Some people opened bug reports that the workflow was broken for them because when they selected the profile, it opened a new tab, it's hard to make everyone happy. I'd accept patches to make both work. if you are willing to try I can help you setup. -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 407084] Changed behavior of profile shortcuts in Konsole
https://bugs.kde.org/show_bug.cgi?id=407084 --- Comment #8 from Mykola Krachkovsky --- But why this was introduced as replacement of old behaviour? IMHO, this have broken not just my workflow, as profile in Konsole much more powerful than just visual style. So basically we need to revert/rework https://cgit.kde.org/konsole.git/commit/?id=d689ba5403ceb998013fc99de6758976f8509e98 Right? -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 407084] Changed behavior of profile shortcuts in Konsole
https://bugs.kde.org/show_bug.cgi?id=407084 tcanabr...@kde.org changed: What|Removed |Added CC||w01dn...@gmail.com --- Comment #7 from tcanabr...@kde.org --- *** Bug 407121 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 407084] Changed behavior of profile shortcuts in Konsole
https://bugs.kde.org/show_bug.cgi?id=407084 Nate Graham changed: What|Removed |Added See Also||https://bugs.kde.org/show_b ||ug.cgi?id=407076 --- Comment #6 from Nate Graham --- Another request for making the old behavior still available: Bug: 407076 -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 407084] Changed behavior of profile shortcuts in Konsole
https://bugs.kde.org/show_bug.cgi?id=407084 Nate Graham changed: What|Removed |Added CC||n...@kde.org Resolution|--- |INTENTIONAL Status|REPORTED|RESOLVED --- Comment #5 from Nate Graham --- It was indeed. Thanks for understanding! And as Tomaz mentioned, a patch to make this configurable isn't out of the question. -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 407084] Changed behavior of profile shortcuts in Konsole
https://bugs.kde.org/show_bug.cgi?id=407084 --- Comment #4 from Michal Ziabkowski --- While it is disputable what the primary action for profile shortcuts should be (IMO switching profiles and starting a new tab are equally valid use-cases), I'm honestly not inconvenienced much by this change, just a bit surprised that my old shortcut suddenly had a different behavior. In my specific case, I haven't actually used the other profiles much recently, so changing my config and/or habits is feasible. If this behavior was changed for the sake of usability, I don't mind it. It's just some people might be confused as to what happened after upgrading, just like I was. In any case, thank you for the clarification. -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 407084] Changed behavior of profile shortcuts in Konsole
https://bugs.kde.org/show_bug.cgi?id=407084 --- Comment #3 from tcanabr...@kde.org --- There's none. I agree that we should have that somehow, it's easy to implement, are you willing to try? If not we need to wait for a good soul to implement as I'm really busy with other things in konsole right now. On Tue, Apr 30, 2019 at 1:26 PM Michal Ziabkowski wrote: > https://bugs.kde.org/show_bug.cgi?id=407084 > > --- Comment #2 from Michal Ziabkowski --- > I see. What alternative is there for the old functionality, i.e. if someone > wanted to have a shortcut for quickly opening a tab with a given profile? > The > New Tab actions for profiles aren't listed in the shortcut settings. > > -- > You are receiving this mail because: > You are the assignee for the bug. -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 407084] Changed behavior of profile shortcuts in Konsole
https://bugs.kde.org/show_bug.cgi?id=407084 --- Comment #2 from Michal Ziabkowski --- I see. What alternative is there for the old functionality, i.e. if someone wanted to have a shortcut for quickly opening a tab with a given profile? The New Tab actions for profiles aren't listed in the shortcut settings. -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 407084] Changed behavior of profile shortcuts in Konsole
https://bugs.kde.org/show_bug.cgi?id=407084 --- Comment #1 from tcanabr...@kde.org --- This is intentional. On Tue, Apr 30, 2019 at 12:19 PM Michal Ziabkowski wrote: > https://bugs.kde.org/show_bug.cgi?id=407084 > > Bug ID: 407084 >Summary: Changed behavior of profile shortcuts in Konsole >Product: konsole >Version: 19.04.0 > Platform: Gentoo Packages > OS: Linux > Status: REPORTED > Severity: normal > Priority: NOR > Component: general > Assignee: konsole-de...@kde.org > Reporter: mz...@o2.pl > Target Milestone: --- > > SUMMARY > > Before Konsole 19.04, when you set a keyboard shortcut for a Konsole > profile > (in Settings/Manage Profiles), that shortcut would open a new tab with that > profile. With Konsole 19.04 the shortcut switches the current profile for > the > currently open tab instead. I'm not sure if this was intentional or a > regression that slipped in. In any case, browsing the menu confirms that > the > shortcuts are assigned to the Switch Profile actions instead of the New Tab > ones. The same thing happens with a clean config as well. > > > STEPS TO REPRODUCE > 1. Set keyboard shortcut for profile in Settins/Manage Profiles > 2. Use said shortcut > > OBSERVED RESULT > The shortcut switches the profile for the currently open tab. > > EXPECTED RESULT > A new tab is opened with the given profile. > > > SOFTWARE/OS VERSIONS > Operating System: Gentoo Linux > KDE Plasma Version: 5.15.4 > KDE Frameworks Version: 5.57.0 > Qt Version: 5.12.3 > > -- > You are receiving this mail because: > You are the assignee for the bug. -- You are receiving this mail because: You are watching all bug changes.
