[konsole] [Bug 411387] Split View crash with keyboard navigation

2019-10-03 Thread Kurt Hindenburg
https://bugs.kde.org/show_bug.cgi?id=411387 Kurt Hindenburg changed: What|Removed |Added Latest Commit|https://invent.kde.org/kde/ |https://commits.kde.org/kon

[konsole] [Bug 411387] Split View crash with keyboard navigation

2019-10-03 Thread Kurt Hindenburg
https://bugs.kde.org/show_bug.cgi?id=411387 Kurt Hindenburg changed: What|Removed |Added Latest Commit|https://commits.kde.org/kon |https://invent.kde.org/kde/

[konsole] [Bug 411387] Split View crash with keyboard navigation

2019-10-03 Thread Kurt Hindenburg
https://bugs.kde.org/show_bug.cgi?id=411387 Kurt Hindenburg changed: What|Removed |Added Latest Commit|https://invent.kde.org/kde/ |https://commits.kde.org/kon

[konsole] [Bug 411387] Split View crash with keyboard navigation

2019-10-03 Thread Kurt Hindenburg
https://bugs.kde.org/show_bug.cgi?id=411387 Kurt Hindenburg changed: What|Removed |Added Latest Commit|https://commits.kde.org/kon |https://invent.kde.org/kde/

[konsole] [Bug 411387] Split View crash with keyboard navigation

2019-10-03 Thread Kurt Hindenburg
https://bugs.kde.org/show_bug.cgi?id=411387 Kurt Hindenburg changed: What|Removed |Added Latest Commit|https://invent.kde.org/kde/ |https://commits.kde.org/kon

[konsole] [Bug 411387] Split View crash with keyboard navigation

2019-10-03 Thread Kurt Hindenburg
https://bugs.kde.org/show_bug.cgi?id=411387 Kurt Hindenburg changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|---

[konsole] [Bug 411387] Split View crash with keyboard navigation

2019-10-03 Thread Nikolay Zlatev
https://bugs.kde.org/show_bug.cgi?id=411387 --- Comment #16 from Nikolay Zlatev --- (In reply to Kurt Hindenburg from comment #15) > Ok thanks for testing - I misunderstood what is going on - to be clear > "const auto handleWidth = parentSplitter->handleWidth() + 3;" works for all > your

[konsole] [Bug 411387] Split View crash with keyboard navigation

2019-10-03 Thread Kurt Hindenburg
https://bugs.kde.org/show_bug.cgi?id=411387 --- Comment #15 from Kurt Hindenburg --- Ok thanks for testing - I misunderstood what is going on - to be clear "const auto handleWidth = parentSplitter->handleWidth() + 3;" works for all your testing? Also, are you not getting crashes when you do

[konsole] [Bug 411387] Split View crash with keyboard navigation

2019-10-03 Thread Nikolay Zlatev
https://bugs.kde.org/show_bug.cgi?id=411387 --- Comment #14 from Nikolay Zlatev --- Breeze handleWidth = ...pixelMetric(QStyle::PM_SplitterWidth) + 2; ++ || | 0 | || ++ |

[konsole] [Bug 411387] Split View crash with keyboard navigation

2019-10-03 Thread Nikolay Zlatev
https://bugs.kde.org/show_bug.cgi?id=411387 --- Comment #13 from Nikolay Zlatev --- // Find the theme's splitter width + extra space to find valid terminal // https://doc.qt.io/qt-5/qsplitter.html#handleWidth-prop // By default, this property contains a value // that depends on the user's

[konsole] [Bug 411387] Split View crash with keyboard navigation

2019-10-03 Thread Nikolay Zlatev
https://bugs.kde.org/show_bug.cgi?id=411387 Nikolay Zlatev changed: What|Removed |Added Ever confirmed|0 |1 Status|RESOLVED

[konsole] [Bug 411387] Split View crash with keyboard navigation

2019-10-02 Thread Kurt Hindenburg
https://bugs.kde.org/show_bug.cgi?id=411387 Kurt Hindenburg changed: What|Removed |Added Latest Commit|https://invent.kde.org/kde/ |https://commits.kde.org/kon

[konsole] [Bug 411387] Split View crash with keyboard navigation

2019-10-02 Thread Kurt Hindenburg
https://bugs.kde.org/show_bug.cgi?id=411387 Kurt Hindenburg changed: What|Removed |Added Latest Commit||https://invent.kde.org/kde/

[konsole] [Bug 411387] Split View crash with keyboard navigation

2019-09-19 Thread Nikolay Zlatev
https://bugs.kde.org/show_bug.cgi?id=411387 --- Comment #9 from Nikolay Zlatev --- > // Find the theme's splitter width + extra space to find valid terminal >const auto handleWidth = > parentSplitter->style()->pixelMetric(QStyle::PM_SplitterWidth) + 2; On Breeze handleWidth is now "3" (1 +

[konsole] [Bug 411387] Split View crash with keyboard navigation

2019-09-18 Thread Kurt Hindenburg
https://bugs.kde.org/show_bug.cgi?id=411387 --- Comment #8 from Kurt Hindenburg --- I'm testing this which should be more reliable. I'm also finding other issues with different themes. // Find the theme's splitter width + extra space to find valid terminal const auto handleWidth =

[konsole] [Bug 411387] Split View crash with keyboard navigation

2019-09-10 Thread Nikolay Zlatev
https://bugs.kde.org/show_bug.cgi?id=411387 --- Comment #7 from Nikolay Zlatev --- (In reply to Kurt Hindenburg from comment #6) > the null check looks reasonable even though I can't it to crash here with > any theme. The "+1" is worrisome as it appears to be theme specific. const auto

[konsole] [Bug 411387] Split View crash with keyboard navigation

2019-09-09 Thread Kurt Hindenburg
https://bugs.kde.org/show_bug.cgi?id=411387 --- Comment #6 from Kurt Hindenburg --- the null check looks reasonable even though I can't it to crash here with any theme. The "+1" is worrisome as it appears to be theme specific. -- You are receiving this mail because: You are watching all bug

[konsole] [Bug 411387] Split View crash with keyboard navigation

2019-08-30 Thread Nikolay Zlatev
https://bugs.kde.org/show_bug.cgi?id=411387 --- Comment #5 from Nikolay Zlatev --- Final patch diff --git a/src/ViewSplitter.cpp b/src/ViewSplitter.cpp index 7e31172c..38c576a9 100644 --- a/src/ViewSplitter.cpp +++ b/src/ViewSplitter.cpp @@ -147,7 +147,7 @@ void

[konsole] [Bug 411387] Split View crash with keyboard navigation

2019-08-30 Thread Nikolay Zlatev
https://bugs.kde.org/show_bug.cgi?id=411387 --- Comment #4 from Nikolay Zlatev --- It appears this is theme related issue. When I use Breeze everything is OK. For Breeze const auto handleWidth = parentSplitter->handleWidth() <= 1 ? 4 : parentSplitter->handleWidth(); returns 4 as a constant.

[konsole] [Bug 411387] Split View crash with keyboard navigation

2019-08-30 Thread Nikolay Zlatev
https://bugs.kde.org/show_bug.cgi?id=411387 --- Comment #3 from Nikolay Zlatev --- This only happens on some split layouts and only with keyboard navigation. targetSplitter->widget(0) returns Konsole::ViewSplitter and then casting to TerminalDisplay fail. -- You are receiving this mail

[konsole] [Bug 411387] Split View crash with keyboard navigation

2019-08-30 Thread Nikolay Zlatev
https://bugs.kde.org/show_bug.cgi?id=411387 --- Comment #2 from Nikolay Zlatev --- Created attachment 122418 --> https://bugs.kde.org/attachment.cgi?id=122418=edit Debug session -- You are receiving this mail because: You are watching all bug changes.

[konsole] [Bug 411387] Split View crash with keyboard navigation

2019-08-29 Thread Kurt Hindenburg
https://bugs.kde.org/show_bug.cgi?id=411387 --- Comment #1 from Kurt Hindenburg --- I can't reproduce the crash - I'll keep trying - checking for nullptr seems reasonable. -- You are receiving this mail because: You are watching all bug changes.