[kphotoalbum] [Bug 402564] kphotoalbum fails to build against >=exiv2-0.27

2018-12-31 Thread Tobias Leupold
https://bugs.kde.org/show_bug.cgi?id=402564

--- Comment #15 from Tobias Leupold  ---
Even nicer ;-)

-- 
You are receiving this mail because:
You are watching all bug changes.

[kphotoalbum] [Bug 402564] kphotoalbum fails to build against >=exiv2-0.27

2018-12-31 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=402564

--- Comment #14 from andreas.sturmlech...@gmail.com ---
Fix was(In reply to Tobias Leupold from comment #9)
> Perhaps, we can add a 4.5-r1 ebuild for Gentoo including the (surprisingly
> small) patch so that you can remove the hard mask?
Patch was added to 4.5-r0 as-is, no need for new stabilisation. ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

[kphotoalbum] [Bug 402564] kphotoalbum fails to build against >=exiv2-0.27

2018-12-31 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=402564

--- Comment #13 from andreas.sturmlech...@gmail.com ---
Indeed, merged fine, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

[kphotoalbum] [Bug 402564] kphotoalbum fails to build against >=exiv2-0.27

2018-12-31 Thread Johannes Zarl-Zierl
https://bugs.kde.org/show_bug.cgi?id=402564

Johannes Zarl-Zierl  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED
  Latest Commit||https://commits.kde.org/kph
   ||otoalbum/0c127728a20cef252e
   ||ce2125ef1c14975f96bfbd

--- Comment #12 from Johannes Zarl-Zierl  ---
Git commit 0c127728a20cef252ece2125ef1c14975f96bfbd by Johannes Zarl-Zierl.
Committed on 31/12/2018 at 10:59.
Pushed by johanneszarl into branch 'master'.

Merge branch 'feature/exiv2-0.27-v2'


https://commits.kde.org/kphotoalbum/0c127728a20cef252ece2125ef1c14975f96bfbd

-- 
You are receiving this mail because:
You are watching all bug changes.

[kphotoalbum] [Bug 402564] kphotoalbum fails to build against >=exiv2-0.27

2018-12-31 Thread Johannes Zarl-Zierl
https://bugs.kde.org/show_bug.cgi?id=402564

--- Comment #10 from Johannes Zarl-Zierl  ---
Tobias: thanks for testing. I'll merge it to master later today...

-- 
You are receiving this mail because:
You are watching all bug changes.

[kphotoalbum] [Bug 402564] kphotoalbum fails to build against >=exiv2-0.27

2018-12-31 Thread Johannes Zarl-Zierl
https://bugs.kde.org/show_bug.cgi?id=402564

--- Comment #11 from Johannes Zarl-Zierl  ---
Tobias: thanks for testing. I'll merge it to master later today...

-- 
You are receiving this mail because:
You are watching all bug changes.

[kphotoalbum] [Bug 402564] kphotoalbum fails to build against >=exiv2-0.27

2018-12-31 Thread Tobias Leupold
https://bugs.kde.org/show_bug.cgi?id=402564

--- Comment #9 from Tobias Leupold  ---
Johannes pushed a branch fixing the compilation that – on Gentoo – works fine
both with exiv2-0.26 and 0.27. Perhaps, we can add a 4.5-r1 ebuild for Gentoo
including the (surprisingly small) patch so that you can remove the hard mask?

Here's the branch:
https://cgit.kde.org/kphotoalbum.git/log/?h=feature/exiv2-0.27-v2

-- 
You are receiving this mail because:
You are watching all bug changes.

[kphotoalbum] [Bug 402564] kphotoalbum fails to build against >=exiv2-0.27

2018-12-30 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=402564

--- Comment #8 from andreas.sturmlech...@gmail.com ---
For similar fix in gwenview wrt autoPtr, see also:
https://phabricator.kde.org/D17872

-- 
You are receiving this mail because:
You are watching all bug changes.

[kphotoalbum] [Bug 402564] kphotoalbum fails to build against >=exiv2-0.27

2018-12-30 Thread Tobias Leupold
https://bugs.kde.org/show_bug.cgi?id=402564

--- Comment #7 from Tobias Leupold  ---
Okay, with the blessings of a Gentoo dev (obviously), I'm out of excuses now
;-) I'll try it asap!

-- 
You are receiving this mail because:
You are watching all bug changes.

[kphotoalbum] [Bug 402564] kphotoalbum fails to build against >=exiv2-0.27

2018-12-29 Thread Johannes Zarl-Zierl
https://bugs.kde.org/show_bug.cgi?id=402564

--- Comment #6 from Johannes Zarl-Zierl  ---
Now if *that* isn't a good motivation ;-)
I have started a feature branch for it, but the system installation of Exiv2
0.25 interferes with my local installation. I'm tired now - I'll debug my build
problems tomorrow(ish)...

-- 
You are receiving this mail because:
You are watching all bug changes.

[kphotoalbum] [Bug 402564] kphotoalbum fails to build against >=exiv2-0.27

2018-12-29 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=402564

--- Comment #5 from andreas.sturmlech...@gmail.com ---
(In reply to Tobias Leupold from comment #4)
> and here on Gentoo, it's there but hard masked. As soon as we can install it
> without f**ing up our system, we will port the codebase ;-)
You are very much invited to unmask it. ;) I think I've fixed all packages
except Gnome related ones. We can't lift the mask until kphotoalbum is fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kphotoalbum] [Bug 402564] kphotoalbum fails to build against >=exiv2-0.27

2018-12-29 Thread Rex Dieter
https://bugs.kde.org/show_bug.cgi?id=402564

Rex Dieter  changed:

   What|Removed |Added

 CC||rdie...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[kphotoalbum] [Bug 402564] kphotoalbum fails to build against >=exiv2-0.27

2018-12-29 Thread Tobias Leupold
https://bugs.kde.org/show_bug.cgi?id=402564

Tobias Leupold  changed:

   What|Removed |Added

 CC||tobias.leup...@gmx.de

--- Comment #4 from Tobias Leupold  ---
Johannes' distro doesn't even have the respective library and here on Gentoo,
it's there but hard masked. As soon as we can install it without f**ing up our
system, we will port the codebase ;-)

-- 
You are receiving this mail because:
You are watching all bug changes.

[kphotoalbum] [Bug 402564] kphotoalbum fails to build against >=exiv2-0.27

2018-12-29 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=402564

--- Comment #3 from andreas.sturmlech...@gmail.com ---
Yes, I'm aware of that. ;) Basically exiv2-0.27 support is already done in most
kde.org packages depending on it (in progress with libkexiv2), porting was easy
in most of them. We should make sure kphotoalbum does not stay behind in 0.27
adoption considering the ton of bug and security bugfixes that many distros
probably did not yet backport to their 0.26 package.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kphotoalbum] [Bug 402564] kphotoalbum fails to build against >=exiv2-0.27

2018-12-29 Thread Johannes Zarl-Zierl
https://bugs.kde.org/show_bug.cgi?id=402564

Johannes Zarl-Zierl  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||johan...@zarl-zierl.at
 Status|REPORTED|CONFIRMED

--- Comment #2 from Johannes Zarl-Zierl  ---
Thanks for the bug report!

Exiv2 0.27 is not yet supported by kphotoalbum.

As you discovered yourself, not only the CMake package has changed, but there
have been significant changes in the API for version 0.27. Mostly, this is for
the better, but we still have to figure out a way to properly support both the
old and new API for the time being.

Also, version 0.27 has not even landed in most distros yet.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kphotoalbum] [Bug 402564] kphotoalbum fails to build against >=exiv2-0.27

2018-12-25 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=402564

--- Comment #1 from andreas.sturmlech...@gmail.com ---
Created attachment 117106
  --> https://bugs.kde.org/attachment.cgi?id=117106=edit
build.log

/usr/lib/gcc/x86_64-pc-linux-gnu/8.2.0/../../../../x86_64-pc-linux-gnu/bin/ld:
CMakeFiles/kphotoalbum.dir/Exif/DatabaseElement.cpp.o: in function
`Exif::LensExifElement::valueFromExif(Exiv2::ExifData&) const [clone
.cold.34]':
DatabaseElement.cpp:(.text.unlikely+0x26e): undefined reference to
`Exiv2::ExifKey::~ExifKey()'
collect2: error: ld returned 1 exit status

-- 
You are receiving this mail because:
You are watching all bug changes.