[kphotoalbum] [Bug 474392] KPhotoAlbum crashes when user opens the last image/video in viewer then deletes the image and then accesses Show in the Viewer Context Menu

2023-09-26 Thread Victor Lobo
https://bugs.kde.org/show_bug.cgi?id=474392

Victor Lobo  changed:

   What|Removed |Added

 Status|RESOLVED|VERIFIED

--- Comment #5 from Victor Lobo  ---
This fix works well. Thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.

[kphotoalbum] [Bug 474392] KPhotoAlbum crashes when user opens the last image/video in viewer then deletes the image and then accesses Show in the Viewer Context Menu

2023-09-24 Thread Johannes Zarl-Zierl
https://bugs.kde.org/show_bug.cgi?id=474392

--- Comment #4 from Johannes Zarl-Zierl  ---
Hi Victor!

Thanks! The fix for the regression seems easy enough - can you please test the
fix?

Cheers,
  Johannes

-- 
You are receiving this mail because:
You are watching all bug changes.

[kphotoalbum] [Bug 474392] KPhotoAlbum crashes when user opens the last image/video in viewer then deletes the image and then accesses Show in the Viewer Context Menu

2023-09-24 Thread Johannes Zarl-Zierl
https://bugs.kde.org/show_bug.cgi?id=474392

Johannes Zarl-Zierl  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/kphotoalbum/-/commit/c |hics/kphotoalbum/-/commit/f
   |f90f45e92a1343f5747bc951681 |1e9d5b7ad7e11d7402c5704dfd0
   |341e2c178048|f00600dac102
 Resolution|--- |FIXED
 Status|REOPENED|RESOLVED

--- Comment #3 from Johannes Zarl-Zierl  ---
Git commit f1e9d5b7ad7e11d7402c5704dfd0f00600dac102 by Johannes Zarl-Zierl.
Committed on 25/09/2023 at 00:56.
Pushed by johanneszarl into branch 'master'.

Fix crash/regression caused by cf90f45e

M  +1-1Viewer/ViewerWidget.cpp

https://invent.kde.org/graphics/kphotoalbum/-/commit/f1e9d5b7ad7e11d7402c5704dfd0f00600dac102

-- 
You are receiving this mail because:
You are watching all bug changes.

[kphotoalbum] [Bug 474392] KPhotoAlbum crashes when user opens the last image/video in viewer then deletes the image and then accesses Show in the Viewer Context Menu

2023-09-24 Thread Victor Lobo
https://bugs.kde.org/show_bug.cgi?id=474392

Victor Lobo  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

--- Comment #2 from Victor Lobo  ---
Reopening this bug since the fix seems to have caused another crash if the file
is deleted when the Viewer and Annotations window is open.
Let me know if this should we reported  as a new bug.

Steps to reproduce this:
1. Open KPhotoAlbum
2. Go to Thumbnail View
3. Open  any image or video (does NOT  have to be the last)
4. From the Viewer window opens the Annotations window (Ctrl + 1)
5. Keep the Viewer window and Annotations window open and go back to Thumbnail
view and delete ANY image/video (Press Delete key)
6. Crash 


Backtrace:
Application: KPhotoAlbum (kphotoalbum), signal: Aborted

[KCrash Handler]
#4  0x7f4195091e0c in __pthread_kill_implementation () from
/lib64/libc.so.6
#5  0x7f419503f0e6 in raise () from /lib64/libc.so.6
#6  0x7f41950268d7 in abort () from /lib64/libc.so.6
#7  0x7f41958bb4f9 in qt_message_fatal (message=...,
context=...) at global/qlogging.cpp:1914
#8  QMessageLogger::fatal (this=this@entry=0x7ffe4cb45e88,
msg=msg@entry=0x7f4195bd2028 "ASSERT failure in %s: \"%s\", file %s, line %d")
at global/qlogging.cpp:893
#9  0x7f41958ba78c in qt_assert_x (where=, what=, file=, line=) at global/qglobal.cpp:3399
#10 0x004e13d2 in QList::operator[] (this=0x18322c0, i=0)
at /usr/include/qt5/QtCore/qlist.h:579
#11 0x004d72ba in Viewer::ViewerWidget::slotRemoveDeletedImages
(this=0x18321f0, imageList=...) at
/home/victor/Downloads/kphotoalbum/Viewer/ViewerWidget.cpp:515
#12 0x004e5ac9 in QtPrivate::FunctorCall,
QtPrivate::List, void, void
(Viewer::ViewerWidget::*)(DB::FileNameList const&)>::call (f=(void
(Viewer::ViewerWidget::*)(Viewer::ViewerWidget * const, const DB::FileNameList
&)) 0x4d728a , o=0x18321f0, arg=0x7ffe4cb460f0) at
/usr/include/qt5/QtCore/qobjectdefs_impl.h:152
#13 0x004e50b2 in QtPrivate::FunctionPointer::call, void> (f=(void
(Viewer::ViewerWidget::*)(Viewer::ViewerWidget * const, const DB::FileNameList
&)) 0x4d728a , o=0x18321f0, arg=0x7ffe4cb460f0) at
/usr/include/qt5/QtCore/qobjectdefs_impl.h:185
#14 0x004e3e7b in QtPrivate::QSlotObject, void>::impl (which=1,
this_=0x1a86c50, r=0x18321f0, a=0x7ffe4cb460f0, ret=0x0) at
/usr/include/qt5/QtCore/qobjectdefs_impl.h:418
#15 0x7f4195b25812 in QtPrivate::QSlotObjectBase::call (a=0x7ffe4cb460f0,
r=0x18321f0, this=0x1a86c50) at
../../include/QtCore/../../src/corelib/kernel/qobjectdefs_impl.h:398
#16 doActivate (sender=0xbe65d0, signal_index=5, argv=0x7ffe4cb460f0) at
kernel/qobject.cpp:3925
#17 0x0058b401 in DB::ImageDB::imagesDeleted (this=0xbe65d0, _t1=...)
at
/home/victor/Downloads/kphotoalbum/build/kphotoalbum_autogen/include/moc_ImageDB.cpp:261
#18 0x00586d12 in DB::ImageDB::deleteList (this=0xbe65d0, list=...) at
/home/victor/Downloads/kphotoalbum/DB/ImageDB.cpp:638
#19 0x00652956 in Utilities::DeleteFiles::deleteFilesPrivate
(this=0x198ffe0, files=..., method=Utilities::MoveToTrash) at
/home/victor/Downloads/kphotoalbum/Utilities/DeleteFiles.cpp:73
#20 0x006525ad in Utilities::DeleteFiles::deleteFiles (files=...,
method=Utilities::MoveToTrash) at
/home/victor/Downloads/kphotoalbum/Utilities/DeleteFiles.cpp:31
#21 0x00524479 in MainWindow::DeleteDialog::deleteImages
(this=0x1963fb0) at
/home/victor/Downloads/kphotoalbum/MainWindow/DeleteDialog.cpp:89
#22 0x00524aa0 in QtPrivate::FunctorCall,
QtPrivate::List<>, void, void (MainWindow::DeleteDialog::*)()>::call(void
(MainWindow::DeleteDialog::*)(), MainWindow::DeleteDialog*, void**) (f=(void
(MainWindow::DeleteDialog::*)(MainWindow::DeleteDialog * const)) 0x524420
, o=0x1963fb0, arg=0x7ffe4cb46480) at
/usr/include/qt5/QtCore/qobjectdefs_impl.h:152
#23 0x00524a32 in QtPrivate::FunctionPointer::call, void>(void
(MainWindow::DeleteDialog::*)(), MainWindow::DeleteDialog*, void**) (f=(void
(MainWindow::DeleteDialog::*)(MainWindow::DeleteDialog * const)) 0x524420
, o=0x1963fb0, arg=0x7ffe4cb46480) at
/usr/include/qt5/QtCore/qobjectdefs_impl.h:185
#24 0x0052499d in QtPrivate::QSlotObject, void>::impl(int,
QtPrivate::QSlotObjectBase*, QObject*, void**, bool*) (which=1,
this_=0x1817560, r=0x1963fb0, a=0x7ffe4cb46480, ret=0x0) at
/usr/include/qt5/QtCore/qobjectdefs_impl.h:418
#25 0x7f4195b25812 in QtPrivate::QSlotObjectBase::call (a=0x7ffe4cb46480,
r=0x1963fb0, this=0x1817560) at
../../include/QtCore/../../src/corelib/kernel/qobjectdefs_impl.h:398
#26 doActivate (sender=0xe30ca0, signal_index=8, argv=0x7ffe4cb46480) at
kernel/qobject.cpp:3925
#27 0x7f4195b1e47f in QMetaObject::activate (sender=sender@entry=0xe30ca0,
m=m@entry=0x7f4196cc9440 ,
local_signal_index=local_signal_index@entry=1, argv=argv@entry=0x0) 

[kphotoalbum] [Bug 474392] KPhotoAlbum crashes when user opens the last image/video in viewer then deletes the image and then accesses Show in the Viewer Context Menu

2023-09-17 Thread Johannes Zarl-Zierl
https://bugs.kde.org/show_bug.cgi?id=474392

Johannes Zarl-Zierl  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/grap
   ||hics/kphotoalbum/-/commit/c
   ||f90f45e92a1343f5747bc951681
   ||341e2c178048

--- Comment #1 from Johannes Zarl-Zierl  ---
Git commit cf90f45e92a1343f5747bc951681341e2c178048 by Johannes Zarl-Zierl.
Committed on 18/09/2023 at 00:13.
Pushed by johanneszarl into branch 'master'.

Properly adjust current viewer info if files are deleted.

If images are deleted while the viewer window is open, the viewer widget
would not change the currently displayed image.
This issue also could lead to a crash if the currently displayed image
is invalidated.

M  +2-1CHANGELOG.md
M  +19   -0Viewer/ViewerWidget.cpp

https://invent.kde.org/graphics/kphotoalbum/-/commit/cf90f45e92a1343f5747bc951681341e2c178048

-- 
You are receiving this mail because:
You are watching all bug changes.

[kphotoalbum] [Bug 474392] KPhotoAlbum crashes when user opens the last image/video in viewer then deletes the image and then accesses Show in the Viewer Context Menu

2023-09-11 Thread Johannes Zarl-Zierl
https://bugs.kde.org/show_bug.cgi?id=474392

Johannes Zarl-Zierl  changed:

   What|Removed |Added

 Status|REPORTED|CONFIRMED
 CC||johan...@zarl-zierl.at
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are watching all bug changes.