[krita] [Bug 338470] Support Photoshop/Adobe TIFF extensions.

[Halla Rempt]

https://bugs.kde.org/show_bug.cgi?id=338470

Halla Rempt  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/grap
   ||hics/krita/commit/2dc3df63a
   ||8ad52468afd2a8a8f1123d4c080
   ||627d

--- Comment #20 from Halla Rempt  ---
Git commit 2dc3df63a8ad52468afd2a8a8f1123d4c080627d by Halla Rempt, on behalf
of L. E. Segovia.
Committed on 23/08/2021 at 13:11.
Pushed by rempt into branch 'master'.

TIFF: add support for reading Photoshop layers and metadata

This commit builds upon the previous work in order to enable loading
the PSD-like layer data and metadata from the TIFFTAG_IMAGESOURCEDATA
and TIFFTAG_PHOTOSHOP fields.

Of special relevance are the following:

TIFFTAG_IMAGESOURCEDATA is a sequence of Layr/Lr16/Lr32 layer block,
followed by LMsk (which is Adobe's take on a global mask info block),
followed by Patt and Anot. As these are a byte-by-byte equivalent
of the PSD's additional layer info blocks, for TIFF I've added a logic
path that takes advantage of Lr16/32 and handles them all as additional
logic blocks safely. It must also be noted that these are globally
aligned to 4-byte boundaries, which do *not* apply to internal blocks
(see Layr), and they are also in *the endianness of the container* (this
is the reason why I added endianness handling in previous commits).

TIFFTAG_PHOTOSHOP is just a concatenation of resource blocks (as opposed
to a full resource section), but unlike the previous, it's in big endian
like its PSD sibling.

M  +31   -2libs/psd/psd_additional_layer_info_block.cpp
M  +3-0libs/psd/psd_additional_layer_info_block.h
M  +1-0libs/psd/psd_header.cpp
M  +1-0libs/psd/psd_header.h
M  +2-1libs/psd/psd_layer_record.cpp
M  +116  -28   libs/psd/psd_layer_section.cpp
M  +4-1libs/psd/psd_layer_section.h
M  +121  -60   libs/psd/psd_pixel_utils.cpp
M  +13   -3libs/psd/psd_pixel_utils.h
M  +1-1libs/psdutils/psd_utils.h
M  +5-3plugins/impex/tiff/CMakeLists.txt
M  +360  -60   plugins/impex/tiff/kis_tiff_converter.cc
M  +44   -3plugins/impex/tiff/kis_tiff_converter.h
A  +99   -0plugins/impex/tiff/kis_tiff_psd_layer_record.cpp [License:
GPL(v2.0+)]
A  +53   -0plugins/impex/tiff/kis_tiff_psd_layer_record.h [License:
GPL(v2.0+)]
A  +276  -0plugins/impex/tiff/kis_tiff_psd_resource_record.cpp
[License: GPL(v2.0+)]
A  +170  -0plugins/impex/tiff/kis_tiff_psd_resource_record.h [License:
GPL(v2.0+)]

https://invent.kde.org/graphics/krita/commit/2dc3df63a8ad52468afd2a8a8f1123d4c080627d

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 338470] Support Photoshop/Adobe TIFF extensions.

[Bug Janitor Service]

https://bugs.kde.org/show_bug.cgi?id=338470

--- Comment #19 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/graphics/krita/-/merge_requests/944

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 338470] Support Photoshop/Adobe TIFF extensions.

[amyspark]

https://bugs.kde.org/show_bug.cgi?id=338470

amyspark  changed:

   What|Removed |Added

 Status|CONFIRMED   |ASSIGNED
   Assignee|krita-bugs-n...@kde.org |a...@amyspark.me
 CC||a...@amyspark.me

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 338470] Support Photoshop/Adobe TIFF extensions.

[Raghavendra kamath]

https://bugs.kde.org/show_bug.cgi?id=338470

--- Comment #18 from Raghavendra kamath  ---
Yes , sorry for false alarm it works now, :(

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 338470] Support Photoshop/Adobe TIFF extensions.

[Boudewijn Rempt]

https://bugs.kde.org/show_bug.cgi?id=338470

--- Comment #17 from Boudewijn Rempt  ---
Works here when I uncheck "flatten image".

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 338470] Support Photoshop/Adobe TIFF extensions.

[Raghavendra kamath]

https://bugs.kde.org/show_bug.cgi?id=338470

--- Comment #16 from Raghavendra kamath  ---
In the recent master, saving to multi layers tiff file from krita is not
working.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 338470] Support Photoshop/Adobe TIFF extensions.

[David]

https://bugs.kde.org/show_bug.cgi?id=338470

--- Comment #15 from David  ---
Gimp (as well as Krita) still opens photoshop tiffs flattened. (Gimp 2.10.12).
The tweet says "support for layers exporting to TIFF" (So export, no import)

Imagemagick does read the layers.
A convert saves the layers separately as images
convert ret.tif ret-test.png
(ImageMagick 6.9.7-4 Q16 x86_64 20170114)

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 338470] Support Photoshop/Adobe TIFF extensions.

[Boudewijn Rempt]

https://bugs.kde.org/show_bug.cgi?id=338470

--- Comment #14 from Boudewijn Rempt  ---
Yes, Krita doesn't import layers from tiffs made in PS. That is what this wish
is all about.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 338470] Support Photoshop/Adobe TIFF extensions.

[Paul Geraskin]

https://bugs.kde.org/show_bug.cgi?id=338470

--- Comment #13 from Paul Geraskin  ---
Hi. Krita does not import layers from tiff. The tiff was made in PS.
I attached my file.
https://bugs.kde.org/attachment.cgi?id=122273

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 338470] Support Photoshop/Adobe TIFF extensions.

[Paul Geraskin]

https://bugs.kde.org/show_bug.cgi?id=338470

Paul Geraskin  changed:

   What|Removed |Added

 CC||paulgeras...@gmail.com

--- Comment #12 from Paul Geraskin  ---
Created attachment 122273
  --> https://bugs.kde.org/attachment.cgi?id=122273=edit
Krita does not import layers from tiff

Krita does not import layers from tiff

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 338470] Support Photoshop/Adobe TIFF extensions.

[Boudewijn Rempt]

https://bugs.kde.org/show_bug.cgi?id=338470

--- Comment #11 from Boudewijn Rempt  ---
Is that photoshop-like tiff, or standard layered tiff, like we already support?

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 338470] Support Photoshop/Adobe TIFF extensions.

[Raghavendra kamath]

https://bugs.kde.org/show_bug.cgi?id=338470

--- Comment #10 from Raghavendra kamath  ---
The darktable dev has added layered tiff support for GIMP, can we take a look
at it for our reference -
https://twitter.com/GIMP_Official/status/1118811319036252160

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 338470] Support Photoshop/Adobe TIFF extensions.

[Boudewijn Rempt]

https://bugs.kde.org/show_bug.cgi?id=338470

--- Comment #9 from Boudewijn Rempt  ---
*** Bug 387751 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 338470] Support Photoshop/Adobe TIFF extensions.

[Boudewijn Rempt]

https://bugs.kde.org/show_bug.cgi?id=338470

Boudewijn Rempt  changed:

   What|Removed |Added

 CC||ene...@gmail.com

--- Comment #8 from Boudewijn Rempt  ---
*** Bug 377094 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.