[krita] [Bug 374847] paintoppresets using internal patterns bug

[Halla Rempt]

https://bugs.kde.org/show_bug.cgi?id=374847

Halla Rempt  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED

--- Comment #9 from Halla Rempt  ---
The embedded resource system has been completely rewritten, and I cannot
reproduce these issues with patterns any more.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 374847] paintoppresets using internal patterns bug

[Tymond]

https://bugs.kde.org/show_bug.cgi?id=374847

Tymond  changed:

   What|Removed |Added

  Component|Brush engines   |Resource Management

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 374847] paintoppresets using internal patterns bug

[Tymond]

https://bugs.kde.org/show_bug.cgi?id=374847

Tymond  changed:

   What|Removed |Added

 CC||tamtamy.tym...@gmail.com

--- Comment #8 from Tymond  ---
I guess in the new resource system, this should just look for patterns by both
md5 and a name. Although I'm not sure why searching for md5 wouldn't work -
does pattern not have md5 calculated at all? What might have been another
reason for all/random patterns having the same md5?

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 374847] paintoppresets using internal patterns bug

[Boudewijn Rempt]

https://bugs.kde.org/show_bug.cgi?id=374847

--- Comment #7 from Boudewijn Rempt  ---
Pushed the patch, but cc'ed the wrong bug.

commit 912aee6f2381819b8bf6fc0ec40e79811d2b01cb
Author: Boudewijn Rempt 
Date:   Mon Jan 23 16:20:12 2017 +0100

CCBUG:374745 Always store the embedded pattern in the pattern manager

This will lead to duplicated patterns, but at least not every
brush will paint with the same pattern.

This bug still needs careful fixing.

Patch by Razvanc, thanks!

CCMAIL:razvan...@yahoo.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 374847] paintoppresets using internal patterns bug

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=374847

--- Comment #6 from razvan...@yahoo.com ---
I don't think it breaks anything, instead of trying to remove the texture it
just appends what's needed if it's needed then retrieve it later and leaves
them be in the system. It's a bad way of handling stuff, but I don't think this
way of doing it breaks anything.

In my opinion this whole system needs to be rewritten... a pain.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 374847] paintoppresets using internal patterns bug

[Boudewijn Rempt]

https://bugs.kde.org/show_bug.cgi?id=374847

--- Comment #5 from Boudewijn Rempt  ---
Yes, I can confirm the issue. I will push the patch, but keep the bug open
since I'm pretty sure that the patch breaks other things. This needs a couple
of days of careful consideration.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 374847] paintoppresets using internal patterns bug

[Boudewijn Rempt]

https://bugs.kde.org/show_bug.cgi?id=374847

Boudewijn Rempt  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |CONFIRMED
 CC||b...@valdyas.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 374847] paintoppresets using internal patterns bug

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=374847

--- Comment #4 from razvan...@yahoo.com ---
Created attachment 10
  --> https://bugs.kde.org/attachment.cgi?id=10=edit
fix that works for me

It's probably not the correct fix, but it seems to work for me. The only thing
is that instead of being only one pattern added to the pattern list at the end
(I don't know if it's the intended behavior), all embedded patterns are added
one by one if they're not in the list, but it does get the job done

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 374847] paintoppresets using internal patterns bug

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=374847

--- Comment #3 from razvan...@yahoo.com ---
> identify -verbose /usr/share/krita/paintoppresets/Bristle_frottis.kpp | grep 
> 'Pattern\/Name'
 

> identify -verbose /usr/share/krita/paintoppresets/Pastel_texture_thin.kpp | 
> grep 'Pattern\/Name'


-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 374847] paintoppresets using internal patterns bug

[Nathan Lovato]

https://bugs.kde.org/show_bug.cgi?id=374847

Nathan Lovato  changed:

   What|Removed |Added

 CC||nathan.lovato@gmail.com

--- Comment #2 from Nathan Lovato  ---
Can confirm the bug. On my config, both Bristle_frottis.kpp and
Pastel_texture_thin.kpp use the same pattern: "3-mini-rock-soft.png"

While, according to imagemagick, they should respectively use
3-mini-rock-soft.png and 3-rock-smooth.png

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 374847] paintoppresets using internal patterns bug

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=374847

--- Comment #1 from razvan...@yahoo.com ---
Well, it's extremely annoying because I need to remember which brushes have
internal patterns but at least if I delete the pattern from the f5 menu before
I select a paintop that uses an internal pattern then the correct pattern is
indeed loaded, but I need to remember to delete this internal pattern now for
every brush that uses it...

-- 
You are receiving this mail because:
You are watching all bug changes.