[krita] [Bug 376596] crash while removing frames in the animation timeline

2017-04-19 Thread Dmitry Kazakov 
https://bugs.kde.org/show_bug.cgi?id=376596

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit|https://commits.kde.org/kri |https://commits.kde.org/kri
   |ta/17a922c5576ba217bcb450e6 |ta/c2d5d8a41f3cc65f1200905f
   |ae6c9ad04fec35b2|fefa175c1e029fa4

--- Comment #5 from Dmitry Kazakov  ---
Git commit c2d5d8a41f3cc65f1200905ffefa175c1e029fa4 by Dmitry Kazakov.
Committed on 19/04/2017 at 17:03.
Pushed by dkazakov into branch 'krita/3.1'.

Port animation frames commands to use strokes

The system is not ideal, we have to use lambda commands coupled
with SkipFirstRedoWrapper. The problem is that our animation
framework returns "post-execution" commands. That is, it first modifies
the object and then returns the command for undoing this.

In the future we should refactor the animation system not to do this
post-execution thing, but just return commands for doing the work. Then
the code will be a bit simplified.

M  +45   -2libs/image/kis_command_utils.cpp
M  +37   -1libs/image/kis_command_utils.h
M  +10   -0libs/image/kis_processing_applicator.cpp
M  +13   -0libs/image/kis_processing_applicator.h
M  +2-1libs/ui/KisImageBarrierLockerWithFeedback.h
M  +58   -18   plugins/dockers/animation/kis_animation_curves_model.cpp
M  +140  -109  plugins/dockers/animation/kis_animation_utils.cpp
M  +12   -7plugins/dockers/animation/kis_animation_utils.h
M  +36   -31   plugins/dockers/animation/kis_time_based_item_model.cpp
M  +3-1plugins/dockers/animation/kis_time_based_item_model.h
M  +4-13   plugins/dockers/animation/timeline_frames_model.cpp

https://commits.kde.org/krita/c2d5d8a41f3cc65f1200905ffefa175c1e029fa4

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 376596] crash while removing frames in the animation timeline

2017-04-19 Thread Dmitry Kazakov 
https://bugs.kde.org/show_bug.cgi?id=376596

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit||https://commits.kde.org/kri
   ||ta/17a922c5576ba217bcb450e6
   ||ae6c9ad04fec35b2
 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED

--- Comment #4 from Dmitry Kazakov  ---
Git commit 17a922c5576ba217bcb450e6ae6c9ad04fec35b2 by Dmitry Kazakov.
Committed on 19/04/2017 at 16:49.
Pushed by dkazakov into branch 'master'.

Port animation frames commands to use strokes

The system is not ideal, we have to use lambda commands coupled
with SkipFirstRedoWrapper. The problem is that our animation
framework returns "post-execution" commands. That is, it first modifies
the object and then returns the command for undoing this.

In the future we should refactor the animation system not to do this
post-execution thing, but just return commands for doing the work. Then
the code will be a bit simplified.

M  +45   -2libs/command/kis_command_utils.cpp
M  +37   -1libs/command/kis_command_utils.h
M  +10   -0libs/image/kis_processing_applicator.cpp
M  +13   -0libs/image/kis_processing_applicator.h
M  +2-1libs/ui/KisImageBarrierLockerWithFeedback.h
M  +58   -18   plugins/dockers/animation/kis_animation_curves_model.cpp
M  +140  -109  plugins/dockers/animation/kis_animation_utils.cpp
M  +12   -7plugins/dockers/animation/kis_animation_utils.h
M  +36   -31   plugins/dockers/animation/kis_time_based_item_model.cpp
M  +3-1plugins/dockers/animation/kis_time_based_item_model.h
M  +4-13   plugins/dockers/animation/timeline_frames_model.cpp

https://commits.kde.org/krita/17a922c5576ba217bcb450e6ae6c9ad04fec35b2

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 376596] crash while removing frames in the animation timeline

2017-04-18 Thread Dmitry Kazakov 
https://bugs.kde.org/show_bug.cgi?id=376596

Dmitry Kazakov  changed:

   What|Removed |Added

 CC||dimul...@gmail.com

--- Comment #3 from Dmitry Kazakov  ---
The problem is more general. The animation actions do not care about strokes
and locking. Therefore the frame is removed while some update or animation
cache regenerator is accessing the image frames.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 376596] crash while removing frames in the animation timeline

2017-03-27 Thread Boudewijn Rempt 
https://bugs.kde.org/show_bug.cgi?id=376596

Boudewijn Rempt  changed:

   What|Removed |Added

   Severity|normal  |crash

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 376596] crash while removing frames in the animation timeline

2017-02-27 Thread Boudewijn Rempt 
https://bugs.kde.org/show_bug.cgi?id=376596

Boudewijn Rempt  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |CONFIRMED
 CC||b...@valdyas.org

--- Comment #2 from Boudewijn Rempt  ---
I suspect that this was caused by cleanup some usage of shared pointers. I can
confirm the crash:

#0  0x76294793 in
KisPaintDevice::Private::transferFromData(KisPaintDeviceData*,
KisSharedPtr) (this=this@entry=0x7b01fe0, data=0x0,
targetDevice=...)
at /home/boud/dev/krita/libs/image/kis_paint_device.cc:753
#1  0x762948f5 in KisPaintDevice::Private::fetchFrame(int,
KisSharedPtr) (this=0x7b01fe0, frameId=18, targetDevice=...) at
/home/boud/dev/krita/libs/image/kis_paint_device.cc:763
#2  0x76294955 in KisPaintDeviceFramesInterface::fetchFrame(int,
KisSharedPtr) (this=, frameId=frameId@entry=18,
targetDevice=...)
at /home/boud/dev/krita/libs/image/kis_paint_device.cc:2003
#3  0x7632873b in
KisRasterKeyframeChannel::fetchFrame(QSharedPointer,
KisSharedPtr) (this=this@entry=0x85b1790, keyframe=...,
targetDevice=...)
at /home/boud/dev/krita/libs/image/kis_raster_keyframe_channel.cpp:102
#4  0x7632dcc4 in
KisOnionSkinCompositor::composite(KisSharedPtr,
KisSharedPtr, QRect const&) (rect=..., opacity=91,
tintSource=..., 
gcDest=..., gcFrame=..., keyframe=..., keyframes=0x85b1790, this=)
at /home/boud/dev/krita/libs/image/kis_onion_skin_compositor.cpp:80
#5  0x7632dcc4 in
KisOnionSkinCompositor::composite(KisSharedPtr,
KisSharedPtr, QRect const&) (this=this@entry=0x76634db0
<_ZZN12_GLOBAL__N_116Q_QGS_s_instance13innerFunctionEvE6holder>,
sourceDevice=..., targetDevice=..., rect=...)
at /home/boud/dev/krita/libs/image/kis_onion_skin_compositor.cpp:170
#6  0x7632e928 in
KisOnionSkinCache::projection(KisSharedPtr) (this=0x7aff970,
source=...) at /home/boud/dev/krita/libs/image/kis_onion_skin_cache.cpp:99
#7  0x762a4f0c in
KisPaintLayer::copyOriginalToProjection(KisSharedPtr,
KisSharedPtr, QRect const&) const (this=0x7b01880,
original=..., projection=..., rect=...)
at /home/boud/dev/krita/libs/image/kis_paint_layer.cc:168
#8  0x7625f717 in KisLayer::applyMasks(KisSharedPtr,
KisSharedPtr, QRect const&, KisSharedPtr,
KisSharedPtr) const (this=this@entry=0x7b01880, source=...,
destination=..., requestedRect=..., filthyNode=..., lastNode=...) at
/home/boud/dev/krita/libs/image/kis_layer.cc:594
#9  0x762603f7 in KisLayer::updateProjection(QRect const&,
KisSharedPtr) (this=0x7b01880, rect=..., filthyNode=...) at
/home/boud/dev/krita/libs/image/kis_layer.cc:684
#10 0x76263538 in KisLayerProjectionPlane::recalculate(QRect const&,
KisSharedPtr) (this=, rect=..., filthyNode=...) at
/home/boud/dev/krita/libs/image/kis_layer_projection_plane.cpp:47
#11 0x76222834 in KisAsyncMerger::startMerge(KisBaseRectsWalker&, bool)
(this=this@entry=0x7a3dda0, walker=..., notifyClones=notifyClones@entry=true)
at /home/boud/dev/krita/libs/image/kis_async_merger.cpp:251
#12 0x76368dd3 in KisUpdateJobItem::run() (this=0x7a3dd60)
at
/home/boud/dev/build/libs/image/kritaimage_automoc.dir/../../../../krita/libs/image/kis_update_job_item.h:83
#13 0x76368dd3 in KisUpdateJobItem::run() (this=0x7a3dd60)
at
/home/boud/dev/build/libs/image/kritaimage_automoc.dir/../../../../krita/libs/image/kis_update_job_item.h:63
#14 0x7fffeded15fe in  () at /home/boud/dev/deps/lib/libQt5Core.so.5
#15 0x7fffeded4609 in  () at /home/boud/dev/deps/lib/libQt5Core.so.5
#16 0x7fffecfcb0a4 in start_thread () at /lib64/libpthread.so.0
#17 0x7fffed2c502d in clone () at /lib64/libc.so.6

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 376596] crash while removing frames in the animation timeline

2017-02-17 Thread z-uo 
https://bugs.kde.org/show_bug.cgi?id=376596

--- Comment #1 from z-uo  ---
okay after a few more test it crash every times with the copy of the file, so
I've put it here
https://nicolasbougere.cozycloud.cc/public/files/files/ab1e8a58e2a31d9afca2b473858ce0c6/attach/sdggxcbxcvxcv.kra
I also tried with the krita appimage with the same result
The step are (in the timeline) in the layer "jambe droite" select the frame 33 
with shift select the frame 11
right clic and remove frame
then it crash

If you first select the frame 11 then the 33 it works just fine...

-- 
You are receiving this mail because:
You are watching all bug changes.