[krita] [Bug 380437] Save does not work when I only change layer name

[Boudewijn Rempt]

https://bugs.kde.org/show_bug.cgi?id=380437

Boudewijn Rempt  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/kde/
   ||krita/commit/43f89ce8d9c13e
   ||e0c174737166ec3cec4eecff3e
 Status|CONFIRMED   |RESOLVED

--- Comment #9 from Boudewijn Rempt  ---
Git commit 43f89ce8d9c13ee0c174737166ec3cec4eecff3e by Boudewijn Rempt.
Committed on 03/05/2019 at 11:50.
Pushed by rempt into branch 'master'.

Create an undo command for node renaming

This means that changing a node's name will now mark the document
modified so it can be saved, and it's possible to undo a node
rename.

M  +1-0libs/image/CMakeLists.txt
C  +11   -15   libs/image/commands/KisNodeRenameCommand.cpp [from:
libs/image/commands/kis_node_compositeop_command.cpp - 055% similarity]
A  +40   -0libs/image/commands/KisNodeRenameCommand.h [License: GPL
(v2+)]
M  +0-2libs/image/commands/kis_node_compositeop_command.cpp
M  +7-0libs/ui/kis_node_commands_adapter.cpp
M  +1-0libs/ui/kis_node_commands_adapter.h
M  +9-0libs/ui/kis_node_manager.cpp
M  +5-0libs/ui/kis_node_manager.h
M  +1-1libs/ui/kis_node_model.cpp

https://invent.kde.org/kde/krita/commit/43f89ce8d9c13ee0c174737166ec3cec4eecff3e

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 380437] Save does not work when I only change layer name

[Boudewijn Rempt]

https://bugs.kde.org/show_bug.cgi?id=380437

Boudewijn Rempt  changed:

   What|Removed |Added

   Assignee|krita-bugs-n...@kde.org |b...@valdyas.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 380437] Save does not work when I only change layer name

[Boudewijn Rempt]

https://bugs.kde.org/show_bug.cgi?id=380437

--- Comment #8 from Boudewijn Rempt  ---
Changing the layer name is not an undoable action and doesn't set the document
to modified.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 380437] Save does not work when I only change layer name

[Boudewijn Rempt]

https://bugs.kde.org/show_bug.cgi?id=380437

Boudewijn Rempt  changed:

   What|Removed |Added

 CC||l...@shitmail.de

--- Comment #7 from Boudewijn Rempt  ---
*** Bug 389562 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 380437] Save does not work when I only change layer name

[Scott Petrovic]

https://bugs.kde.org/show_bug.cgi?id=380437

Scott Petrovic  changed:

   What|Removed |Added

 CC||scottpetro...@gmail.com

--- Comment #5 from Scott Petrovic  ---
This was a recent bug that was introduced a week ago.

I am working on a patch to fix this...as well as add some functionality to the
transform tool. The work is being done here... 

https://phabricator.kde.org/D18792

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 380437] Save does not work when I only change layer name

[Scott Petrovic]

https://bugs.kde.org/show_bug.cgi?id=380437

--- Comment #6 from Scott Petrovic  ---
sorry...posted on wrong ticket :(

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 380437] Save does not work when I only change layer name

[Boudewijn Rempt]

https://bugs.kde.org/show_bug.cgi?id=380437

Boudewijn Rempt  changed:

   What|Removed |Added

   Severity|major   |normal
 CC||b...@valdyas.org
  Component|General |Usability

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 380437] Save does not work when I only change layer name

[Boudewijn Rempt]

https://bugs.kde.org/show_bug.cgi?id=380437

Boudewijn Rempt  changed:

   What|Removed |Added

 CC||chris.we...@googlemail.com

--- Comment #4 from Boudewijn Rempt  ---
*** Bug 394363 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 380437] Save does not work when I only change layer name

[Neviril]

https://bugs.kde.org/show_bug.cgi?id=380437

Neviril  changed:

   What|Removed |Added

 CC||nevinevi...@yahoo.com

--- Comment #3 from Neviril  ---
It might go slightly deeper than this. I noticed that not only these actions
don't "dirty" an image, but they also are not undoable:

- Layer name (renaming by double clicking or F2 key)
>From the right-click context menu on the layer boxes:
- Layer color 
- Isolate layer
- Show in timeline

Setting layer color and name with the Layer Properties dialog (F3 key) however
does "dirty" the image and is an undoable action.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 380437] Save does not work when I only change layer name

[Alvin Wong]

https://bugs.kde.org/show_bug.cgi?id=380437

Alvin Wong  changed:

   What|Removed |Added

   Platform|Windows CE  |MS Windows

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 380437] Save does not work when I only change layer name

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=380437

katearche...@yandex.ru changed:

   What|Removed |Added

 CC||katearche...@yandex.ru

--- Comment #2 from katearche...@yandex.ru ---
I confirm this, happens on win7 too. 

Krita doesn't change the modified status of a file(* symbol in the header of
the file/window) if only a layer name through the layer docker was changed and
thus not giving an option to save the file since it thinks nothing have
changed.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 380437] Save does not work when I only change layer name

[mvowada]

https://bugs.kde.org/show_bug.cgi?id=380437

mvowada  changed:

   What|Removed |Added

 Status|UNCONFIRMED |CONFIRMED
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 380437] Save does not work when I only change layer name

[mvowada]

https://bugs.kde.org/show_bug.cgi?id=380437

mvowada  changed:

   What|Removed |Added

 CC||freebo...@tiscali.it

--- Comment #1 from mvowada  ---
(This is on Ubuntu 14.04 with Krita 3.1.4 appimage). I think I can confirm this
behaviour with *.kra files too, in my case it happens whenever I change the
layer name without accessing the layer Property dialog (important).

Steps to reproduce:

- open an existing *.ora or *.kra file,
- change a layer name on the "Layers" docker just by double clicking on the
name (important)
- save the file (either by doing "CTRL+S" or by going to menu "File > Save")
- close and reopen.

Actual results: the file has not been saved, the layer name has not been saved.
Expected results: save the file even after changing the layer name without
accessing the Property dialog?

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 380437] Save does not work when I only change layer name

[Long Leaf's Friends]

https://bugs.kde.org/show_bug.cgi?id=380437

Long Leaf's Friends  changed:

   What|Removed |Added

   Severity|normal  |major

-- 
You are receiving this mail because:
You are watching all bug changes.