[krita] [Bug 385050] JJ: workflow improvement: create a group when several layers are selected and that user clicks on "add layer"

[Boudewijn Rempt]

https://bugs.kde.org/show_bug.cgi?id=385050

Boudewijn Rempt  changed:

   What|Removed |Added

  Latest Commit|https://commits.kde.org/kri |https://commits.kde.org/kri
   |ta/c7ddbf1a0145d1c9a1fea017 |ta/3cdbd97f494bca91e80dea65
   |78df709c508f7c80|fd3ef4f99dc4f38d

--- Comment #9 from Boudewijn Rempt  ---
Git commit 3cdbd97f494bca91e80dea65fd3ef4f99dc4f38d by Boudewijn Rempt, on
behalf of Seoras Macdonald.
Committed on 02/05/2018 at 11:54.
Pushed by rempt into branch 'krita/4.0'.

Change the behaviour of the add layer button

Summary:
In the layers docker, if more than 1 layer is selected, then
the add layer button now creates a quick group for the selected
layers.
Reviewers: #krita, rempt
Reviewed By: #krita, rempt
Subscribers: alvinhochun, woltherav
Tags: #krita
Differential Revision: https://phabricator.kde.org/D11507

(cherry picked from commit 77d75e3d811add37b909683d61ad8e779f8524e1)

M  +16   -1plugins/dockers/defaultdockers/kis_layer_box.cpp
M  +2-0plugins/dockers/defaultdockers/kis_layer_box.h

https://commits.kde.org/krita/3cdbd97f494bca91e80dea65fd3ef4f99dc4f38d

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 385050] JJ: workflow improvement: create a group when several layers are selected and that user clicks on "add layer"

[Dmitry Kazakov]

https://bugs.kde.org/show_bug.cgi?id=385050

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit||https://commits.kde.org/kri
   ||ta/c7ddbf1a0145d1c9a1fea017
   ||78df709c508f7c80
 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED

--- Comment #8 from Dmitry Kazakov  ---
Git commit c7ddbf1a0145d1c9a1fea01778df709c508f7c80 by Dmitry Kazakov, on
behalf of Seoras Macdonald.
Committed on 18/04/2018 at 08:48.
Pushed by dkazakov into branch 'master'.

Change the behaviour of the add layer button

Summary:
In the layers docker, if more than 1 layer is selected, then
the add layer button now creates a quick group for the selected
layers.
Reviewers: #krita, rempt
Reviewed By: #krita, rempt
Subscribers: alvinhochun, woltherav
Tags: #krita
Differential Revision: https://phabricator.kde.org/D11507

M  +16   -1plugins/dockers/defaultdockers/kis_layer_box.cpp
M  +2-0plugins/dockers/defaultdockers/kis_layer_box.h

https://commits.kde.org/krita/c7ddbf1a0145d1c9a1fea01778df709c508f7c80

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 385050] JJ: workflow improvement: create a group when several layers are selected and that user clicks on "add layer"

[Seoras Macdonald]

https://bugs.kde.org/show_bug.cgi?id=385050

Seoras Macdonald  changed:

   What|Removed |Added

 CC||seor...@gmail.com

--- Comment #7 from Seoras Macdonald  ---
Created attachment 111486
  --> https://bugs.kde.org/attachment.cgi?id=111486=edit
Proposed patch

Hi, I think I've got a working patch based on the previous patch attached by 
shubhamgoyal. This is my first time submitting a patch, so I'm not sure if this
is the most natural way to implement the feature though.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 385050] JJ: workflow improvement: create a group when several layers are selected and that user clicks on "add layer"

[Boudewijn Rempt]

https://bugs.kde.org/show_bug.cgi?id=385050

--- Comment #6 from Boudewijn Rempt  ---
You're creating a new action every time the button is clicked, instead of
triggering the action.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 385050] JJ: workflow improvement: create a group when several layers are selected and that user clicks on "add layer"

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=385050

simei...@gmail.com changed:

   What|Removed |Added

 CC|simei...@gmail.com  |

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 385050] JJ: workflow improvement: create a group when several layers are selected and that user clicks on "add layer"

[shubhamgoyal]

https://bugs.kde.org/show_bug.cgi?id=385050

shubhamgoyal <22shub...@gmail.com> changed:

   What|Removed |Added

 CC||22shub...@gmail.com

--- Comment #5 from shubhamgoyal <22shub...@gmail.com> ---
Created attachment 110480
  --> https://bugs.kde.org/attachment.cgi?id=110480=edit
file changed in kis_layer_box.cpp and kis_layer_box.h

What's the problem with the code. please explain.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 385050] JJ: workflow improvement: create a group when several layers are selected and that user clicks on "add layer"

[Łukasz Hryniuk]

https://bugs.kde.org/show_bug.cgi?id=385050

Łukasz Hryniuk  changed:

   What|Removed |Added

 CC||lukasz.hryn...@wp.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 385050] JJ: workflow improvement: create a group when several layers are selected and that user clicks on "add layer"

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=385050

simei...@gmail.com changed:

   What|Removed |Added

 CC||simei...@gmail.com

--- Comment #4 from simei...@gmail.com ---
(In reply to rishabh.chakrabarti from comment #2)
> Hi, can I take this up?

Hello, Rishabh. There hasn't been an update for a while, so I wonder how you
are making progress on this. If you are busy dealing with something else, I
want to take this up.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 385050] JJ: workflow improvement: create a group when several layers are selected and that user clicks on "add layer"

[Boudewijn Rempt]

https://bugs.kde.org/show_bug.cgi?id=385050

--- Comment #3 from Boudewijn Rempt  ---
Yes, sure! If you have questions, please join us on #krita on irc.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 385050] JJ: workflow improvement: create a group when several layers are selected and that user clicks on "add layer"

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=385050

rishabh.chakraba...@protonmail.com changed:

   What|Removed |Added

 CC||rishabh.chakrabarti@protonm
   ||ail.com

--- Comment #2 from rishabh.chakraba...@protonmail.com ---
Hi, can I take this up?

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 385050] JJ: workflow improvement: create a group when several layers are selected and that user clicks on "add layer"

[Boudewijn Rempt]

https://bugs.kde.org/show_bug.cgi?id=385050

Boudewijn Rempt  changed:

   What|Removed |Added

 CC||b...@valdyas.org
 Ever confirmed|0   |1
 Status|UNCONFIRMED |CONFIRMED
Summary|workflow improvement:   |JJ: workflow improvement:
   |create a group when several |create a group when several
   |layers are selected and |layers are selected and
   |that user clicks on "add|that user clicks on "add
   |layer"  |layer"
   Keywords||junior-jobs

--- Comment #1 from Boudewijn Rempt  ---
Yes, this is very sensible and should be really easy to implement. Confirming,
and setting to junior job. It would be perfect for a gsoc or sok student to get
started on.

-- 
You are receiving this mail because:
You are watching all bug changes.