[krita] [Bug 395774] Doesn't prompt to save KRA before Saving as PNG

2018-06-25 Thread vanyossi
https://bugs.kde.org/show_bug.cgi?id=395774

vanyossi  changed:

   What|Removed |Added

 CC||ghe...@gmail.com

--- Comment #6 from vanyossi  ---
This is probably one of the reasons GIMP made "Save" and "Save As" XCF
exclusive and other formats can only be saved using export. This made imposible
to loose work by not saving on this scenario of save/close.

It is confusing to have, after a Save As PNG, all layers and masks. It gives
the false idea that you are keeping your changes on every save. The warning can
be easily missed as the design is not very calling, far from the "ok" button,
and blended in the dialog.

Victor has made some good points. I think krita could protect the user a little
more on this. It is not that hard to forget on a work session that you changed
the format after a Save As, and on an act of carelessness close Krita only to
realize after closing that the last time saved was a png. It might not be that
common to report as normally the user takes the blame for it, or at least i
did.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 395774] Doesn't prompt to save KRA before Saving as PNG

2018-06-25 Thread Kenneth Evans
https://bugs.kde.org/show_bug.cgi?id=395774

--- Comment #5 from Kenneth Evans  ---
I tried export and that is probably what I should be using. I didn't realize
that, and was using what I would in other programs. Thanks.

I still think it should be fixed. Being warned about losing information is a
completely different thing. (I never even noticed that warning. It's very small
print on my computer.) Of course you lose information saving to PNG. That has
nothing to do with unsaved changes 

The point is I am losing unsaved changes in the KRA file and am never prompted
about that. That is a bad thing.

I may have missed all the items you mentioned. After all, had I been careful, I
would have saved anyway. I will not miss a prompt I have to respond to.

The steps in the message above is what has happened to me. If I had been more
alert I would have saved the KRA file anyway before saving the PNG and usually
do. The prompt prevents oversights and mistakes.

Note that you are leaving the KRA document and entering a completely different
document as it is implemented. Unsaved changes are lost. What more can I say.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 395774] Doesn't prompt to save KRA before Saving as PNG

2018-06-25 Thread Victor Wåhlström
https://bugs.kde.org/show_bug.cgi?id=395774

Victor Wåhlström  changed:

   What|Removed |Added

 CC||victor.wahlstrom@initiali.s
   ||e

--- Comment #4 from Victor Wåhlström  ---
While "Export" would avoid this problem entirely, I don't think the original
report is without merit.

I'm not sure everyone is aware of the difference between "Save As" and
"Export", and what they do exactly. Given that "Save As" is pretty consistent
across applications and "Export" might not even exist, it's easy to default to
the familiar "Save As" even though "Export" is what you want.

Since the data in the current session is not immediately lost when you save to
a different format, you can simply recover from a "Save As: PNG" situation by
using "Save As" again and save to KRA.

The real problem is that once you use "Save As", Krita clears the dirty state,
allowing for the following scenario:

1. Create a new document
2. Draw something
3. Save as KRA
4. Continue working
5. Save as PNG
6. Close Krita
7. Krita won't warn you about unsaved changes, discarding all work done in step
4.

Sure, you still have the PNG file, but that's missing a bunch of data.

One way to avoid this scenario is to have Krita keep track of the last time you
saved the current session as KRA, separately from the internal dirty state.
This way, Krita knows that there are "unsaved" changes when you close the
document, despite having just saved it to PNG.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 395774] Doesn't prompt to save KRA before Saving as PNG

2018-06-25 Thread Boudewijn Rempt
https://bugs.kde.org/show_bug.cgi?id=395774

--- Comment #3 from Boudewijn Rempt  ---
But Krita _already_ warns you if you're saving to a file format that will lose
information. If you don't read that warning, I don't think another warning will
help. 

And if you close krita and your work has unsaved changes, Krita already asks
you whether you want to save it; and if Krita warns that your chosen file
format will lose information, you can cancel and go back to your image.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 395774] Doesn't prompt to save KRA before Saving as PNG

2018-06-23 Thread Kenneth Evans
https://bugs.kde.org/show_bug.cgi?id=395774

--- Comment #2 from Kenneth Evans  ---
Thanks, I'll try export.

However I think this should be fixed. Having a check box in a dialog is a long
ways from prompting you for sure to not lose your work.

It is almost universal to ask to save before leaving unsaved work (for good
reason). Krita is not doing that in this case, and that makes it unfriendly.

And it isn't that hard to fix.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 395774] Doesn't prompt to save KRA before Saving as PNG

2018-06-23 Thread Boudewijn Rempt
https://bugs.kde.org/show_bug.cgi?id=395774

Boudewijn Rempt  changed:

   What|Removed |Added

 CC||b...@valdyas.org
 Resolution|--- |WORKSFORME
 Status|UNCONFIRMED |RESOLVED

--- Comment #1 from Boudewijn Rempt  ---
Export doesn't change the file type, so you probably want to use that. And
thesave as dialog already shows a checkbox you can use to save both as .png and
.kra.

-- 
You are receiving this mail because:
You are watching all bug changes.