[krita] [Bug 405494] Problems with Qt's Windows Ink implementation
https://bugs.kde.org/show_bug.cgi?id=405494 Dmitry Kazakov changed: What|Removed |Added Latest Commit||https://commits.kde.org/kri ||ta/13181cd88e1314b43fb48be4 ||ee2147e1e24129a4 Resolution|--- |FIXED Status|CONFIRMED |RESOLVED --- Comment #19 from Dmitry Kazakov --- Git commit 13181cd88e1314b43fb48be4ee2147e1e24129a4 by Dmitry Kazakov. Committed on 03/04/2019 at 15:53. Pushed by dkazakov into branch 'master'. Implement a switch for Tablet API in Qt The patch allows switching of the Tablet API when we use Qt's own implementation. The patch is added to our build system, so the fix should appear in nightlies very soon. The patch has also been proposed to Qt: https://codereview.qt-project.org/#/c/258067/ A +73 -0 3rdparty/ext_qt/0023-Implement-a-switch-for-tablet-API-on-Windows.patch M +1-03rdparty/ext_qt/CMakeLists.txt M +15 -0CMakeLists.txt M +1-0config_use_qt_tablet_windows.h.cmake M +14 -0krita/main.cc M +25 -14 libs/ui/dialogs/kis_dlg_preferences.cc M +32 -1libs/ui/kis_config.cc M +4-1libs/ui/kis_config.h https://commits.kde.org/krita/13181cd88e1314b43fb48be4ee2147e1e24129a4 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 405494] Problems with Qt's Windows Ink implementation
https://bugs.kde.org/show_bug.cgi?id=405494 --- Comment #18 from Boudewijn Rempt --- Test with build https://binary-factory.kde.org/job/Krita_Nightly_Windows_Build/512 (no windows ink switch in the settings dialog, so this really is with Qt's tablet code): * Yoga: everything works as expected. * MSP: with windows ink enabled, works like on the yoga. Unless with the build I tested yesterday, setting the top barrel button to middle click doesn't do anything. If that works with our winink implementation, that could be another bug in Qt's? With WinInk disabled, nothing works. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 405494] Problems with Qt's Windows Ink implementation
https://bugs.kde.org/show_bug.cgi?id=405494 Boudewijn Rempt changed: What|Removed |Added CC||dimul...@gmail.com --- Comment #17 from Boudewijn Rempt --- Note: for some reason the top part of the rocker switch gets redefined to double-click when you switch the wacom driver to windows ink. It can be sett to middle-click, and then panning works again. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 405494] Problems with Qt's Windows Ink implementation
https://bugs.kde.org/show_bug.cgi?id=405494 --- Comment #16 from Boudewijn Rempt --- Build https://binary-factory.kde.org/job/Krita_Nightly_Windows_Build/511/ properly disabled our own wintab/winink implementation and enables Qt's implementation. On the Yoga 920 with wacom that only supports windows pointer api, everything works as expected: pressure, eraser barrel button, right-click barrel button. On the Wacom Mobile Studio Pro, if windows ink is selected in the calibration panel, the eraser end works, the right-click barrel button works, the middle-click barrel button does not work, pressure wors. If the windows ink checkbox is disabled, nothing works (probably as expected, because the Windows Pointer API is present, so qt doesn't fall through to Wintab, because Qt seems to believe that Wintab was obsoleted with Windows 8). -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 405494] Problems with Qt's Windows Ink implementation
https://bugs.kde.org/show_bug.cgi?id=405494 Alvin Wong changed: What|Removed |Added URL||https://bugreports.qt.io/br ||owse/QTBUG-74700 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 405494] Problems with Qt's Windows Ink implementation
https://bugs.kde.org/show_bug.cgi?id=405494 --- Comment #15 from Boudewijn Rempt --- Yes, Krita stores a preset per unique id: https://doc.qt.io/qt-5/qtabletevent.html#uniqueId -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 405494] Problems with Qt's Windows Ink implementation
https://bugs.kde.org/show_bug.cgi?id=405494 --- Comment #14 from Alvin Wong --- (In reply to Boudewijn Rempt from comment #13) > Created attachment 118923 [details] > Tablet log with Windows Ink enabled in Wacom driver and Qt 5.12.2 > > After selecting a preset and returning the stylus to the canvas, the preset > resets to the default one. It looks like Qt generated a new stylus ID when the pen left and entered proximity, or perhaps it is using `POINTER_INFO::pointerId` (haven't checked the code). My implementation used `POINTER_INFO::sourceDevice` instead, assuming one pen per digitizer (I don't remember if this is guaranteed). If Krita associates a preset per ID, this would be why. POINTER_INFO: https://docs.microsoft.com/en-us/windows/desktop/api/winuser/ns-winuser-tagpointer_info -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 405494] Problems with Qt's Windows Ink implementation
https://bugs.kde.org/show_bug.cgi?id=405494 --- Comment #13 from Boudewijn Rempt --- Created attachment 118923 --> https://bugs.kde.org/attachment.cgi?id=118923=edit Tablet log with Windows Ink enabled in Wacom driver and Qt 5.12.2 After selecting a preset and returning the stylus to the canvas, the preset resets to the default one. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 405494] Problems with Qt's Windows Ink implementation
https://bugs.kde.org/show_bug.cgi?id=405494 --- Comment #12 from Boudewijn Rempt --- Okay, with 5.12.2 and our patch to disable wintab disabled, wintab still doesn't work. Windows Ink still is broken: it keeps reverting to the default preset. I'll try to disable both Qt's tablet implementations and revert to ours. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 405494] Problems with Qt's Windows Ink implementation
https://bugs.kde.org/show_bug.cgi?id=405494 Boudewijn Rempt changed: What|Removed |Added CC||nikola.knezevic.mne@gmail.c ||om --- Comment #11 from Boudewijn Rempt --- *** Bug 405576 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 405494] Problems with Qt's Windows Ink implementation
https://bugs.kde.org/show_bug.cgi?id=405494 --- Comment #10 from Boudewijn Rempt --- I'll first update Qt to 5.12.2, do a deps build and nightly build and test that. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 405494] Problems with Qt's Windows Ink implementation
https://bugs.kde.org/show_bug.cgi?id=405494 Alvin Wong changed: What|Removed |Added CC||alvinhoc...@gmail.com --- Comment #9 from Alvin Wong --- If you would disable the Qt's pointer input messages support, I suggest doing so with Qt 5.12.2 since it contains this commit: https://github.com/qt/qtbase/commit/38504041148f2d1cffea6520ea448dd4171adb0b Before this commit, Qt also uses pointer input messages for mouse events. Though I suspect you might be able to just completely disable pointer messages support in Qt by hacking `QWindowsContext::user32dll.supportsPointerApi()` to return `false`, regardless of whether that commit is included or not. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 405494] Problems with Qt's Windows Ink implementation
https://bugs.kde.org/show_bug.cgi?id=405494 Boudewijn Rempt changed: What|Removed |Added Assignee|dimul...@gmail.com |krita-bugs-n...@kde.org -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 405494] Problems with Qt's Windows Ink implementation
https://bugs.kde.org/show_bug.cgi?id=405494 --- Comment #8 from Boudewijn Rempt --- Created attachment 118838 --> https://bugs.kde.org/attachment.cgi?id=118838=edit mobile studio pro, windows ink disabled, no pressure -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 405494] Problems with Qt's Windows Ink implementation
https://bugs.kde.org/show_bug.cgi?id=405494 --- Comment #7 from Boudewijn Rempt --- Created attachment 118837 --> https://bugs.kde.org/attachment.cgi?id=118837=edit mobile studio pro, windows ink enabled Some lines drawn, attempt to change the preset -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 405494] Problems with Qt's Windows Ink implementation
https://bugs.kde.org/show_bug.cgi?id=405494 --- Comment #6 from Boudewijn Rempt --- On the MSP, if Windows ink is disabled in the settings, there is no pressure support. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 405494] Problems with Qt's Windows Ink implementation
https://bugs.kde.org/show_bug.cgi?id=405494 Boudewijn Rempt changed: What|Removed |Added Status|REPORTED|CONFIRMED Ever confirmed|0 |1 --- Comment #5 from Boudewijn Rempt --- ** WIth the Yoga, the brush editor works find and doesn't popup all the time, there is no forbidden icon shown when approaching the tablet, but the stylus gets reset to the default all the time. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 405494] Problems with Qt's Windows Ink implementation
https://bugs.kde.org/show_bug.cgi?id=405494 Boudewijn Rempt changed: What|Removed |Added Summary|Stylus input broken on Yoga |Problems with Qt's Windows |920 with Windows 10 |Ink implementation --- Comment #4 from Boudewijn Rempt --- Notes: * We've now got a build option to disable our own tablet implementations * When testing a build with this, on the Wacom Mobile Studio I find: ** If windows ink is enabled in the Wacom driver, the selected preset keeps returning to Basic 5, there is a forbidden cursor shown for a short while when approaching the tablet, editing brushes in the brush editor doesn't work intermittently, after opening the brush editor, it tends to popup again when clicking on the canvas. Driver version 6.3.33-3. ** With the Wacom Hybrid Companion, disabling Windows Ink in the wacom driver disables pen input completely. Enabling it enables pen input, without any of the problems reported for the MSP. Driver version 6.3.33-3. -- You are receiving this mail because: You are watching all bug changes.
