[krita] [Bug 405643] Feature request: circle in a square assistant tool
https://bugs.kde.org/show_bug.cgi?id=405643 --- Comment #10 from Halla Rempt --- Git commit 01ade4920b8cf03feee12490bf5b4d5355732c8b by Halla Rempt, on behalf of Agata Cacko. Committed on 26/05/2022 at 09:30. Pushed by rempt into branch 'master'. Fix Ellipse in Perspective calculations Fix ellipse calculations and formulas and clean up the code. After this commit, the ellipse in perspective assistant works as expected. M +128 -29 libs/global/kis_algebra_2d.cpp M +15 -0libs/global/kis_algebra_2d.h M +18 -0libs/image/tests/kis_algebra_2d_test.cpp M +1-0libs/image/tests/kis_algebra_2d_test.h M +408 -227 plugins/assistants/Assistants/PerspectiveEllipseAssistant.cc M +15 -9plugins/assistants/Assistants/PerspectiveEllipseAssistant.h https://invent.kde.org/graphics/krita/commit/01ade4920b8cf03feee12490bf5b4d5355732c8b -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 405643] Feature request: circle in a square assistant tool
https://bugs.kde.org/show_bug.cgi?id=405643 Halla Rempt changed: What|Removed |Added Resolution|--- |FIXED Latest Commit||https://invent.kde.org/grap ||hics/krita/commit/35f3f6644 ||4c39ceb7c227b545fccaea6164b ||4fb9 Status|CONFIRMED |RESOLVED --- Comment #9 from Halla Rempt --- Git commit 35f3f66444c39ceb7c227b545fccaea6164b4fb9 by Halla Rempt, on behalf of Srirupa Datta. Committed on 26/05/2022 at 09:30. Pushed by rempt into branch 'master'. Add Perspective Ellipse Assistant Tool This assistant is meant to help create an ellipse within a quadrilateral (tetragon). It helps the user to draw circles in perspective. The assistant draws the vanishing points that fit that perspective. This commit however doesn't have correct calculations, so the end result assistant doesn't work properly. M +6-0libs/ui/kis_painting_assistant.cc M +1-0plugins/assistants/Assistants/CMakeLists.txt A +509 -0plugins/assistants/Assistants/PerspectiveEllipseAssistant.cc * A +70 -0plugins/assistants/Assistants/PerspectiveEllipseAssistant.h * M +2-0plugins/assistants/Assistants/assistant_tool.cc M +5-1plugins/impex/libkra/kis_kra_saver.cpp The files marked with a * at the end have a non valid license. Please read: https://community.kde.org/Policies/Licensing_Policy and use the headers which are listed at that page. https://invent.kde.org/graphics/krita/commit/35f3f66444c39ceb7c227b545fccaea6164b4fb9 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 405643] Feature request: circle in a square assistant tool
https://bugs.kde.org/show_bug.cgi?id=405643 --- Comment #8 from Srirupa Datta --- (In reply to Hector from comment #7) > (In reply to Srirupa Datta from comment #6) > > anyone available to mentor this project? > I am not a mentor, but i can be your tester for this. If you need That would great, let me see if someone on #krita is willing to mentor this project as having a mentor is compulsory for SoK. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 405643] Feature request: circle in a square assistant tool
https://bugs.kde.org/show_bug.cgi?id=405643 --- Comment #7 from Hector --- (In reply to Srirupa Datta from comment #6) > anyone available to mentor this project? I am not a mentor, but i can be your tester for this. If you need -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 405643] Feature request: circle in a square assistant tool
https://bugs.kde.org/show_bug.cgi?id=405643 Srirupa Datta changed: What|Removed |Added CC||srirupa@gmail.com --- Comment #6 from Srirupa Datta --- (In reply to wolthera from comment #3) > Alright, it doesn't seem to complex to implement, but someone needs to find > time first ;) > > WISHGROUP: Larger Usability Fixes I was thinking about implementing this as part of Season of KDE 2022, is anyone available to mentor this project? -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 405643] Feature request: circle in a square assistant tool
https://bugs.kde.org/show_bug.cgi?id=405643 stephen changed: What|Removed |Added CC||tgdev...@gmail.com --- Comment #5 from stephen --- (In reply to wolthera from comment #1) > Okay, so what you effectively want is a readjustable 4 corner mesh that > always has a circle inside it which touch the sides? (In reply to Hector from comment #4) > Created attachment 122943 [details] > from getleonardo.com Greetings. Here's an article with demo showing another use case of the feature : having it in perspective and move it according to distance in space. You might take a look. https://lazynezumi.com/perspectiveEllipse -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 405643] Feature request: circle in a square assistant tool
https://bugs.kde.org/show_bug.cgi?id=405643 maxmustermann1...@web.de changed: What|Removed |Added CC||maxmustermann1...@web.de -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 405643] Feature request: circle in a square assistant tool
https://bugs.kde.org/show_bug.cgi?id=405643 --- Comment #4 from Hector --- Created attachment 122943 --> https://bugs.kde.org/attachment.cgi?id=122943=edit from getleonardo.com -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 405643] Feature request: circle in a square assistant tool
https://bugs.kde.org/show_bug.cgi?id=405643 wolthera changed: What|Removed |Added Keywords||triaged Ever confirmed|0 |1 Status|REPORTED|CONFIRMED --- Comment #3 from wolthera --- Alright, it doesn't seem to complex to implement, but someone needs to find time first ;) WISHGROUP: Larger Usability Fixes -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 405643] Feature request: circle in a square assistant tool
https://bugs.kde.org/show_bug.cgi?id=405643 --- Comment #2 from Hector --- (In reply to wolthera from comment #1) > a readjustable 4 corner mesh that always has a circle inside Yes it is. This is the simplest method of drawing an ellipse in perspective. We draw a square, and in it we draw a circle. The circle touches the midpoints of the sides of the square. It is easy to draw a square in perspective, but it takes too much time to set a concentric ellipse tool. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 405643] Feature request: circle in a square assistant tool
https://bugs.kde.org/show_bug.cgi?id=405643 wolthera changed: What|Removed |Added CC||griffinval...@gmail.com --- Comment #1 from wolthera --- Okay, so what you effectively want is a readjustable 4 corner mesh that always has a circle inside it which touch the sides? -- You are receiving this mail because: You are watching all bug changes.
