[krita] [Bug 416892] Contiguous Selection Tool behavior

2020-06-12 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=416892

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/krita/commit/0e28b2a36 |hics/krita/commit/733a9480f
   |ba79805330c0f66d1bf5058a437 |bdc0c334407d8184f09d251485c
   |ddf2|17ca

--- Comment #4 from Dmitry Kazakov  ---
Git commit 733a9480fbdc0c334407d8184f09d251485c17ca by Dmitry Kazakov.
Committed on 12/06/2020 at 18:15.
Pushed by dkazakov into branch 'master'.

Fix KoColorSpace::differenceA() handle fully transparent pixels properly

If the pixel is fully transparent, then it is treated as if its color
channels would be the same as ones of the other pixel. It fixes the
problem of calculating threshold of flood fill tools.

M  +2-2libs/image/floodfill/kis_scanline_fill.cpp
M  +7-0libs/pigment/KoColorSpace.h
M  +4-1plugins/color/lcms2engine/LcmsColorSpace.h

https://invent.kde.org/graphics/krita/commit/733a9480fbdc0c334407d8184f09d251485c17ca

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 416892] Contiguous Selection Tool behavior

2020-06-12 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=416892

Dmitry Kazakov  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
  Latest Commit||https://invent.kde.org/grap
   ||hics/krita/commit/0e28b2a36
   ||ba79805330c0f66d1bf5058a437
   ||ddf2
 Resolution|--- |FIXED

--- Comment #3 from Dmitry Kazakov  ---
Git commit 0e28b2a36ba79805330c0f66d1bf5058a437ddf2 by Dmitry Kazakov.
Committed on 12/06/2020 at 18:14.
Pushed by dkazakov into branch 'krita/4.3'.

Fix KoColorSpace::differenceA() handle fully transparent pixels properly

If the pixel is fully transparent, then it is treated as if its color
channels would be the same as ones of the other pixel. It fixes the
problem of calculating threshold of flood fill tools.

M  +2-2libs/image/floodfill/kis_scanline_fill.cpp
M  +7-0libs/pigment/KoColorSpace.h
M  +4-1plugins/color/lcms2engine/LcmsColorSpace.h

https://invent.kde.org/graphics/krita/commit/0e28b2a36ba79805330c0f66d1bf5058a437ddf2

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 416892] Contiguous Selection Tool behavior

2020-06-03 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=416892

Dmitry Kazakov  changed:

   What|Removed |Added

   Assignee|krita-bugs-n...@kde.org |dimul...@gmail.com
 CC||dimul...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 416892] Contiguous Selection Tool behavior

2020-01-29 Thread Ahab Greybeard
https://bugs.kde.org/show_bug.cgi?id=416892

Ahab Greybeard  changed:

   What|Removed |Added

 Status|REPORTED|CONFIRMED
 Ever confirmed|0   |1
 CC||ahab.greybe...@hotmail.co.u
   ||k

--- Comment #2 from Ahab Greybeard  ---
I can confirm this for the Jan 28th 4.3.0 prealpha appimage git(049dd11)

The contiguous selection tool and the similar colour selection tool both do a
binary (alpha equals 0  or alpha not equal to 0) selection with a gradient on a
transparent background.

For the contiguous selection tool, a workaround for this is to put a
contrasting solid colour layer under the gradient-on-transparent layer and then
use the tool with limit to current layer turned off.

That workaround does not work for the similar colour selector tool. You have to
merge a copy of the gradient with a contrasting filled layer and use it on that
to get a selection that is correct and controllable.

There have been other previous concerns about how pixels with alpha less than 1
are treated so this may be one of those situations.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 416892] Contiguous Selection Tool behavior

2020-01-28 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=416892

--- Comment #1 from acc4commissi...@gmail.com ---
The most pesky problem is that I can't ignore very light and pale pixels by
changing the fuzziness. When I click the transparent area of the layer, the
detection seems to become binary, and it only select pixels that is
'completely' transparent.

-- 
You are receiving this mail because:
You are watching all bug changes.