[krita] [Bug 417673] Visible tiling artifacts from Filter Masks
https://bugs.kde.org/show_bug.cgi?id=417673 Dmitry Kazakov changed: What|Removed |Added Latest Commit|https://invent.kde.org/kde/ |https://invent.kde.org/kde/ |krita/commit/8157bb3ce895c9 |krita/commit/816f481095d920 |3585449e871821bddd87570484 |607e6196250f6c9795ef024592 --- Comment #8 from Dmitry Kazakov --- Git commit 816f481095d920607e6196250f6c9795ef024592 by Dmitry Kazakov. Committed on 25/02/2020 at 11:39. Pushed by dkazakov into branch 'krita/4.2'. Fix artifacts on filter masks applied to adjustment layers It looks like there was just a misprint in the way how need rect is calculated. M +2-2libs/image/kis_adjustment_layer.cc M +6-0libs/image/kis_image_config.cpp M +2-0libs/image/kis_image_config.h A +---libs/image/tests/data/async_merger_test/mask_on_adj_initial.png M +61 -0libs/image/tests/kis_async_merger_test.cpp M +4-0libs/image/tests/kis_async_merger_test.h https://invent.kde.org/kde/krita/commit/816f481095d920607e6196250f6c9795ef024592 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 417673] Visible tiling artifacts from Filter Masks
https://bugs.kde.org/show_bug.cgi?id=417673 Dmitry Kazakov changed: What|Removed |Added Resolution|--- |FIXED Status|CONFIRMED |RESOLVED Latest Commit||https://invent.kde.org/kde/ ||krita/commit/8157bb3ce895c9 ||3585449e871821bddd87570484 --- Comment #7 from Dmitry Kazakov --- Git commit 8157bb3ce895c93585449e871821bddd87570484 by Dmitry Kazakov. Committed on 25/02/2020 at 11:36. Pushed by dkazakov into branch 'master'. Fix artifacts on filter masks applied to adjustment layers It looks like there was just a misprint in the way how need rect is calculated. M +2-2libs/image/kis_adjustment_layer.cc M +6-0libs/image/kis_image_config.cpp M +2-0libs/image/kis_image_config.h A +---libs/image/tests/data/async_merger_test/mask_on_adj_initial.png M +61 -0libs/image/tests/kis_async_merger_test.cpp M +4-0libs/image/tests/kis_async_merger_test.h https://invent.kde.org/kde/krita/commit/8157bb3ce895c93585449e871821bddd87570484 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 417673] Visible tiling artifacts from Filter Masks
https://bugs.kde.org/show_bug.cgi?id=417673 --- Comment #6 from Dmitry Kazakov --- Okay, the problem happens because "Motion Blur" mask is applied to a "Filter Layer" with color balance filter attached. I don't think such combination has ever been tested :) Though it should be fixed, yes. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 417673] Visible tiling artifacts from Filter Masks
https://bugs.kde.org/show_bug.cgi?id=417673 --- Comment #5 from Dmitry Kazakov --- Okay, since there is no crash it is not a release blocker :) -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 417673] Visible tiling artifacts from Filter Masks
https://bugs.kde.org/show_bug.cgi?id=417673 --- Comment #4 from M --- No, I can't reproduce the crash in master (git 9643b51) nor the latest stable AppImage anymore, with any of the filters. I realize now Gaussian Highpass isn't actually supposed to be in 4.2, it might have been residue from previous builds since I didn't do a clean one. In which case sorry for the false alarm :( -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 417673] Visible tiling artifacts from Filter Masks
https://bugs.kde.org/show_bug.cgi?id=417673 Boudewijn Rempt changed: What|Removed |Added CC||b...@valdyas.org Status|REPORTED|CONFIRMED Ever confirmed|0 |1 --- Comment #3 from Boudewijn Rempt --- Hi, If you have the crash still now Dmitry's branch has been merged, please make a separate bug for that. I can confirm the artefacts. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 417673] Visible tiling artifacts from Filter Masks
https://bugs.kde.org/show_bug.cgi?id=417673 Dmitry Kazakov changed: What|Removed |Added Assignee|krita-bugs-n...@kde.org |dimul...@gmail.com CC||dimul...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 417673] Visible tiling artifacts from Filter Masks
https://bugs.kde.org/show_bug.cgi?id=417673 --- Comment #2 from M --- Created attachment 126044 --> https://bugs.kde.org/attachment.cgi?id=126044=edit GDB backtrace I can consistently provoke a crash on the build from Dmitry's branch, by adding a Filter Layer to the example document and choosing Gaussian Highpass. Doesn't seem to crash on 4.2.8 or most recent Next AppImage. I'll attach my backtrace. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 417673] Visible tiling artifacts from Filter Masks
https://bugs.kde.org/show_bug.cgi?id=417673 --- Comment #1 from M --- Created attachment 126043 --> https://bugs.kde.org/attachment.cgi?id=126043=edit Example document -- You are receiving this mail because: You are watching all bug changes.