[krita] [Bug 429371] Impossible to assign tag to a brush in master

2021-03-25 Thread Halla Rempt
https://bugs.kde.org/show_bug.cgi?id=429371

Halla Rempt  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED

--- Comment #7 from Halla Rempt  ---
This works in 2f3e11e435

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 429371] Impossible to assign tag to a brush in master

2020-11-27 Thread Dmitrii Utkin
https://bugs.kde.org/show_bug.cgi?id=429371

--- Comment #6 from Dmitrii Utkin  ---
Sorry for bothering, I forgot to mention that crash with switching presets by
'/' is only reproducing when any Brush preset in exception to "All" and "All
Untagged" is active.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 429371] Impossible to assign tag to a brush in master

2020-11-25 Thread Boudewijn Rempt
https://bugs.kde.org/show_bug.cgi?id=429371

--- Comment #5 from Boudewijn Rempt  ---
Yes, I haven't fixed this yet... I've started working on it, but until the bug
is marked as resolved, you don't have to tell me that you can still reproduce
it.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 429371] Impossible to assign tag to a brush in master

2020-11-25 Thread Vladimir Savic
https://bugs.kde.org/show_bug.cgi?id=429371

--- Comment #4 from Vladimir Savic  ---
I'm still able to reproduce. :/

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 429371] Impossible to assign tag to a brush in master

2020-11-24 Thread Dmitrii Utkin
https://bugs.kde.org/show_bug.cgi?id=429371

--- Comment #3 from Dmitrii Utkin  ---
Created attachment 133615
  --> https://bugs.kde.org/attachment.cgi?id=133615=edit
GDB stack trace of Crash log on pressing '/'

After the last change Krita started crashing on pressing the '/' key (previous
preset).

To reproduce click on one brush, then on another and press '/'.

Sorry, I can't attach better stacktrace.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 429371] Impossible to assign tag to a brush in master

2020-11-24 Thread Boudewijn Rempt
https://bugs.kde.org/show_bug.cgi?id=429371

--- Comment #2 from Boudewijn Rempt  ---
Git commit bde4d15a9869e84aaaef8466db42a4a7f8f9204b by Boudewijn Rempt.
Committed on 24/11/2020 at 10:23.
Pushed by rempt into branch 'master'.

Remove the extra filter model for the preset chooser

M  +20   -2libs/resources/KisTagFilterResourceProxyModel.cpp
M  +11   -3libs/resources/KisTagFilterResourceProxyModel.h
M  +10   -17   libs/resourcewidgets/KisResourceItemChooser.cpp
M  +4-1libs/resourcewidgets/KisResourceItemChooser.h
M  +17   -148  libs/ui/widgets/kis_preset_chooser.cpp

https://invent.kde.org/graphics/krita/commit/bde4d15a9869e84aaaef8466db42a4a7f8f9204b

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 429371] Impossible to assign tag to a brush in master

2020-11-24 Thread Boudewijn Rempt
https://bugs.kde.org/show_bug.cgi?id=429371

Boudewijn Rempt  changed:

   What|Removed |Added

 Status|REPORTED|ASSIGNED
 CC||b...@valdyas.org
   Assignee|krita-bugs-n...@kde.org |b...@valdyas.org
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 429371] Impossible to assign tag to a brush in master

2020-11-23 Thread Dmitrii Utkin
https://bugs.kde.org/show_bug.cgi?id=429371

Dmitrii Utkin  changed:

   What|Removed |Added

 CC||loen...@gmail.com

--- Comment #1 from Dmitrii Utkin  ---
This bug is reproducible for me either and it appear like regress for me.

Here are some additions:

1. Active brush TAG is is not preserved between Krita restarts. It always set
to "All" on startup (regress)

2. When switching brushes with "Switch to previous preset" selected brush in
Brush preset docker remain unchanged (regress)

3. Adding a new tag to the brush from preset doesn't add it to the tag until
Krita is restarted, it's just visually switches to the target tag but the brush
doesn't appear there. (regress)

Moreover on this I'm not sure if switching to the selected tag is a good idea,
it's very inconvenient to add multiple brushes to single tag -- you have to
switch to the previous tag and scroll down to the brush again.

In conjunction to the "Could not synchronize with the database" bug this makes
the custom tags fully unusable.

-- 
You are receiving this mail because:
You are watching all bug changes.