[krita] [Bug 447599] Crash with: trim to selection > and then switch to a previous snapshot which had an hidden Fill Pattern Layer below a visible layer
https://bugs.kde.org/show_bug.cgi?id=447599 Dmitry Kazakov changed: What|Removed |Added Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap |hics/krita/commit/3ce8590a9 |hics/krita/commit/71a2438ef |4407ea17a6f3ce8d2772ea8a7e8 |2a41f9aa81710009247becde875 |6075|c897 --- Comment #7 from Dmitry Kazakov --- Git commit 71a2438ef2a41f9aa81710009247becde875c897 by Dmitry Kazakov. Committed on 05/01/2022 at 10:42. Pushed by dkazakov into branch 'krita/5.0'. Fix a crash when switching to a snapshot with fill layers We should replace the root before amitting any signals, because some of the layers may be subscribed to sigSizeChanged() signal (e.g. KisSelectionBasedLayer). So the old layers should be fully detached before we actually emit this signal. We should also explicitly detach the old root from the image to make sure it doesn't react on the new signals. (cherry picked from commit 3ce8590a94407ea17a6f3ce8d2772ea8a7e86075) M +24 -7libs/image/kis_image.cc M +7-2libs/image/kis_selection_based_layer.cpp https://invent.kde.org/graphics/krita/commit/71a2438ef2a41f9aa81710009247becde875c897 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 447599] Crash with: trim to selection > and then switch to a previous snapshot which had an hidden Fill Pattern Layer below a visible layer
https://bugs.kde.org/show_bug.cgi?id=447599 Dmitry Kazakov changed: What|Removed |Added Latest Commit||https://invent.kde.org/grap ||hics/krita/commit/3ce8590a9 ||4407ea17a6f3ce8d2772ea8a7e8 ||6075 Resolution|--- |FIXED Status|ASSIGNED|RESOLVED --- Comment #6 from Dmitry Kazakov --- Git commit 3ce8590a94407ea17a6f3ce8d2772ea8a7e86075 by Dmitry Kazakov. Committed on 05/01/2022 at 10:38. Pushed by dkazakov into branch 'master'. Fix a crash when switching to a snapshot with fill layers We should replace the root before amitting any signals, because some of the layers may be subscribed to sigSizeChanged() signal (e.g. KisSelectionBasedLayer). So the old layers should be fully detached before we actually emit this signal. We should also explicitly detach the old root from the image to make sure it doesn't react on the new signals. M +24 -7libs/image/kis_image.cc M +7-2libs/image/kis_selection_based_layer.cpp https://invent.kde.org/graphics/krita/commit/3ce8590a94407ea17a6f3ce8d2772ea8a7e86075 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 447599] Crash with: trim to selection > and then switch to a previous snapshot which had an hidden Fill Pattern Layer below a visible layer
https://bugs.kde.org/show_bug.cgi?id=447599 Dmitry Kazakov changed: What|Removed |Added Status|REPORTED|ASSIGNED Ever confirmed|0 |1 --- Comment #5 from Dmitry Kazakov --- I can reproduce this issue. I'll try to fix it soon -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 447599] Crash with: trim to selection > and then switch to a previous snapshot which had an hidden Fill Pattern Layer below a visible layer
https://bugs.kde.org/show_bug.cgi?id=447599 Dmitry Kazakov changed: What|Removed |Added Assignee|krita-bugs-n...@kde.org |dimul...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 447599] Crash with: trim to selection > and then switch to a previous snapshot which had an hidden Fill Pattern Layer below a visible layer
https://bugs.kde.org/show_bug.cgi?id=447599 --- Comment #4 from mvowada --- (changed the title a bit) -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 447599] Crash with: trim to selection > and then switch to a previous snapshot which had an hidden Fill Pattern Layer below a visible layer
https://bugs.kde.org/show_bug.cgi?id=447599 mvowada changed: What|Removed |Added Summary|Crash with: trim to |Crash with: trim to |selection > and then switch |selection > and then switch |to a previous snapshot |to a previous snapshot |which had an hidden Fill|which had an hidden Fill |Pattern Layer below a |Pattern Layer below a |visible Layer |visible layer -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 447599] Crash with: trim to selection > and then switch to a previous snapshot which had an hidden Fill Pattern Layer below a visible Layer
https://bugs.kde.org/show_bug.cgi?id=447599 mvowada changed: What|Removed |Added Resolution|WAITINGFORINFO |--- Summary|Crash with: trim to |Crash with: trim to |selection > and then switch |selection > and then switch |to a previous snapshot |to a previous snapshot |which had an hidden Fill|which had an hidden Fill |Pattern Layer right below a |Pattern Layer below a |visible Fill Color Layer|visible Layer Status|NEEDSINFO |REPORTED -- You are receiving this mail because: You are watching all bug changes.
