[krita] [Bug 447853] 5.0.0 Popup Palette brush options panel, new item "LightnessStrength" is not implemented

2022-01-08 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=447853

amyspark  changed:

   What|Removed |Added

 Resolution|--- |NOT A BUG
 Status|REPORTED|RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 447853] 5.0.0 Popup Palette brush options panel, new item "LightnessStrength" is not implemented

2022-01-07 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=447853

Bug Janitor Service  changed:

   What|Removed |Added

 Status|NEEDSINFO   |REPORTED
 Resolution|WAITINGFORINFO  |---
 Ever confirmed|1   |0

--- Comment #5 from Bug Janitor Service  ---
Thanks for your comment!

Automatically switching the status of this bug to REPORTED so that the KDE team
knows that the bug is ready to get confirmed.

In the future you may also do this yourself when providing needed information.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 447853] 5.0.0 Popup Palette brush options panel, new item "LightnessStrength" is not implemented

2022-01-07 Thread Ahab Greybeard
https://bugs.kde.org/show_bug.cgi?id=447853

--- Comment #4 from Ahab Greybeard  ---
It's clear to me that I don't know enough about this to ask for any change
related to it.
I'll leave it to Amyspark or Dmitry (or anybody else) to do whatever they think
should be done with this bug report.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 447853] 5.0.0 Popup Palette brush options panel, new item "LightnessStrength" is not implemented

2022-01-07 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=447853

Dmitry Kazakov  changed:

   What|Removed |Added

 CC||dimul...@gmail.com

--- Comment #3 from Dmitry Kazakov  ---
Hi, Amyspark and Ahab!

That is kind of "intentional" behavior. The HUD shows properties for the brush
only in case it has been enabled in the brush editor. The same UIX works for
several properties in the colorsmudge engine: "Smudge Radius" and "Color Rate".
t
There are two reasons for this behavior choice:

1) Even if we show this slider in the GUI, the HUD will not have a control to
**enable** this option. Basically, HUD has no built-in control for "a checkbox
+ a slider". It can only show either a checkbox **or** a slider. We can
implement that, but I'm not sure about that because of the next point...
2) The HUD was intended not to be cluttered by lots of unused options. We don't
want it to become a department of the brush editor :)

To sum up, the current behavior is intention and works correctly. If you want
to change this behavior, it is okay, but we need a proper discussion of it.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 447853] 5.0.0 Popup Palette brush options panel, new item "LightnessStrength" is not implemented

2022-01-06 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=447853

amyspark  changed:

   What|Removed |Added

 Status|ASSIGNED|NEEDSINFO
 CC||ha...@valdyas.org
 Resolution|--- |WAITINGFORINFO

--- Comment #2 from amyspark  ---
There are two considerations here:

- Lightness Strength does not require the "Lightness" mode, but rather a RGBA
brush tip. This was somehow lost in
https://invent.kde.org/graphics/krita/commit/0395e4e7f16015ae3ae248943ee6a6a3bf3d100f
. The check is in KisBrushOpSettingsWidget::notifyPageChanged, and
KisBrush::preserveLightness(). Tested it with a the Bristles-2 Flat Rough brush
with the Craig 02 tip.

- Even if the property is added to the HUD, if the brush doesn't already
include it, it must be first enabled in the Brush Editor before it's usable.

Not sure if this is a bug or intended, so ccing Halla for a determination.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 447853] 5.0.0 Popup Palette brush options panel, new item "LightnessStrength" is not implemented

2022-01-03 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=447853

amyspark  changed:

   What|Removed |Added

 Status|REPORTED|ASSIGNED
 Ever confirmed|0   |1
 CC||a...@amyspark.me
   Assignee|krita-bugs-n...@kde.org |a...@amyspark.me

--- Comment #1 from amyspark  ---
I'll look into this, I've refactored this code recently to enable localization
and this was one of the "special" ops that didn't match between name and
variable identifier.

-- 
You are receiving this mail because:
You are watching all bug changes.