[ksmserver] [Bug 354724] missing some clients or windows when storeSession and performLegacySessionSave

https://bugs.kde.org/show_bug.cgi?id=354724 Wolfgang Bauer changed: What|Removed |Added CC||k...@kolivas.org --- Comment

[ksmserver] [Bug 354724] missing some clients or windows when storeSession and performLegacySessionSave

https://bugs.kde.org/show_bug.cgi?id=354724 Paul changed: What|Removed |Added CC|holle...@cs.dal.ca | -- You are receiving this mail

[ksmserver] [Bug 354724] missing some clients or windows when storeSession and performLegacySessionSave

https://bugs.kde.org/show_bug.cgi?id=354724 Martin Sandsmark changed: What|Removed |Added CC||p...@endlos.net

[ksmserver] [Bug 354724] missing some clients or windows when storeSession and performLegacySessionSave

https://bugs.kde.org/show_bug.cgi?id=354724 --- Comment #63 from Piotr Mierzwinski --- (In reply to Leslie Zhai from comment #61) > Yup also worked for ArchLinux now ;-) I use Antergos (Arch based distro) and I observed next problem. I mean that konsole is not

[ksmserver] [Bug 354724] missing some clients or windows when storeSession and performLegacySessionSave

https://bugs.kde.org/show_bug.cgi?id=354724 Piotr Mierzwinski changed: What|Removed |Added CC|

[ksmserver] [Bug 354724] missing some clients or windows when storeSession and performLegacySessionSave

https://bugs.kde.org/show_bug.cgi?id=354724 --- Comment #61 from Leslie Zhai --- Yup also worked for ArchLinux now ;-) -- You are receiving this mail because: You are watching all bug changes.

[ksmserver] [Bug 354724] missing some clients or windows when storeSession and performLegacySessionSave

https://bugs.kde.org/show_bug.cgi?id=354724 Valdas changed: What|Removed |Added CC||zmo...@hotmail.com -- You are

[ksmserver] [Bug 354724] missing some clients or windows when storeSession and performLegacySessionSave

https://bugs.kde.org/show_bug.cgi?id=354724 Paul changed: What|Removed |Added CC||holle...@cs.dal.ca --- Comment #60

[ksmserver] [Bug 354724] missing some clients or windows when storeSession and performLegacySessionSave

https://bugs.kde.org/show_bug.cgi?id=354724 --- Comment #59 from Thomas Lübking --- (In reply to Storm Engineer from comment #58) > The following do NOT get restored: > - Firefox https://forum.kde.org/viewtopic.php?f=111=131515 > Isn't Chrome using Qt tho? No. And

[ksmserver] [Bug 354724] missing some clients or windows when storeSession and performLegacySessionSave

https://bugs.kde.org/show_bug.cgi?id=354724 --- Comment #58 from Storm Engineer --- (In reply to Thomas Lübking from comment #57) > Firefox or cairo-dock were certainly not targetted or affected by the > related patches. I did some more testing, and indeed Qt apps (or at

[ksmserver] [Bug 354724] missing some clients or windows when storeSession and performLegacySessionSave

https://bugs.kde.org/show_bug.cgi?id=354724 Nicolás Adamo changed: What|Removed |Added CC||nicoad...@gmail.com --

[ksmserver] [Bug 354724] missing some clients or windows when storeSession and performLegacySessionSave

https://bugs.kde.org/show_bug.cgi?id=354724 --- Comment #57 from Thomas Lübking --- Firefox or cairo-dock were certainly not targetted or affected by the related patches. This only affects Qt applications directly, so if that indeed triggered something, either the

[ksmserver] [Bug 354724] missing some clients or windows when storeSession and performLegacySessionSave

https://bugs.kde.org/show_bug.cgi?id=354724 Storm Engineer changed: What|Removed |Added CC||hewa...@gmail.com ---

[ksmserver] [Bug 354724] missing some clients or windows when storeSession and performLegacySessionSave

https://bugs.kde.org/show_bug.cgi?id=354724 Jeff Long changed: What|Removed |Added CC||l...@ku.edu -- You are receiving

[ksmserver] [Bug 354724] missing some clients or windows when storeSession and performLegacySessionSave

https://bugs.kde.org/show_bug.cgi?id=354724 Wolfgang Bauer changed: What|Removed |Added CC||muzi...@email.it --- Comment

[ksmserver] [Bug 354724] missing some clients or windows when storeSession and performLegacySessionSave

https://bugs.kde.org/show_bug.cgi?id=354724 Wolfgang Bauer changed: What|Removed |Added CC||ker...@ag.de1.cc --- Comment

[ksmserver] [Bug 354724] missing some clients or windows when storeSession and performLegacySessionSave

https://bugs.kde.org/show_bug.cgi?id=354724 Wolfgang Bauer changed: What|Removed |Added CC||alexander...@gmail.com ---

[ksmserver] [Bug 354724] missing some clients or windows when storeSession and performLegacySessionSave

https://bugs.kde.org/show_bug.cgi?id=354724 Wolfgang Bauer changed: What|Removed |Added CC||ghborrm...@gmail.com ---

[ksmserver] [Bug 354724] missing some clients or windows when storeSession and performLegacySessionSave

https://bugs.kde.org/show_bug.cgi?id=354724 --- Comment #49 from Andreas Hartmetz --- Git commit a08befeac43647e222f48dfd7bed067be81573c4 by Andreas Hartmetz. Committed on 19/02/2016 at 19:08. Pushed by ahartmetz into branch 'master'. KNotes: fix session save / restore.

[ksmserver] [Bug 354724] missing some clients or windows when storeSession and performLegacySessionSave

https://bugs.kde.org/show_bug.cgi?id=354724 --- Comment #47 from Andreas Hartmetz --- Git commit 58e49487aece3de19aae90bbb9b80cd5aab94d04 by Andreas Hartmetz. Committed on 19/02/2016 at 18:55. Pushed by ahartmetz into branch 'master'. Fix session management for KApplication

[ksmserver] [Bug 354724] missing some clients or windows when storeSession and performLegacySessionSave

https://bugs.kde.org/show_bug.cgi?id=354724 Andreas Hartmetz changed: What|Removed |Added Resolution|--- |FIXED Latest

[ksmserver] [Bug 354724] missing some clients or windows when storeSession and performLegacySessionSave

https://bugs.kde.org/show_bug.cgi?id=354724 Andreas Hartmetz changed: What|Removed |Added Resolution|--- |FIXED Latest

[ksmserver] [Bug 354724] missing some clients or windows when storeSession and performLegacySessionSave

https://bugs.kde.org/show_bug.cgi?id=354724 --- Comment #46 from Thomas Lübking --- Well, "shrug, I don't care then" - Qt seems to be dropping desktop support anyway, so it probably doesn't really matter. For principal reasins I'd however object " proven to be not

[ksmserver] [Bug 354724] missing some clients or windows when storeSession and performLegacySessionSave

https://bugs.kde.org/show_bug.cgi?id=354724 Guillaume DE BURE changed: What|Removed |Added CC|

[ksmserver] [Bug 354724] missing some clients or windows when storeSession and performLegacySessionSave

https://bugs.kde.org/show_bug.cgi?id=354724 --- Comment #42 from Thomas Lübking --- So, looking into the Qt sources a bit more it seems that a) Session management is FUBAR in Qt5 and actually was likewise FU in Qt4 - adding the proposed flag will only restore the

[ksmserver] [Bug 354724] missing some clients or windows when storeSession and performLegacySessionSave

https://bugs.kde.org/show_bug.cgi?id=354724 --- Comment #45 from Andreas Hartmetz --- ..and frankly, I don't feel like gold-plating the solution to this mess. It's not going to be pretty either way, nobody cares too much except when their stuff breaks (ours did), and there

[ksmserver] [Bug 354724] missing some clients or windows when storeSession and performLegacySessionSave

https://bugs.kde.org/show_bug.cgi?id=354724 --- Comment #44 from Andreas Hartmetz --- I don't think that either dynamic properties or changing behavior that has been pretty much proven to be not broken by being around for over 10 years with no complaints will fly upstream,

[ksmserver] [Bug 354724] missing some clients or windows when storeSession and performLegacySessionSave

https://bugs.kde.org/show_bug.cgi?id=354724 --- Comment #41 from Andreas Hartmetz --- Those patches are just what I currently have, they are just intended to show the important logic changes. I wasn't really planning to even submit them for review because unfortunately I

[ksmserver] [Bug 354724] missing some clients or windows when storeSession and performLegacySessionSave

https://bugs.kde.org/show_bug.cgi?id=354724 --- Comment #40 from Thomas Lübking --- Please file a review request (attaching the frameworks group), the bug is assigned to Seli and I'm not sure anybody but us reads it. I can already say that it lacks a QT_VERSION test.

[ksmserver] [Bug 354724] missing some clients or windows when storeSession and performLegacySessionSave

https://bugs.kde.org/show_bug.cgi?id=354724 --- Comment #39 from Andreas Hartmetz --- These patches mostly fix session saving (and therefore restoring), together with the necessary Qt patch. Applications not using KApplication or KMainWindow will need to call

[ksmserver] [Bug 354724] missing some clients or windows when storeSession and performLegacySessionSave

https://bugs.kde.org/show_bug.cgi?id=354724 --- Comment #38 from Andreas Hartmetz --- Created attachment 96914 --> https://bugs.kde.org/attachment.cgi?id=96914=edit Fix session saving / KMainWindow changes -- You are receiving this mail because: You are watching all bug

[ksmserver] [Bug 354724] missing some clients or windows when storeSession and performLegacySessionSave

https://bugs.kde.org/show_bug.cgi?id=354724 --- Comment #37 from Andreas Hartmetz --- Created attachment 96913 --> https://bugs.kde.org/attachment.cgi?id=96913=edit Fix session saving / KApplication changes -- You are receiving this mail because: You are watching all bug

[ksmserver] [Bug 354724] missing some clients or windows when storeSession and performLegacySessionSave

https://bugs.kde.org/show_bug.cgi?id=354724 --- Comment #33 from Thomas Lübking --- For a KMainWindow solution, one should not require a nasty global eventfilter on the application - handling KMainWindow::closeEvent() should be sufficient, but there might be an

[ksmserver] [Bug 354724] missing some clients or windows when storeSession and performLegacySessionSave

https://bugs.kde.org/show_bug.cgi?id=354724 --- Comment #36 from Thomas Lübking --- Fun fact (though you likely already know) - KApplication::commitData(.) *did* send a fake close event to everything but KMainWindow ... -- You are receiving this mail because: You are

[ksmserver] [Bug 354724] missing some clients or windows when storeSession and performLegacySessionSave

https://bugs.kde.org/show_bug.cgi?id=354724 --- Comment #35 from Thomas Lübking --- How exactly did you try the kwrite crashing workaround? Just by sending a zombie closeEvent? Do you still have a backtrace? (Let's say it's legit for a leaf widget to assume that the

[ksmserver] [Bug 354724] missing some clients or windows when storeSession and performLegacySessionSave

https://bugs.kde.org/show_bug.cgi?id=354724 --- Comment #34 from Andreas Hartmetz --- Yes indeed, it doesn't work because ignoring close events cancels logout. Damn. -- You are receiving this mail because: You are watching all bug changes.

[ksmserver] [Bug 354724] missing some clients or windows when storeSession and performLegacySessionSave

https://bugs.kde.org/show_bug.cgi?id=354724 --- Comment #29 from Andreas Hartmetz --- We cannot change Qt in a way that breaks existing applications. Qt5 has not exactly just been released, and commercial customers value stability very much. Some of them even pay for Qt

[ksmserver] [Bug 354724] missing some clients or windows when storeSession and performLegacySessionSave

https://bugs.kde.org/show_bug.cgi?id=354724 --- Comment #27 from Andreas Hartmetz --- You can't just send fake close events to clients that don't expect that. That... technique... is a KDE specialty. KDE applications are written to deal with it. In the general case, though,

[ksmserver] [Bug 354724] missing some clients or windows when storeSession and performLegacySessionSave

https://bugs.kde.org/show_bug.cgi?id=354724 --- Comment #30 from Alexey Chernov <4er...@gmail.com> --- (In reply to Andreas Hartmetz from comment #29) > We cannot change Qt in a way that breaks existing applications. Qt5 has not > exactly just been released, and commercial customers value

[ksmserver] [Bug 354724] missing some clients or windows when storeSession and performLegacySessionSave

https://bugs.kde.org/show_bug.cgi?id=354724 --- Comment #32 from Thomas Lübking --- (In reply to Andreas Hartmetz from comment #27) > We can, however, implement a workaround in KDE (and then fix our stuff when > something breaks): > [...] > Now which repository

[ksmserver] [Bug 354724] missing some clients or windows when storeSession and performLegacySessionSave

https://bugs.kde.org/show_bug.cgi?id=354724 --- Comment #31 from Thomas Lübking --- (In reply to Alexey Chernov from comment #30) > The same way commercial customers or applications would be affected with API > changes. How an ABI styable API extension could affect

[ksmserver] [Bug 354724] missing some clients or windows when storeSession and performLegacySessionSave

https://bugs.kde.org/show_bug.cgi?id=354724 --- Comment #28 from Alexey Chernov <4er...@gmail.com> --- (In reply to Thomas Lübking from comment #26) > (In reply to Alexey Chernov from comment #25) > > > According to what? > According to "This is not fixed in years and each and every session >

[ksmserver] [Bug 354724] missing some clients or windows when storeSession and performLegacySessionSave

https://bugs.kde.org/show_bug.cgi?id=354724 --- Comment #23 from Alexey Chernov <4er...@gmail.com> --- (In reply to Thomas Lübking from comment #22) > > 5. I completely don't like the proposed way to preserve the compatibility > > with (4) and make > > the use case of broken session management

[ksmserver] [Bug 354724] missing some clients or windows when storeSession and performLegacySessionSave

https://bugs.kde.org/show_bug.cgi?id=354724 --- Comment #26 from Thomas Lübking --- (In reply to Alexey Chernov from comment #25) > According to what? According to "This is not fixed in years and each and every session management code was ported as "#if 0"" If there

[ksmserver] [Bug 354724] missing some clients or windows when storeSession and performLegacySessionSave

https://bugs.kde.org/show_bug.cgi?id=354724 --- Comment #25 from Alexey Chernov <4er...@gmail.com> --- (In reply to Thomas Lübking from comment #24) > (In reply to Alexey Chernov from comment #23) > > > Comments like this clearly don't help > Seriously, you asked for breaking clients because

[ksmserver] [Bug 354724] missing some clients or windows when storeSession and performLegacySessionSave

https://bugs.kde.org/show_bug.cgi?id=354724 --- Comment #24 from Thomas Lübking --- (In reply to Alexey Chernov from comment #23) > Comments like this clearly don't help Seriously, you asked for breaking clients because that's what you'd "like" to do - what did you

[ksmserver] [Bug 354724] missing some clients or windows when storeSession and performLegacySessionSave

https://bugs.kde.org/show_bug.cgi?id=354724 Alexey Chernov <4er...@gmail.com> changed: What|Removed |Added CC||4er...@gmail.com ---

[ksmserver] [Bug 354724] missing some clients or windows when storeSession and performLegacySessionSave

https://bugs.kde.org/show_bug.cgi?id=354724 --- Comment #22 from Thomas Lübking --- > 5. I completely don't like the proposed way to preserve the compatibility > with (4) and make > the use case of broken session management client implementation legal and > default,

[ksmserver] [Bug 354724] missing some clients or windows when storeSession and performLegacySessionSave

https://bugs.kde.org/show_bug.cgi?id=354724 Nico Kruber changed: What|Removed |Added CC||nico.kru...@gmail.com --

[ksmserver] [Bug 354724] missing some clients or windows when storeSession and performLegacySessionSave

https://bugs.kde.org/show_bug.cgi?id=354724 Àlex Magaz Graça changed: What|Removed |Added CC||rival...@gmail.com --

[ksmserver] [Bug 354724] missing some clients or windows when storeSession and performLegacySessionSave

https://bugs.kde.org/show_bug.cgi?id=354724 Densetsu no Ero-sennin changed: What|Removed |Added CC|

[ksmserver] [Bug 354724] missing some clients or windows when storeSession and performLegacySessionSave

https://bugs.kde.org/show_bug.cgi?id=354724 Wolfgang Bauer changed: What|Removed |Added CC||hac...@scarlet-jade.com ---

[ksmserver] [Bug 354724] missing some clients or windows when storeSession and performLegacySessionSave

https://bugs.kde.org/show_bug.cgi?id=354724 --- Comment #19 from Thomas Lübking --- (In reply to Andreas Hartmetz from comment #18) > How should that be done, sending close events and expecting applications to > save their state in response, but not close windows or

[ksmserver] [Bug 354724] missing some clients or windows when storeSession and performLegacySessionSave

https://bugs.kde.org/show_bug.cgi?id=354724 Leslie Zhai changed: What|Removed |Added Resolution|UPSTREAM|---

[ksmserver] [Bug 354724] missing some clients or windows when storeSession and performLegacySessionSave

https://bugs.kde.org/show_bug.cgi?id=354724 --- Comment #18 from Andreas Hartmetz --- How should that be done, sending close events and expecting applications to save their state in response, but not close windows or the application? It would mean that applications are

[ksmserver] [Bug 354724] missing some clients or windows when storeSession and performLegacySessionSave

https://bugs.kde.org/show_bug.cgi?id=354724 --- Comment #16 from Andreas Hartmetz --- The session manager getting an OK means asking the client and at this point the client can cancel the shutdown, or save its state and wait to get killed. -- You are receiving this mail

[ksmserver] [Bug 354724] missing some clients or windows when storeSession and performLegacySessionSave

https://bugs.kde.org/show_bug.cgi?id=354724 --- Comment #13 from Thomas Lübking --- Andreas, the Qt patch kills the ability to cancel the logout process (when the process or user prevents closing a window), I'm not sure it will be accepted and if, you probably will

[ksmserver] [Bug 354724] missing some clients or windows when storeSession and performLegacySessionSave

https://bugs.kde.org/show_bug.cgi?id=354724 --- Comment #17 from Thomas Lübking --- Yes, my concern is that status quo for several/many applications is that they do no connect to saveStateRequest() or commitDataRequest() and *only* perform interaction on window close

[ksmserver] [Bug 354724] missing some clients or windows when storeSession and performLegacySessionSave

https://bugs.kde.org/show_bug.cgi?id=354724 --- Comment #15 from Thomas Lübking --- The typical fail will be the "there are 5 tabs open, close/cancel" dialogs. Afaiu this was added because of some MS Windows behavior and even if not, one has to assume that clients

[ksmserver] [Bug 354724] missing some clients or windows when storeSession and performLegacySessionSave

https://bugs.kde.org/show_bug.cgi?id=354724 --- Comment #14 from Andreas Hartmetz --- (In reply to Thomas Lübking from comment #13) > Andreas, the Qt patch kills the ability to cancel the logout process (when > the process or user prevents closing a window), I'm not sure it

[ksmserver] [Bug 354724] missing some clients or windows when storeSession and performLegacySessionSave

https://bugs.kde.org/show_bug.cgi?id=354724 --- Comment #11 from Andreas Hartmetz --- Note: sub-session support in the session manager is basically support for activities. Session restore of activities has never worked well enough to be useful for me. -- You are receiving

[ksmserver] [Bug 354724] missing some clients or windows when storeSession and performLegacySessionSave

https://bugs.kde.org/show_bug.cgi?id=354724 --- Comment #12 from Leslie Zhai --- Hi Andreas, Thanks for your patch! I do not have Qt developer's account, so I could not +1 for your great job. Hope Qt5.x will integrate your patch to fix the restore session relative issue.

[ksmserver] [Bug 354724] missing some clients or windows when storeSession and performLegacySessionSave

https://bugs.kde.org/show_bug.cgi?id=354724 Leslie Zhai changed: What|Removed |Added Status|CONFIRMED |RESOLVED

[ksmserver] [Bug 354724] missing some clients or windows when storeSession and performLegacySessionSave

https://bugs.kde.org/show_bug.cgi?id=354724 Daniele Orlandi changed: What|Removed |Added CC||dani...@orlandi.com --

[ksmserver] [Bug 354724] missing some clients or windows when storeSession and performLegacySessionSave

https://bugs.kde.org/show_bug.cgi?id=354724 Thomas Lübking changed: What|Removed |Added CC|

[ksmserver] [Bug 354724] missing some clients or windows when storeSession and performLegacySessionSave

https://bugs.kde.org/show_bug.cgi?id=354724 --- Comment #7 from Leslie Zhai --- Hi Andreas https://git.reviewboard.kde.org/r/126311/ workaround monkey patch ;P hope you can fix it in right way ;-) -- You are receiving this mail because: You are watching all bug changes.

[ksmserver] [Bug 354724] missing some clients or windows when storeSession and performLegacySessionSave

https://bugs.kde.org/show_bug.cgi?id=354724 --- Comment #6 from Leslie Zhai --- https://bugs.kde.org/show_bug.cgi?id=341930 -- You are receiving this mail because: You are watching all bug changes.