[ksysguard] [Bug 376537] ksysguardd crashed on kernel 4.9

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=376537

Christoph Feck  changed:

   What|Removed |Added

  Latest Commit||https://commits.kde.org/ksy
   ||sguard/e4c58c2f6ef74bad065f
   ||7327c19c02a3dac3
   Version Fixed In||5.8.6
 Resolution|--- |FIXED
 Status|UNCONFIRMED |RESOLVED

--- Comment #23 from Christoph Feck  ---
Git commit e4c58c2f6ef74bad065f7327c19c02a3dac3 by Christoph Feck.
Committed on 19/02/2017 at 04:15.
Pushed by cfeck into branch 'Plasma/5.8'.

Fix array allocation for non-continuous cpu numbers
FIXED-IN: 5.8.6

Differential Revision: https://phabricator.kde.org/D4640

M  +2-1ksysguardd/Linux/stat.c

https://commits.kde.org/ksysguard/e4c58c2f6ef74bad065f7327c19c02a3dac3

-- 
You are receiving this mail because:
You are watching all bug changes.

[ksysguard] [Bug 376537] ksysguardd crashed on kernel 4.9

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=376537

--- Comment #22 from boestari.r...@gmail.com ---
(In reply to Christoph Feck from comment #21)
> If everything else fails, install it to /usr and reboot.
> 
> cmake -DCMAKE_BUILD_TYPE=Debug -DCMAKE_INSTALL_PREFIX=/usr ..
> make
> sudo make install

omg, yes this solve the problem. ksysguard behaves normally again, and no more
error message on journalctl.
also, many monitoring widgets (thermal monitor, cpu load) is functional again,
guess it depends on ksysguard.

but system load tab still not drawing cpu history & network history, only
memory & swap history functioning. but this issue happened long before kernel
4.9. i guess i'll search google first.

thanks dude, now should i change the status to resolved?

-- 
You are receiving this mail because:
You are watching all bug changes.

[ksysguard] [Bug 376537] ksysguardd crashed on kernel 4.9

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=376537

--- Comment #21 from Christoph Feck  ---
If everything else fails, install it to /usr and reboot.

cmake -DCMAKE_BUILD_TYPE=Debug -DCMAKE_INSTALL_PREFIX=/usr ..
make
sudo make install

-- 
You are receiving this mail because:
You are watching all bug changes.

[ksysguard] [Bug 376537] ksysguardd crashed on kernel 4.9

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=376537

--- Comment #20 from boestari.r...@gmail.com ---
(In reply to Christoph Feck from comment #19)
> I was referring to the attachment from comment #5. It clearly shows a crash,
> but the symbols are 'n/a' there.
> 
> Also, make sure ksysguard actually connects to your compiled version of
> ksysguardd, instead of the one from distribution packages.

how do i make sure compiled ksysguard connects to compiled ksysguardd? i have
google this, but no manual or explanation on this topic.

-- 
You are receiving this mail because:
You are watching all bug changes.

[ksysguard] [Bug 376537] ksysguardd crashed on kernel 4.9

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=376537

--- Comment #19 from Christoph Feck  ---
I was referring to the attachment from comment #5. It clearly shows a crash,
but the symbols are 'n/a' there.

Also, make sure ksysguard actually connects to your compiled version of
ksysguardd, instead of the one from distribution packages.

-- 
You are receiving this mail because:
You are watching all bug changes.

[ksysguard] [Bug 376537] ksysguardd crashed on kernel 4.9

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=376537

--- Comment #18 from boestari.r...@gmail.com ---
(In reply to Christoph Feck from comment #17)
> Yes, but that backtrace has no debug symbols...

i built it using following commands within build directory inside ksysguard
project
[boes@ARCHHOME build]$cmake -DCMAKE_BUILD_TYPE=Debug ..
[boes@ARCHHOME build]$make
am i missing something here?

-- 
You are receiving this mail because:
You are watching all bug changes.

[ksysguard] [Bug 376537] ksysguardd crashed on kernel 4.9

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=376537

--- Comment #17 from Christoph Feck  ---
Yes, but that backtrace has no debug symbols...

-- 
You are receiving this mail because:
You are watching all bug changes.

[ksysguard] [Bug 376537] ksysguardd crashed on kernel 4.9

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=376537

--- Comment #16 from boestari.r...@gmail.com ---
(In reply to Christoph Feck from comment #15)
> The valgrind memcheck log does not show any reason for a crash. The 'invalid
> reads' and 'invalid writes' seem to be gone, so I am wondering if it crashes
> at all.

well, ksysguard itself is not crashing, but avrage cpu load, memory load, and
graphs in system load not drawing at all. and on the process list,
systemd-coredump keep surfacing continuously. after checking journalctl, it is
related to ksysguardd like in attachment 104076

-- 
You are receiving this mail because:
You are watching all bug changes.

[ksysguard] [Bug 376537] ksysguardd crashed on kernel 4.9

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=376537

--- Comment #15 from Christoph Feck  ---
The valgrind memcheck log does not show any reason for a crash. The 'invalid
reads' and 'invalid writes' seem to be gone, so I am wondering if it crashes at
all.

-- 
You are receiving this mail because:
You are watching all bug changes.

[ksysguard] [Bug 376537] ksysguardd crashed on kernel 4.9

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=376537

--- Comment #14 from boestari.r...@gmail.com ---
Created attachment 104087
  --> https://bugs.kde.org/attachment.cgi?id=104087=edit
valgrind ksysguard

here's the valgrind ksysguard output. i'm using flag --leak-check=full

-- 
You are receiving this mail because:
You are watching all bug changes.

[ksysguard] [Bug 376537] ksysguardd crashed on kernel 4.9

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=376537

--- Comment #13 from Christoph Feck  ---
At cmake time, with -DCMAKE_BUILD_TYPE=Debug

-- 
You are receiving this mail because:
You are watching all bug changes.

[ksysguard] [Bug 376537] ksysguardd crashed on kernel 4.9

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=376537

--- Comment #12 from boestari.r...@gmail.com ---
(In reply to Christoph Feck from comment #10)
> If it still crashes with the patch applied, please add a backtrace with full
> debug symbols, and ideally also a valgrind log (with debug symbols). Note
> that default packages in Arch do not have debug information, so you need to
> compile yourself, or test with a different distribution.

i know how to use valgrind, but how do i enable debug symbols? at compile time
or at running time?

-- 
You are receiving this mail because:
You are watching all bug changes.

[ksysguard] [Bug 376537] ksysguardd crashed on kernel 4.9

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=376537

--- Comment #11 from boestari.r...@gmail.com ---
(In reply to Rog131 from comment #8)
> (In reply to boestari.riko from comment #6)
> > Created attachment 104077 [details]
> > screenshot
> > 
> > so, i built the latest ksysguard from github and include your changes.
> > running ksysguard, well, nothing changes, it's still running with errors. i
> > include the screenshot. you can see at the bottom, ksysguard only shows
> > number of processes, and missing average cpu usage, memory usage, etc. and
> > in system load tab, the graph is not drawing at all. on previous comment, i
> > also include output of ksysguard and journalctl. sorry for triple post, i
> > have no idea how to attach multiple files here
> 
> Did you clean the $HOME/.local/share/ksysguard/ directory ?

cleaning that directory gave the same result.

-- 
You are receiving this mail because:
You are watching all bug changes.

[ksysguard] [Bug 376537] ksysguardd crashed on kernel 4.9

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=376537

--- Comment #10 from Christoph Feck  ---
If it still crashes with the patch applied, please add a backtrace with full
debug symbols, and ideally also a valgrind log (with debug symbols). Note that
default packages in Arch do not have debug information, so you need to compile
yourself, or test with a different distribution.

-- 
You are receiving this mail because:
You are watching all bug changes.

[ksysguard] [Bug 376537] ksysguardd crashed on kernel 4.9

[Rog131]

https://bugs.kde.org/show_bug.cgi?id=376537

--- Comment #9 from Rog131  ---
At here: AMD FX-6100 (six core) & Arch Linux. With the Kernel 4.9.8 the core
numbering is 0,3,4,5,6,7 -> The Ksysguard is crashing


Downloading the Arch Ksysguard PKGBUILD:
https://git.archlinux.org/svntogit/packages.git/tree/trunk?h=packages/ksysguard

Applying the patch: patch -p1 -i /path/to/counter.diff

Wrapping the package: makepkg -e

Installing the package: pacman -U ksysguard-5.9.2-1-x86_64.pkg.tar.xz

Restarting the plasmashell: kquitapp5 plasmashell and then plasmashell

Testing the ksysguard -> The CPU History and the Network History are blank.

Cleaning (removing files from) the $HOME/.local/share/ksysguard/

Restarting the plasmashell and testing again - working - the core numbering is
a bit strange 1,4,5,6,7,8 : http://imgur.com/ys2ADg9

-- 
You are receiving this mail because:
You are watching all bug changes.

[ksysguard] [Bug 376537] ksysguardd crashed on kernel 4.9

[Rog131]

https://bugs.kde.org/show_bug.cgi?id=376537

Rog131  changed:

   What|Removed |Added

 CC||samrog...@hotmail.com

--- Comment #8 from Rog131  ---
(In reply to boestari.riko from comment #6)
> Created attachment 104077 [details]
> screenshot
> 
> so, i built the latest ksysguard from github and include your changes.
> running ksysguard, well, nothing changes, it's still running with errors. i
> include the screenshot. you can see at the bottom, ksysguard only shows
> number of processes, and missing average cpu usage, memory usage, etc. and
> in system load tab, the graph is not drawing at all. on previous comment, i
> also include output of ksysguard and journalctl. sorry for triple post, i
> have no idea how to attach multiple files here

Did you clean the $HOME/.local/share/ksysguard/ directory ?

-- 
You are receiving this mail because:
You are watching all bug changes.

[ksysguard] [Bug 376537] ksysguardd crashed on kernel 4.9

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=376537

--- Comment #7 from boestari.r...@gmail.com ---
and btw on my amd fx-6100, kernel 4.9.8 /sys/devices/system/cpu folder contains
cpu0, cpu3-cpu7 just like in /proc/stat, and files
/sys/devices/system/cpu/cpuX/cpufreq/stats/time_in_state is empty. hope this
helps

-- 
You are receiving this mail because:
You are watching all bug changes.

[ksysguard] [Bug 376537] ksysguardd crashed on kernel 4.9

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=376537

--- Comment #6 from boestari.r...@gmail.com ---
Created attachment 104077
  --> https://bugs.kde.org/attachment.cgi?id=104077=edit
screenshot

so, i built the latest ksysguard from github and include your changes.
running ksysguard, well, nothing changes, it's still running with errors. i
include the screenshot. you can see at the bottom, ksysguard only shows number
of processes, and missing average cpu usage, memory usage, etc. and in system
load tab, the graph is not drawing at all. on previous comment, i also include
output of ksysguard and journalctl. sorry for triple post, i have no idea how
to attach multiple files here

-- 
You are receiving this mail because:
You are watching all bug changes.

[ksysguard] [Bug 376537] ksysguardd crashed on kernel 4.9

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=376537

--- Comment #5 from boestari.r...@gmail.com ---
Created attachment 104076
  --> https://bugs.kde.org/attachment.cgi?id=104076=edit
journal ctl output

this is the journalctl output when running ksysguard

-- 
You are receiving this mail because:
You are watching all bug changes.

[ksysguard] [Bug 376537] ksysguardd crashed on kernel 4.9

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=376537

--- Comment #4 from boestari.r...@gmail.com ---
Created attachment 104075
  --> https://bugs.kde.org/attachment.cgi?id=104075=edit
ksysguard output

-- 
You are receiving this mail because:
You are watching all bug changes.

[ksysguard] [Bug 376537] ksysguardd crashed on kernel 4.9

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=376537

--- Comment #3 from boestari.r...@gmail.com ---
i'll try it tonight. currently at work now.

-- 
You are receiving this mail because:
You are watching all bug changes.

[ksysguard] [Bug 376537] ksysguardd crashed on kernel 4.9

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=376537

--- Comment #2 from Christoph Feck  ---
Created attachment 104068
  --> https://bugs.kde.org/attachment.cgi?id=104068=edit
Proposed patch

Indeed. It counts the number of "cpu" lines, and only allocates that number
of entries. But then, it uses the  number to index into the allocated array.

Could you test attached patch?

-- 
You are receiving this mail because:
You are watching all bug changes.

[ksysguard] [Bug 376537] ksysguardd crashed on kernel 4.9

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=376537

--- Comment #1 from boestari.r...@gmail.com ---
i believe it also related to these bugs report:
https://bugs.kde.org/show_bug.cgi?id=374944
https://bugs.kde.org/show_bug.cgi?id=371942

-- 
You are receiving this mail because:
You are watching all bug changes.