[kwin] [Bug 301447] Desktop grid effect changes activities

[Vlad Zahorodnii]

https://bugs.kde.org/show_bug.cgi?id=301447

Vlad Zahorodnii  changed:

   What|Removed |Added

 CC||kropp...@kroppyer.nl

--- Comment #16 from Vlad Zahorodnii  ---
*** Bug 410899 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 301447] Desktop grid effect changes activities

[Vlad Zahorodnii]

https://bugs.kde.org/show_bug.cgi?id=301447

Vlad Zahorodnii  changed:

   What|Removed |Added

  Latest Commit|https://commits.kde.org/kwi |https://commits.kde.org/kwi
   |n/0c3047a8f1d4a70f39250c759 |n/e918cb5d2d3de033635d0cd74
   |224a7dfab72a76b |63de25fd6312b24

--- Comment #15 from Vlad Zahorodnii  ---
Git commit e918cb5d2d3de033635d0cd7463de25fd6312b24 by Vlad Zagorodniy.
Committed on 27/08/2019 at 05:22.
Pushed by vladz into branch 'Plasma/5.12'.

[effects/desktopgrid] Don't change activities

Summary:
If the Desktop Grid effect doesn't use the Present Windows effect to
layout windows, windowAt helper can return a window that doesn't belong
to current activity because it doesn't check whether that window belongs
to current activity.

This change addresses that problem by adding corresponding check.
FIXED-IN: 5.13.4

Test Plan:
//Unchecked "Use Present Windows effect to layout the windows".//

* Switched to activity #1
* Switched to virtual desktop #1
* Launched Konsole and maximized it(to increate hit area)
* Switched to activity #2
* Switched to virtual desktop #2
* Launched Dolphin and maximized it
* Activated the Desktop Grid effect, clicked on virtual desktop #1 (activity #2
is still active)
* Switched to activity #1
* Activated the Desktop Grid effect, clicked on virtual desktop #2 (activity #1
is still active)

Reviewers: #kwin, davidedmundson

Reviewed By: #kwin, davidedmundson

Subscribers: kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D14046

M  +1-1effects/desktopgrid/desktopgrid.cpp

https://commits.kde.org/kwin/e918cb5d2d3de033635d0cd7463de25fd6312b24

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 301447] Desktop grid effect changes activities

[Diego Gangl]

https://bugs.kde.org/show_bug.cgi?id=301447

--- Comment #14 from Diego Gangl  ---
Thanks Vlad, and thanks Marcin for bringing this back to life!

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 301447] Desktop grid effect changes activities

[Stefanos Harhalakis]

https://bugs.kde.org/show_bug.cgi?id=301447

--- Comment #13 from Stefanos Harhalakis  ---
Thanks Vlad!

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 301447] Desktop grid effect changes activities

[Marcin Migacz]

https://bugs.kde.org/show_bug.cgi?id=301447

--- Comment #12 from Marcin Migacz  ---
You found it ! That is fantastic :D After living with that bug more than a year
is a great information ! :D

Can you tell me how i can apply this changes ? 
I'm on manjaro.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 301447] Desktop grid effect changes activities

[Vlad Zagorodniy]

https://bugs.kde.org/show_bug.cgi?id=301447

Vlad Zagorodniy  changed:

   What|Removed |Added

  Latest Commit||https://commits.kde.org/kwi
   ||n/0c3047a8f1d4a70f39250c759
   ||224a7dfab72a76b
 Resolution|--- |FIXED
   Version Fixed In||5.13.4
 Status|REOPENED|RESOLVED

--- Comment #11 from Vlad Zagorodniy  ---
Git commit 0c3047a8f1d4a70f39250c759224a7dfab72a76b by Vlad Zagorodniy.
Committed on 11/07/2018 at 13:39.
Pushed by vladz into branch 'Plasma/5.13'.

[effects/desktopgrid] Don't change activities

Summary:
If the Desktop Grid effect doesn't use the Present Windows effect to
layout windows, windowAt helper can return a window that doesn't belong
to current activity because it doesn't check whether that window belongs
to current activity.

This change addresses that problem by adding corresponding check.
FIXED-IN: 5.13.4

Test Plan:
//Unchecked "Use Present Windows effect to layout the windows".//

* Switched to activity #1
* Switched to virtual desktop #1
* Launched Konsole and maximized it(to increate hit area)
* Switched to activity #2
* Switched to virtual desktop #2
* Launched Dolphin and maximized it
* Activated the Desktop Grid effect, clicked on virtual desktop #1 (activity #2
is still active)
* Switched to activity #1
* Activated the Desktop Grid effect, clicked on virtual desktop #2 (activity #1
is still active)

Reviewers: #kwin, davidedmundson

Reviewed By: #kwin, davidedmundson

Subscribers: kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D14046

M  +1-1effects/desktopgrid/desktopgrid.cpp

https://commits.kde.org/kwin/0c3047a8f1d4a70f39250c759224a7dfab72a76b

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 301447] Desktop grid effect changes activities

[Vlad Zagorodniy]

https://bugs.kde.org/show_bug.cgi?id=301447

Vlad Zagorodniy  changed:

   What|Removed |Added

 CC||vladz...@gmail.com
   Assignee|kwin-bugs-n...@kde.org  |vladz...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 301447] Desktop grid effect changes activities

[Marcin Migacz]

https://bugs.kde.org/show_bug.cgi?id=301447

Marcin Migacz  changed:

   What|Removed |Added

 CC||migac...@gmail.com

--- Comment #10 from Marcin Migacz  ---
This bug is annoying as hell i agree ! Please fix it. Or at least tell me how i
can fix it. Option "using present window" is showing windows organised in
desktop. But i want to see them how they are organised by myself. As they are! 
And fix probably is a few line of code.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 301447] Desktop grid effect changes activities

[Diego Garcia]

https://bugs.kde.org/show_bug.cgi?id=301447

Diego Garcia  changed:

   What|Removed |Added

 CC||dnico...@gmail.com

--- Comment #9 from Diego Garcia  ---
This bug still happens in 5.10.5 and is annoying as hell. Enabling "Use present
windows" seems to make it work.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 301447] Desktop grid effect changes activities

[Sebastian Kuźlak via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=301447

--- Comment #8 from Sebastian Kuźlak  ---
this is still present in 5.5

-- 
You are receiving this mail because:
You are watching all bug changes.