[kwin] [Bug 376457] Revert wrapping in window swithing

[Yichao Yu]

https://bugs.kde.org/show_bug.cgi?id=376457

--- Comment #10 from Yichao Yu  ---
I assume by that you mean https://phabricator.kde.org/D3602 ?
I didn't want to comment on a merged pull request so I opened a bug report.
I'll comment there instead.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 376457] Revert wrapping in window swithing

[Martin Gräßlin]

https://bugs.kde.org/show_bug.cgi?id=376457

--- Comment #9 from Martin Gräßlin  ---
I'm not going to further discuss this in the bug report. If you think 
the design feedback is wrong, please raise it in the phab request.

As I wrote in the phab request I keep out of the usability decision on 
that. I completely trust our design team there, thus I won't overrule 
their decision.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 376457] Revert wrapping in window swithing

[Yichao Yu]

https://bugs.kde.org/show_bug.cgi?id=376457

--- Comment #8 from Yichao Yu  ---
Right, there are a lot of shortcuts that shouldn't be used with autorepeat, but
the change turns these ones from autorepeatable to not autorepeatable and
therefore one of the most important statements in the usability feedback namely

> Those who would not expect the wrap-around behavior would not expect anything
> to happen at all, and therefore not even press the shortcut if they are at the
> left-/rightmost window.

is wrong.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 376457] Revert wrapping in window swithing

[Martin Gräßlin]

https://bugs.kde.org/show_bug.cgi?id=376457

Martin Gräßlin  changed:

   What|Removed |Added

 Resolution|--- |WONTFIX
 Status|REOPENED|RESOLVED

--- Comment #7 from Martin Gräßlin  ---
I don't think that autorepeat changes anything. We have quite a few global
shortcuts which do not work correctly or do not make sense when keys auto
repeat. Common examples are Alt+Tab, Present Windows, Mute, etc. etc. In fact
only very few keys make sense with auto repeat, prominent example Lower/Raise
Audio.

Given that we don't have special handling for any global shortcut with regards
to auto repeat I don't think this needs adjustment. It is up to the user to
configure a global shortcut which won't auto repeat.

I'm setting this again to wontfix and this is the final maintainer decision.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 376457] Revert wrapping in window swithing

[Yichao Yu]

https://bugs.kde.org/show_bug.cgi?id=376457

--- Comment #6 from Yichao Yu  ---
Yet another acceptable solution would be to expose the new `switchWindow`
function in the KWin scripting interface (I thought it's possible to trigger
script with hotkey/add hotkey from a script?). I'm happy to implement and add
test with either methods though I'll need some help for how to add a test for
it.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 376457] Revert wrapping in window swithing

[Yichao Yu]

https://bugs.kde.org/show_bug.cgi?id=376457

Yichao Yu  changed:

   What|Removed |Added

Summary|Provide an option to|Revert wrapping in window
   |disable wrapping in window  |swithing
   |swithing|

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 376457] Revert wrapping in window swithing

[Yichao Yu]

https://bugs.kde.org/show_bug.cgi?id=376457

--- Comment #5 from Yichao Yu  ---
Also, although I'm not that familiar with how the auto testing is done on X11,
it seems that this should be a relatively easy thing to test for both options
and should not be strongly coupled to other options so detecting breakage
should be possible.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 376457] Revert wrapping in window swithing

[Yichao Yu]

https://bugs.kde.org/show_bug.cgi?id=376457

Yichao Yu  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|RESOLVED|REOPENED
 Resolution|WONTFIX |---

--- Comment #4 from Yichao Yu  ---
In that case, consider this a request to revert the behavior since I don't
think the usability feedback considered the effect of keyboard autorepeating.

-- 
You are receiving this mail because:
You are watching all bug changes.