[kwin] [Bug 376505] kwin compile error in Gentoo gcc-6.3.0, glibc-2.25

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=376505

andreas.sturmlech...@gmail.com changed:

   What|Removed |Added

  Latest Commit||https://commits.kde.org/kwi
   ||n/35c278e525377723028a1417a
   ||705d28517fa183f
 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

--- Comment #6 from andreas.sturmlech...@gmail.com ---
Git commit 35c278e525377723028a1417a705d28517fa183f by Andreas Sturmlechner.
Committed on 25/07/2017 at 20:16.
Pushed by asturmlechner into branch 'master'.

Fix build with future glibc (major/minor macros), BSD compatible

Summary:
Also adding sys/types.h which is not implicitly included from all over.

Thanks-to: [ade] in #kde-devel

See also:
https://sourceware.org/ml/libc-alpha/2015-11/msg00452.html
https://git.reviewboard.kde.org/r/127662/

Reviewers: #plasma, graesslin

Reviewed By: #plasma, graesslin

Subscribers: graesslin, plasma-devel, kwin, #kwin, adridg

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D6175

M  +4-0logind.cpp

https://commits.kde.org/kwin/35c278e525377723028a1417a705d28517fa183f

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 376505] kwin compile error in Gentoo gcc-6.3.0, glibc-2.25

[Martin Gräßlin]

https://bugs.kde.org/show_bug.cgi?id=376505

--- Comment #5 from Martin Gräßlin  ---
> This one was already fixed by commit
> 03f4f972d6c3ed03eab04c889248d089d317d370
> but reverted later with commit
> a1f21f3ceac5315f2bfed8e9fa739d71ae2c6f10

Yay, I love it if we can pick between compile failure on Linux and BSD.

I would appreciate if the devs who thought it needed to move the macros 
go to all depending software and fix it.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 376505] kwin compile error in Gentoo gcc-6.3.0, glibc-2.25

[Johannes Hirte]

https://bugs.kde.org/show_bug.cgi?id=376505

Johannes Hirte  changed:

   What|Removed |Added

 CC||johannes.hirte@datenkhaos.d
   ||e

--- Comment #4 from Johannes Hirte  ---
This one was already fixed by commit 03f4f972d6c3ed03eab04c889248d089d317d370
but reverted later with commit a1f21f3ceac5315f2bfed8e9fa739d71ae2c6f10

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 376505] kwin compile error in Gentoo gcc-6.3.0, glibc-2.25

[Ясен]

https://bugs.kde.org/show_bug.cgi?id=376505

--- Comment #3 from Ясен  ---
(In reply to Martin Gräßlin from comment #1)
> Please figure out which header file needs to be included for major and
> include that in logind.cpp. It compiles on my system, thus I cannot help
> there.

Well thank you.

* The inclusion of  by  is deprecated.
  This means that in a future release, the macros “major”, “minor”, and
  “makedev” will only be available from .

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 376505] kwin compile error in Gentoo gcc-6.3.0, glibc-2.25

[Ясен]

https://bugs.kde.org/show_bug.cgi?id=376505

--- Comment #2 from Ясен  ---
Created attachment 104110
  --> https://bugs.kde.org/attachment.cgi?id=104110=edit
for Gentoo

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 376505] kwin compile error in Gentoo gcc-6.3.0, glibc-2.25

[Martin Gräßlin]

https://bugs.kde.org/show_bug.cgi?id=376505

--- Comment #1 from Martin Gräßlin  ---
Please figure out which header file needs to be included for major and include
that in logind.cpp. It compiles on my system, thus I cannot help there.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 376505] kwin compile error in Gentoo gcc-6.3.0, glibc-2.25

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=376505

Christoph Feck  changed:

   What|Removed |Added

   Assignee|k...@davidedmundson.co.uk|kwin-bugs-n...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 376505] kwin compile error in Gentoo gcc-6.3.0, glibc-2.25

[Ясен]

https://bugs.kde.org/show_bug.cgi?id=376505

Ясен  changed:

   What|Removed |Added

Product|plasmashell |kwin
   Target Milestone|1.0 |---
  Component|general |general

-- 
You are receiving this mail because:
You are watching all bug changes.