[kwin] [Bug 407199] kwin_wayland crashes on startup in KWin::DrmOutput::updateCursor

2019-05-08 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=407199

Fabian Vogt  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 Resolution|--- |FIXED
  Latest Commit||https://commits.kde.org/kwi
   ||n/7804eb41d9548c36254097f23
   ||5324a3c57c6514f

--- Comment #6 from Fabian Vogt  ---
Git commit 7804eb41d9548c36254097f235324a3c57c6514f by Fabian Vogt.
Committed on 08/05/2019 at 17:15.
Pushed by fvogt into branch 'master'.

Fix crash due to dangling reference

Summary:
Returning a reference to a value on the stack is broken.
This caused kwin_wayland to crash in openQA with a nullptr deref.

Test Plan: Only build tested.

Reviewers: #kwin, zzag

Reviewed By: #kwin, zzag

Subscribers: kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D21085

M  +2-2plugins/platforms/drm/drm_output.cpp
M  +1-1plugins/platforms/drm/drm_output.h

https://commits.kde.org/kwin/7804eb41d9548c36254097f235324a3c57c6514f

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 407199] kwin_wayland crashes on startup in KWin::DrmOutput::updateCursor

2019-05-08 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=407199

--- Comment #5 from Fabian Vogt  ---
(In reply to Fabian Vogt from comment #4)
> > I cannot reproduce. What GPUs are present in openQA?
> 
> The VM is configured with virtio.
> 
> According to openQA, the failures started between 4725ece60 and 559c2e68d
> and 559c2e68d34309eaeed0f8d25204789522058a12 even touches the crashing
> codepath. So it's likely that commit introducing the crash.

Indeed, it's obviously broken. Fix submitted as
https://phabricator.kde.org/D21085.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 407199] kwin_wayland crashes on startup in KWin::DrmOutput::updateCursor

2019-05-08 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=407199

Fabian Vogt  changed:

   What|Removed |Added

  Component|wayland-generic |platform-drm

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 407199] kwin_wayland crashes on startup in KWin::DrmOutput::updateCursor

2019-05-08 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=407199

Fabian Vogt  changed:

   What|Removed |Added

Summary|cannot start Wayland|kwin_wayland crashes on
   |session on neon dev |startup in
   |unstable. coredumpctl   |KWin::DrmOutput::updateCurs
   |indicates kwin_wayland  |or
   |crash.  |

--- Comment #4 from Fabian Vogt  ---
> I cannot reproduce. What GPUs are present in openQA?

The VM is configured with virtio.

According to openQA, the failures started between 4725ece60 and 559c2e68d and
559c2e68d34309eaeed0f8d25204789522058a12 even touches the crashing codepath. So
it's likely that commit introducing the crash.

-- 
You are receiving this mail because:
You are watching all bug changes.