[kwin] [Bug 425233] Crash in KWaylandServer::ShadowInterfacePrivate::~ShadowInterfacePrivate
https://bugs.kde.org/show_bug.cgi?id=425233 Vlad Zahorodnii changed: What|Removed |Added Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas |ma/kwayland-server/commit/f |ma/kwayland-server/commit/2 |cfdab060edea0aa161b45b85fe9 |b1970754d96f92d3938f6912a75 |621bbee301e0|7c82ce00b49e --- Comment #11 from Vlad Zahorodnii --- Git commit 2b1970754d96f92d3938f6912a757c82ce00b49e by Vlad Zahorodnii. Committed on 21/09/2020 at 14:00. Pushed by vladz into branch 'Plasma/5.20'. Keep unreferenced buffers around One problem with delaying destruction of buffer objects is that the compositor may create a shadow that references defunct buffers. One way to fix that issue is to immediately destroy buffers. However, there is other way to address the issue - keep released buffers alive. If a buffer is kept alive by the client, then it will most likely be used again. It also simplifies buffer management. (cherry picked from commit fcfdab060edea0aa161b45b85fe9621bbee301e0) M +0-1src/server/buffer_interface.cpp https://invent.kde.org/plasma/kwayland-server/commit/2b1970754d96f92d3938f6912a757c82ce00b49e -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 425233] Crash in KWaylandServer::ShadowInterfacePrivate::~ShadowInterfacePrivate
https://bugs.kde.org/show_bug.cgi?id=425233 Vlad Zahorodnii changed: What|Removed |Added Latest Commit||https://invent.kde.org/plas ||ma/kwayland-server/commit/f ||cfdab060edea0aa161b45b85fe9 ||621bbee301e0 Status|CONFIRMED |RESOLVED Resolution|--- |FIXED --- Comment #10 from Vlad Zahorodnii --- Git commit fcfdab060edea0aa161b45b85fe9621bbee301e0 by Vlad Zahorodnii. Committed on 21/09/2020 at 13:58. Pushed by vladz into branch 'master'. Keep unreferenced buffers around One problem with delaying destruction of buffer objects is that the compositor may create a shadow that references defunct buffers. One way to fix that issue is to immediately destroy buffers. However, there is other way to address the issue - keep released buffers alive. If a buffer is kept alive by the client, then it will most likely be used again. It also simplifies buffer management. M +0-1src/server/buffer_interface.cpp https://invent.kde.org/plasma/kwayland-server/commit/fcfdab060edea0aa161b45b85fe9621bbee301e0 -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 425233] Crash in KWaylandServer::ShadowInterfacePrivate::~ShadowInterfacePrivate
https://bugs.kde.org/show_bug.cgi?id=425233 --- Comment #9 from Vlad Zahorodnii --- The problem is that KWaylandServer delays destruction of BufferInterface objects. This is a huge issue because kwayland-integration re-uses buffer objects in order to keep memory footprint as low as possible. So, if an application has destroyed a shadow and immediately creates a new shadow, it's highly possible that the new shadow will have references to defunct buffer objects, i.e. we have a use-after-free bug. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 425233] Crash in KWaylandServer::ShadowInterfacePrivate::~ShadowInterfacePrivate
https://bugs.kde.org/show_bug.cgi?id=425233 Vlad Zahorodnii changed: What|Removed |Added Status|REPORTED|CONFIRMED Ever confirmed|0 |1 -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 425233] Crash in KWaylandServer::ShadowInterfacePrivate::~ShadowInterfacePrivate
https://bugs.kde.org/show_bug.cgi?id=425233 Vlad Zahorodnii changed: What|Removed |Added CC||rai...@finke.cc --- Comment #8 from Vlad Zahorodnii --- *** Bug 426767 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 425233] Crash in KWaylandServer::ShadowInterfacePrivate::~ShadowInterfacePrivate
https://bugs.kde.org/show_bug.cgi?id=425233 --- Comment #7 from Aleix Pol --- I had it mid pubquiz :( #0 0x7f7deb1712c6 in KWaylandServer::BufferInterface::unref() (this=0x55af77408d90) at /home/apol/devel/frameworks/kwayland-server/src/server/buffer_interface.cpp:239 #1 0x7f7deb21724c in KWaylandServer::ShadowInterfacePrivate::~ShadowInterfacePrivate() (this=0x55af7759dde0) at /home/apol/devel/frameworks/kwayland-server/src/server/shadow_interface.cpp:337 #2 0x7f7deb21734c in KWaylandServer::ShadowInterfacePrivate::~ShadowInterfacePrivate() (this=0x55af7759dde0) at /home/apol/devel/frameworks/kwayland-server/src/server/shadow_interface.cpp:332 #3 0x7f7deb217efb in QScopedPointerDeleter::cleanup(KWaylandServer::ShadowInterfacePrivate*) (pointer=0x55af7759dde0) at /home/apol/devel/kde5/include/QtCore/qscopedpointer.h:60 #4 0x7f7deb217d20 in QScopedPointer >::~QScopedPointer() (this=0x55af772e8cb0) at /home/apol/devel/kde5/include/QtCore/qscopedpointer.h:107 #5 0x7f7deb217415 in KWaylandServer::ShadowInterface::~ShadowInterface() (this=0x55af772e8ca0) at /home/apol/devel/frameworks/kwayland-server/src/server/shadow_interface.cpp:354 #6 0x7f7deb21744c in KWaylandServer::ShadowInterface::~ShadowInterface() (this=0x55af772e8ca0) at /home/apol/devel/frameworks/kwayland-server/src/server/shadow_interface.cpp:354 #7 0x7f7deb216e86 in KWaylandServer::ShadowInterfacePrivate::org_kde_kwin_shadow_destroy_resource(QtWaylandServer::org_kde_kwin_shadow::Resource*) (this=0x55af7759dde0, resource=0x55af76bcf230) at /home/apol/devel/frameworks/kwayland-server/src/server/shadow_interface.cpp:246 #8 0x7f7deb27b56a in QtWaylandServer::org_kde_kwin_shadow::destroy_func(wl_resource*) (client_resource=0x55af775d6d80) at src/server/qwayland-server-shadow.cpp:320 #9 0x7f7deb0a7e90 in () at /usr/lib/libwayland-server.so.0 #10 0x7f7deb0a7f11 in wl_resource_destroy () at /usr/lib/libwayland-server.so.0 #11 0x7f7deb216e3d in KWaylandServer::ShadowInterfacePrivate::org_kde_kwin_shadow_destroy(QtWaylandServer::org_kde_kwin_shadow::Resource*) (this=0x55af7759dde0, resource=0x55af76bcf230) at /home/apol/devel/frameworks/kwayland-server/src/server/shadow_interface.cpp:240 #12 0x7f7deb27ba45 in QtWaylandServer::org_kde_kwin_shadow::handle_destroy(wl_client*, wl_resource*) (client=0x55af756ea500, resource=0x55af775d6d80) at src/server/qwayland-server-shadow.cpp:584 #13 0x7f7de87f2a8d in () at /usr/lib/libffi.so.7 #14 0x7f7de87f201b in () at /usr/lib/libffi.so.7 #15 0x7f7deb0abf62 in () at /usr/lib/libwayland-server.so.0 #16 0x7f7deb0a82dc in () at /usr/lib/libwayland-server.so.0 #17 0x7f7deb0a9faa in wl_event_loop_dispatch () at /usr/lib/libwayland-server.so.0 #18 0x7f7deb17faee in KWaylandServer::Display::Private::dispatch() (this=0x55af7390e840) at /home/apol/devel/frameworks/kwayland-server/src/server/display.cpp:135 #19 0x7f7deb186998 in KWaylandServer::Display::Private::installSocketNotifier()::$_0::operator()() const (this=0x55af74476e10) at /home/apol/devel/frameworks/kwayland-server/src/server/display.cpp:104 #20 0x7f7deb186946 in QtPrivate::FunctorCall, QtPrivate::List<>, void, KWaylandServer::Display::Private::installSocketNotifier()::$_0>::call(KWaylandServer::Display::Private::installSocketNotifier()::$_0&, void**) (f=..., arg=0x7fff1566e930) at /home/apol/devel/kde5/include/QtCore/qobjectdefs_impl.h:146 #21 0x7f7deb186911 in QtPrivate::Functor::call, void>(KWaylandServer::Display::Private::installSocketNotifier()::$_0&, void*, void**) (f=..., arg=0x7fff1566e930) at /home/apol/devel/kde5/include/QtCore/qobjectdefs_impl.h:256 #22 0x7f7deb1868bc in QtPrivate::QFunctorSlotObject, void>::impl(int, QtPrivate::QSlotObjectBase*, QObject*, void**, bool*) (which=1, this_=0x55af74476e00, r=0x55af7390e720, a=0x7fff1566e930, ret=0x0) at /home/apol/devel/kde5/include/QtCore/qobjectdefs_impl.h:443 #23 0x7f7de9d1cb06 in QtPrivate::QSlotObjectBase::call(QObject*, void**) (a=0x7fff1566e930, r=0x55af7390e720, this=0x55af74476e00) at ../../include/QtCore/../../../../../devel/frameworks/qt5/qtbase/src/corelib/kernel/qobjectdefs_impl.h:398 #24 doActivate(QObject*, int, void**) (sender=0x55af74476e60, signal_index=3, argv=argv@entry=0x7fff1566e930) at /home/apol/devel/frameworks/qt5/qtbase/src/corelib/kernel/qobject.cpp:3886 #25 0x7f7de9d15e60 in QMetaObject::activate(QObject*, QMetaObject const*, int, void**) (sender=sender@entry=0x55af74476e60, m=m@entry=0x7f7de9fb6140 , local_signal_index=local_signal_index@entry=0, argv=argv@entry=0x7fff1566e930) at /home/apol/devel/frameworks/qt5/qtbase/src/corelib/kernel/qobject.cpp:3946 #26 0x7f7de9d1ff3f in QSocketNotifier::activated(QSocketDescriptor, QSocketNotifier::Type, QSocketNotifier::QPrivateSignal) (this=this@entry=0x55af74476e60, _t1=..., _t2=, _t3=...) at .moc/moc_qsocketnotifier.cpp:178 #27 0x7f7de9d2073b in QSocketNotifier::event(QEvent*) (this=0x55af74476e60,
[kwin] [Bug 425233] Crash in KWaylandServer::ShadowInterfacePrivate::~ShadowInterfacePrivate
https://bugs.kde.org/show_bug.cgi?id=425233 --- Comment #6 from Aleix Pol --- It definitely happens often with KDevelop popups. But then it might just be because it's one of the apps I use the most. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 425233] Crash in KWaylandServer::ShadowInterfacePrivate::~ShadowInterfacePrivate
https://bugs.kde.org/show_bug.cgi?id=425233 --- Comment #5 from Aleix Pol --- I think it was a KDevelop tooltip last thing I saw. In the end it's hard to tell, since it happens when moving the cursor over the screen. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 425233] Crash in KWaylandServer::ShadowInterfacePrivate::~ShadowInterfacePrivate
https://bugs.kde.org/show_bug.cgi?id=425233 --- Comment #4 from Vlad Zahorodnii --- My wild guess is that a popup window, e.g. a tooltip or a context menu, got dismissed. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 425233] Crash in KWaylandServer::ShadowInterfacePrivate::~ShadowInterfacePrivate
https://bugs.kde.org/show_bug.cgi?id=425233 --- Comment #3 from Vlad Zahorodnii --- Do you remember what application was active at the moment of the crash? -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 425233] Crash in KWaylandServer::ShadowInterfacePrivate::~ShadowInterfacePrivate
https://bugs.kde.org/show_bug.cgi?id=425233 --- Comment #2 from Vlad Zahorodnii --- > Still getting it: Have you found a way to reproduce the bug? -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 425233] Crash in KWaylandServer::ShadowInterfacePrivate::~ShadowInterfacePrivate
https://bugs.kde.org/show_bug.cgi?id=425233 --- Comment #1 from Aleix Pol --- Still getting it: Program terminated with signal SIGSEGV, Segmentation fault. #0 0x7f565fc1b2a6 in KWaylandServer::BufferInterface::unref (this=0x55c15efe8e90) at /home/apol/devel/frameworks/kwayland-server/src/server/buffer_interface.cpp:239 239 Q_ASSERT(d->refCount > 0); [Current thread is 1 (Thread 0x7f565a391d80 (LWP 628))] (gdb) where #0 0x7f565fc1b2a6 in KWaylandServer::BufferInterface::unref() (this=0x55c15efe8e90) at /home/apol/devel/frameworks/kwayland-server/src/server/buffer_interface.cpp:239 #1 0x7f565fcbd8fc in KWaylandServer::ShadowInterfacePrivate::~ShadowInterfacePrivate() (this=0x55c15f643500) at /home/apol/devel/frameworks/kwayland-server/src/server/shadow_interface.cpp:337 #2 0x7f565fcbd9fc in KWaylandServer::ShadowInterfacePrivate::~ShadowInterfacePrivate() (this=0x55c15f643500) at /home/apol/devel/frameworks/kwayland-server/src/server/shadow_interface.cpp:332 #3 0x7f565fcbe5ab in QScopedPointerDeleter::cleanup(KWaylandServer::ShadowInterfacePrivate*) (pointer=0x55c15f643500) at /home/apol/devel/kde5/include/QtCore/qscopedpointer.h:60 #4 0x7f565fcbe3d0 in QScopedPointer >::~QScopedPointer() (this=0x55c15f05cb50) at /home/apol/devel/kde5/include/QtCore/qscopedpointer.h:107 #5 0x7f565fcbdac5 in KWaylandServer::ShadowInterface::~ShadowInterface() (this=0x55c15f05cb40) at /home/apol/devel/frameworks/kwayland-server/src/server/shadow_interface.cpp:354 #6 0x7f565fcbdafc in KWaylandServer::ShadowInterface::~ShadowInterface() (this=0x55c15f05cb40) at /home/apol/devel/frameworks/kwayland-server/src/server/shadow_interface.cpp:354 #7 0x7f565fcbd536 in KWaylandServer::ShadowInterfacePrivate::org_kde_kwin_shadow_destroy_resource(QtWaylandServer::org_kde_kwin_shadow::Resource*) (this=0x55c15f643500, resource=0x55c15f778790) at /home/apol/devel/frameworks/kwayland-server/src/server/shadow_interface.cpp:246 #8 0x7f565fd224ca in QtWaylandServer::org_kde_kwin_shadow::destroy_func(wl_resource*) (client_resource=0x7f5648029f30) at src/server/qwayland-server-shadow.cpp:320 #9 0x7f565d3c4e90 in () at /usr/lib/libwayland-server.so.0 #10 0x7f565d3c4f11 in wl_resource_destroy () at /usr/lib/libwayland-server.so.0 #11 0x7f565fcbd4ed in KWaylandServer::ShadowInterfacePrivate::org_kde_kwin_shadow_destroy(QtWaylandServer::org_kde_kwin_shadow::Resource*) (this=0x55c15f643500, resource=0x55c15f778790) at /home/apol/devel/frameworks/kwayland-server/src/server/shadow_interface.cpp:240 #12 0x7f565fd229a5 in QtWaylandServer::org_kde_kwin_shadow::handle_destroy(wl_client*, wl_resource*) (client=0x55c15f58f550, resource=0x7f5648029f30) at src/server/qwayland-server-shadow.cpp:584 #13 0x7f565a950a8d in () at /usr/lib/libffi.so.7 #14 0x7f565a95001b in () at /usr/lib/libffi.so.7 #15 0x7f565d3c8f62 in () at /usr/lib/libwayland-server.so.0 #16 0x7f565d3c52dc in () at /usr/lib/libwayland-server.so.0 #17 0x7f565d3c6faa in wl_event_loop_dispatch () at /usr/lib/libwayland-server.so.0 #18 0x7f565fc29ace in KWaylandServer::Display::Private::dispatch() (this=0x55c15d9b5da0) at /home/apol/devel/frameworks/kwayland-server/src/server/display.cpp:134 #19 0x7f565fc30768 in KWaylandServer::Display::Private::installSocketNotifier()::$_0::operator()() const (this=0x55c15e35e940) at /home/apol/devel/frameworks/kwayland-server/src/server/display.cpp:103 #20 0x7f565fc30716 in QtPrivate::FunctorCall, QtPrivate::List<>, void, KWaylandServer::Display::Private::installSocketNotifier()::$_0>::call(KWaylandServer::Display::Private::installSocketNotifier()::$_0&, void**) (f=..., arg=0x7ffc04e31ad0) at /home/apol/devel/kde5/include/QtCore/qobjectdefs_impl.h:146 #21 0x7f565fc306e1 in QtPrivate::Functor::call, void>(KWaylandServer::Display::Private::installSocketNotifier()::$_0&, void*, void**) (f=..., arg=0x7ffc04e31ad0) at /home/apol/devel/kde5/include/QtCore/qobjectdefs_impl.h:256 #22 0x7f565fc3068c in QtPrivate::QFunctorSlotObject, void>::impl(int, QtPrivate::QSlotObjectBase*, QObject*, void**, bool*) (which=1, this_=0x55c15e35e930, r=0x55c15d9b5c80, a=0x7ffc04e31ad0, ret=0x0) at /home/apol/devel/kde5/include/QtCore/qobjectdefs_impl.h:443 #23 0x7f565e7c3b06 in QtPrivate::QSlotObjectBase::call(QObject*, void**) (a=0x7ffc04e31ad0, r=0x55c15d9b5c80, this=0x55c15e35e930) at ../../include/QtCore/../../../../../devel/frameworks/qt5/qtbase/src/corelib/kernel/qobjectdefs_impl.h:398 #24 doActivate(QObject*, int, void**) (sender=0x55c15e35e8e0, signal_index=3, argv=argv@entry=0x7ffc04e31ad0) at /home/apol/devel/frameworks/qt5/qtbase/src/corelib/kernel/qobject.cpp:3886 #25 0x7f565e7bce60 in QMetaObject::activate(QObject*, QMetaObject const*, int, void**) (sender=sender@entry=0x55c15e35e8e0, m=m@entry=0x7f565ea5d140 , local_signal_index=local_signal_index@entry=0, argv=argv@entry=0x7ffc04e31ad0) at
[kwin] [Bug 425233] Crash in KWaylandServer::ShadowInterfacePrivate::~ShadowInterfacePrivate
https://bugs.kde.org/show_bug.cgi?id=425233 Andrey changed: What|Removed |Added CC||butir...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 425233] Crash in KWaylandServer::ShadowInterfacePrivate::~ShadowInterfacePrivate
https://bugs.kde.org/show_bug.cgi?id=425233 Aleix Pol changed: What|Removed |Added Summary|Crash in the shadow class |Crash in ||KWaylandServer::ShadowInter ||facePrivate::~ShadowInterfa ||cePrivate -- You are receiving this mail because: You are watching all bug changes.
