[libalkimia] [Bug 483138] Better customization options when selecting the retrieval type
https://bugs.kde.org/show_bug.cgi?id=483138 Ralf Habacker changed: What|Removed |Added Version Fixed In||8.2 Resolution|--- |FIXED Latest Commit||https://invent.kde.org/offi ||ce/alkimia/-/commit/2320385 ||4264b5837939be9e7bb0bb4d19e ||9915df Status|ASSIGNED|RESOLVED --- Comment #5 from Ralf Habacker --- Git commit 23203854264b5837939be9e7bb0bb4d19e9915df by Ralf Habacker. Committed on 27/03/2024 at 18:00. Pushed by habacker into branch 'master'. Add download type to class AlkOnlineQuote[Source] and in ui With this commit one instance of class AlkWebPage is used for downloading and showing the html content, which fixed bug 479440. Related: bug 479440 FIXED-IN:8.2 M +11 -7autotests/alkonlinequotetest.cpp M +1-1autotests/alkonlinequotetest.h M +7-5src/alkonlinequote.cpp M +55 -54 src/alkonlinequote_p.cpp M +5-5src/alkonlinequote_p.h M +120 -111 src/alkonlinequotedetails.ui M +31 -1src/alkonlinequotesource.cpp M +11 -2src/alkonlinequotesource.h M +18 -17 src/alkonlinequotesource_p.h M +25 -1src/alkonlinequotesprofile_p.cpp M +2-0src/alkonlinequotesprofile_p.h M +11 -0src/alkonlinequoteswidget.cpp https://invent.kde.org/office/alkimia/-/commit/23203854264b5837939be9e7bb0bb4d19e9915df -- You are receiving this mail because: You are watching all bug changes.
[libalkimia] [Bug 483138] Better customization options when selecting the retrieval type
https://bugs.kde.org/show_bug.cgi?id=483138 --- Comment #4 from Ralf Habacker --- Git commit 22cf1b34229bad8ea2d8d1eaa7b31439f0c2ae86 by Ralf Habacker. Committed on 27/03/2024 at 18:00. Pushed by habacker into branch 'master'. Add class AlkDownloadEngine with associated unit tests FIXED-IN:8.2 M +1-0CMakeLists.txt M +31 -4autotests/CMakeLists.txt A +221 -0autotests/alkdownloadenginetest.cpp [License: LGPL(v2.1+)] A +33 -0autotests/alkdownloadenginetest.h [License: LGPL(v2.1+)] M +3-0src/CMakeLists.txt A +344 -0src/alkdownloadengine.cpp [License: LGPL(v2.1+)] A +122 -0src/alkdownloadengine.h [License: LGPL(v2.1+)] M +61 -239 src/alkonlinequote_p.cpp M +8-13 src/alkonlinequote_p.h M +3-0src/alktestdefs.h M +26 -1src/alkwebpage.cpp M +3-0src/alkwebpage.h https://invent.kde.org/office/alkimia/-/commit/22cf1b34229bad8ea2d8d1eaa7b31439f0c2ae86 -- You are receiving this mail because: You are watching all bug changes.
[libalkimia] [Bug 483138] Better customization options when selecting the retrieval type
https://bugs.kde.org/show_bug.cgi?id=483138 Bug Janitor Service changed: What|Removed |Added Ever confirmed|0 |1 Status|REPORTED|ASSIGNED --- Comment #3 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/office/alkimia/-/merge_requests/28 -- You are receiving this mail because: You are watching all bug changes.
[libalkimia] [Bug 483138] Better customization options when selecting the retrieval type
https://bugs.kde.org/show_bug.cgi?id=483138 --- Comment #2 from Ralf Habacker --- With this refactoring, the associated unit tests should be separated in order to be able to determine more precisely which one fails. -- You are receiving this mail because: You are watching all bug changes.
[libalkimia] [Bug 483138] Better customization options when selecting the retrieval type
https://bugs.kde.org/show_bug.cgi?id=483138 --- Comment #1 from Ralf Habacker --- (In reply to Ralf Habacker from comment #0) > The selection of this type of retrieval > is currently realized via a '.webkit' suffix in the name of the respective > online source. Also the suffix '.webkit' does not match the engine used with webengine enabled. -- You are receiving this mail because: You are watching all bug changes.
