https://bugs.kde.org/show_bug.cgi?id=374445
Bug ID: 374445 Summary: Calls to CycleStreets API are sometimes incomplete Product: marble Version: unspecified Platform: Other OS: All Status: UNCONFIRMED Severity: normal Priority: NOR Component: data Assignee: marble-b...@kde.org Reporter: kdeb...@cyclestreets.net Target Milestone: --- Hi, I'm writing from CycleStreets, whose API you have kindly integrated for bicycle routing: http://commits.kde.org/marble/af22018eb38e7ff48b10ab0a131809a342db8a1c We get plenty of requests from Marble users, which is great, but amongst a small percentage of these, we noticed that some fail due to incomplete parameters. For instance, we sometimes receive an API request like this: /api/journey.xml?itinerarypoints=11.431882,44.465502%7C11.437141,44.519076&key=cdccf13997d59e70&plan&speed&useDom=1 (prefix this with http://www.cyclestreets.net ) As you can see, the plan and speed parameters are missing. The correct version of this request would be: /api/journey.xml?itinerarypoints=11.431882,44.465502%7C11.437141,44.519076&key=cdccf13997d59e70&plan=balanced&speed=20&useDom=1 Sensible defaults would be plan=balanced and speed=20, which are what the API will default to if no parameter is specified. But above the request specifies each parameter but with an empty value, hence the failure. I myself can't see in the code what is causing the missing parameters: https://github.com/KDE/marble/search?q=cyclestreets (P.S. I will file a separate issue report on a couple of potential improvements you could make for the API calls.) -- You are receiving this mail because: You are watching all bug changes.