[neon] [Bug 445813] KDE proxy settings are not picked up by libproxy

2021-11-22 Thread Malte S. Stretz
https://bugs.kde.org/show_bug.cgi?id=445813

--- Comment #5 from Malte S. Stretz  ---
I opened https://github.com/libproxy/libproxy/pull/166 and asked it to be
switched over to kf5-config instead of qtpaths. I guess the reason this is used
is that the plugin wants to pick up the global config in /etc/xdg as well and
doesn't want to hard code a default path. Since it is executed only once and
kreadconfig5 is called lots of times without it this should be an improvement
already.

I the end I think a call to D-Bus would be the best approach but this should be
a low-hanging fruit.

-- 
You are receiving this mail because:
You are watching all bug changes.

[neon] [Bug 445813] KDE proxy settings are not picked up by libproxy

2021-11-22 Thread Harald Sitter
https://bugs.kde.org/show_bug.cgi?id=445813

--- Comment #4 from Harald Sitter  ---
Seems excessive to fork a binary for that.  They'd only need to construct paths
from $XDG_CONFIG_HOME:$XDG_CONFIG_DIRS vars, shouldn't be too much code to
implement that natively.

Alternatively they could just ask us to provide a helper binary kfindconfigs5
to list the paths ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

[neon] [Bug 445813] KDE proxy settings are not picked up by libproxy

2021-11-21 Thread Malte S. Stretz
https://bugs.kde.org/show_bug.cgi?id=445813

--- Comment #3 from Malte S. Stretz  ---
(In reply to Harald Sitter from comment #2)
> qtpaths is a developer tool, it really shouldn't be called by runtime code.
> seeing as it appears not functionally required I guess we can just ignore it.

If that's the case I guess I'll open a libproxy issue then. If I read the
historical issues correctly while debugging this it looks like somebody once
reported a performance issue with libproxy (because it calls kreadconfig5 for
each request) and the output from qtpaths is used to find the kioslaverc file
and invalidate the cache if it changes (or not cache at all if none was found):
https://github.com/libproxy/libproxy/blob/49bc258fd56db6ee0518058129f8fdc7f35a57e8/libproxy/modules/config_kde.cpp#L49
https://github.com/libproxy/libproxy/blob/49bc258fd56db6ee0518058129f8fdc7f35a57e8/libproxy/modules/config_kde.cpp#L201
https://github.com/libproxy/libproxy/blob/49bc258fd56db6ee0518058129f8fdc7f35a57e8/libproxy/modules/config_kde.cpp#L210

-- 
You are receiving this mail because:
You are watching all bug changes.

[neon] [Bug 445813] KDE proxy settings are not picked up by libproxy

2021-11-21 Thread Harald Sitter
https://bugs.kde.org/show_bug.cgi?id=445813

--- Comment #2 from Harald Sitter  ---
qtpaths is a developer tool, it really shouldn't be called by runtime code.
seeing as it appears not functionally required I guess we can just ignore it.

-- 
You are receiving this mail because:
You are watching all bug changes.

[neon] [Bug 445813] KDE proxy settings are not picked up by libproxy

2021-11-20 Thread Malte S. Stretz
https://bugs.kde.org/show_bug.cgi?id=445813

--- Comment #1 from Malte S. Stretz  ---
Duh. As so often, I found that part of the issue is actually sitting in front
of the screen: libproxy picks up the KDE settings totally fine as long as (a)
the additonal package is installed and (b) the `proxy` test tool is executed
properly. The following command actually gives me the proper result (a full URL
is required, not only a hostname):

proxy <<< https://example.com

Feel free to close this report but there are two things I noticed while
debugging this:

(a) That additional package is required. I think it would make sense to install
it (at least via a recommends dependency) on KDE neon per default
(b) While stracing and looking at the code I saw that `qtpaths` is called at
some point and some cache is maintained based on the result, if any. On my
machine there is a `qtpaths` executable available but it seems to be some kind
of multiplexer which doesn't find its actual implementation, cf. below. I
didn't modify any global Qt related configs, this a standard KDE neon in
regards to that (though upgraded from 18.04 at some point).

# qtpaths --paths GenericConfigLocation
/usr/lib/qt5/bin/qtpaths: command not found
qtpaths: could not find a Qt installation of ''

-- 
You are receiving this mail because:
You are watching all bug changes.