[okular] [Bug 376574] Linked video in pdf doesn't work

[Miklos Vajna]

https://bugs.kde.org/show_bug.cgi?id=376574

--- Comment #5 from Miklos Vajna  ---
Thanks a lot! :-)

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 376574] Linked video in pdf doesn't work

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=376574

Albert Astals Cid  changed:

   What|Removed |Added

  Latest Commit||https://commits.kde.org/oku
   ||lar/ee7e3737f4d2031e9bac9f5
   ||a25ac0b31c2f5e496
 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

--- Comment #4 from Albert Astals Cid  ---
Git commit ee7e3737f4d2031e9bac9f5a25ac0b31c2f5e496 by Albert Astals Cid.
Committed on 20/02/2017 at 00:06.
Pushed by aacid into branch 'Applications/16.12'.

Account for non local non relative video file urls

M  +22   -32   ui/videowidget.cpp

https://commits.kde.org/okular/ee7e3737f4d2031e9bac9f5a25ac0b31c2f5e496

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 376574] Linked video in pdf doesn't work

[Oliver Sander]

https://bugs.kde.org/show_bug.cgi?id=376574

--- Comment #3 from Oliver Sander  ---
The problem is in the file videowidget.cpp, in the method
VideoWidget::Private::load().

There, starting in line 110 is says

QString url = movie->url();

Here, url is the movie location, namely http:/vmiklos.hu/file/small.mp4

The code continues:

QUrl newurl;
if ( QDir::isRelativePath( url ) )
{
newurl = document->currentDocument().adjusted(QUrl::RemoveFilename);
newurl.setPath( newurl.path() + url );
}

and sure enough, QDir::isRelativePath takes the content of 'url' to be a
relative path, because it does not start with '/'.   Hence the 'if' branch is
taken, and the document path is prepended to the movie part. Seems like the
code was not written with internet movies in mind.

Strangely enough, the code continues:

if ( newurl.isLocalFile() )
player->load( newurl );
else
player->load( newurl );

Surely that's not right?  Martin, you introduced this in d8fdb1494 , can you
please have a look?

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 376574] Linked video in pdf doesn't work

[Oliver Sander]

https://bugs.kde.org/show_bug.cgi?id=376574

Oliver Sander  changed:

   What|Removed |Added

 CC||oliver.san...@tu-dresden.de

--- Comment #2 from Oliver Sander  ---
Confirmed, both with 0.26.1 from Debian Testing and with the current git
master.

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 376574] Linked video in pdf doesn't work

[Miklos Vajna]

https://bugs.kde.org/show_bug.cgi?id=376574

--- Comment #1 from Miklos Vajna  ---
Console output:

[7f613c00dce8] filesystem access error: cannot open file
//home/vmiklos//home/vmiklos/http:/vmiklos.hu/file/small.mp4 (No such file or
directory)
[7f613c00dce8] core access error: File reading failed
[7f613c00dce8] core access error: VLC could not open the file
"//home/vmiklos//home/vmiklos/http:/vmiklos.hu/file/small.mp4" (No such file or
directory).
[01af96b8] core input error: open of
`file:home/vmiklos//home/vmiklos/http:/vmiklos.hu/file/small.mp4' failed
[01af96b8] core input error: Your input can't be opened
[01af96b8] core input error: VLC is unable to open the MRL
'file:home/vmiklos//home/vmiklos/http:/vmiklos.hu/file/small.mp4'. Check
the log for details.

Looks like it tries to convert http://vmiklos.hu/file/small.mp4 to a relative
file:/// URL.

-- 
You are receiving this mail because:
You are watching all bug changes.