[plasma-nm] [Bug 435561] Cannot specify usergroup for OpenConnect VPNs

2021-04-15 Thread Jan Grulich
https://bugs.kde.org/show_bug.cgi?id=435561

Jan Grulich  changed:

   What|Removed |Added

   Version Fixed In||5.21.5

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-nm] [Bug 435561] Cannot specify usergroup for OpenConnect VPNs

2021-04-15 Thread Jan Grulich
https://bugs.kde.org/show_bug.cgi?id=435561

Jan Grulich  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/plas
   ||ma/plasma-nm/commit/aa872ec
   ||a0575af615ca918acbb1c8e743d
   ||1074d5
 Status|ASSIGNED|RESOLVED

--- Comment #8 from Jan Grulich  ---
Git commit aa872eca0575af615ca918acbb1c8e743d1074d5 by Jan Grulich, on behalf
of Aaron Barany.
Committed on 15/04/2021 at 07:55.
Pushed by grulich into branch 'Plasma/5.21'.

Forward opeconnect usergroup

Forward the usergroup for openconnect (provided by the URL path) to the
NetworkManager service by incorporating it in NM_OPENCONNECT_KEY_GATEWAY.
This ensures that the VPN session in the NetworkManager service uses the
same usergroup as provided with the gateway when the initial connection
was made through the UI.

M  +7-1vpn/openconnect/openconnectauth.cpp

https://invent.kde.org/plasma/plasma-nm/commit/aa872eca0575af615ca918acbb1c8e743d1074d5

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-nm] [Bug 435561] Cannot specify usergroup for OpenConnect VPNs

2021-04-14 Thread akb825
https://bugs.kde.org/show_bug.cgi?id=435561

--- Comment #7 from akb825  ---
I have submitted an MR here:
https://invent.kde.org/plasma/plasma-nm/-/merge_requests/57

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-nm] [Bug 435561] Cannot specify usergroup for OpenConnect VPNs

2021-04-14 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=435561

Bug Janitor Service  changed:

   What|Removed |Added

 Status|REPORTED|ASSIGNED
 Ever confirmed|0   |1

--- Comment #6 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/plasma/plasma-nm/-/merge_requests/57

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-nm] [Bug 435561] Cannot specify usergroup for OpenConnect VPNs

2021-04-14 Thread Jan Grulich
https://bugs.kde.org/show_bug.cgi?id=435561

Jan Grulich  changed:

   What|Removed |Added

 CC||jgrul...@redhat.com

--- Comment #5 from Jan Grulich  ---
Hi, can you submit your patch to review? 

Link: https://invent.kde.org/plasma/plasma-nm/-/merge_requests

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-nm] [Bug 435561] Cannot specify usergroup for OpenConnect VPNs

2021-04-13 Thread akb825
https://bugs.kde.org/show_bug.cgi?id=435561

--- Comment #4 from akb825  ---
Further investigation confirms that the patch I posted should fix the issue on
the plasma-nm side of not forwarding the usergroup, while separate issues in
NetworkManager-openconnect (related to the split routing) are the cause of the
timeout issue.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-nm] [Bug 435561] Cannot specify usergroup for OpenConnect VPNs

2021-04-13 Thread akb825
https://bugs.kde.org/show_bug.cgi?id=435561

--- Comment #3 from akb825  ---
Created attachment 137574
  --> https://bugs.kde.org/attachment.cgi?id=137574=edit
usergroup.patch

I went through the code and I believe the main problem is that only the host +
port is passed to the NetworkManager-openconnect plugin that establishes the
"real" connection to the VPN. I have attached a patch (usergroup.patch) that
appends the urlpath (which is parsed as the usergroup) to the
NM_OPENCONNECT_KEY_GATEWAY secrets parameter when it's provided.

This allows the connection to be established with the pulse protocol (since it
was using the incorrect URL for the cookie). However, similar to my previous
results with the "Juniper Network Connect" protocol all network activity that's
routed through the VPN times out. My guess is there's some additional issues in
NetworkManager-openconnect that's preventing it from working properly.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-nm] [Bug 435561] Cannot specify usergroup for OpenConnect VPNs

2021-04-13 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=435561

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-nm] [Bug 435561] Cannot specify usergroup for OpenConnect VPNs

2021-04-09 Thread akb825
https://bugs.kde.org/show_bug.cgi?id=435561

akb825  changed:

   What|Removed |Added

 CC||akb...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-nm] [Bug 435561] Cannot specify usergroup for OpenConnect VPNs

2021-04-09 Thread akb825
https://bugs.kde.org/show_bug.cgi?id=435561

--- Comment #2 from akb825  ---
After some more experimentation, the behavior of whether the dialog disappears
and openconnect writes the cookie error to the journal, or whether it has the
"unknown code" error in the dialog, appears to be inconsistent. In other words,
relying on parsing the group from the gateway and using the xmlconfig gives the
same results.

This behavior was using the "Pulse Connect Secure" protocol. When using the
"Juniper Network Connect" protocol any connection over the VPN times out when
providing the usergroup. (even ones that give a forbidden error when not
connected to the VPN at all)

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-nm] [Bug 435561] Cannot specify usergroup for OpenConnect VPNs

2021-04-09 Thread akb825
https://bugs.kde.org/show_bug.cgi?id=435561

--- Comment #1 from akb825  ---
After looking through the code, it looks like it *is* trying to parse the group
from the gateway. However, attempting to do this fails to connect. No error is
reported in the UI, it simply closes the dialog and isn't connected to the VPN.
When viewing the log from journalctl, openconnect reported the error "Pulse
authentication cookie not accepted". Using the exact same URL (copy/pasted to
avoid typos) works with the openconnect command in a terminal.

I additionally found that you can set an "xmlconfig" element in vpn-secrets
section with a base64 XML configuration. When attempting to set the 
tag, I get the following error in the UI: "Pulse password request with unknown
code 0x00. Please report."

-- 
You are receiving this mail because:
You are watching all bug changes.