[plasma-pa] [Bug 391692] Multimedia/Audio Volume KCM: use of QtQuickControls1 and/or PlasmaComponents labels causes blurry pixellated text with non-integer scale factors

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=391692

Nate Graham  changed:

   What|Removed |Added

   Version Fixed In||Qt 5.11
URL||https://bugreports.qt.io/br
   ||owse/QTBUG-67007
 Resolution|--- |UPSTREAM
 Status|UNCONFIRMED |RESOLVED

--- Comment #3 from Nate Graham  ---
Fixed upstream in https://bugreports.qt.io/browse/QTBUG-67007

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-pa] [Bug 391692] Multimedia/Audio Volume KCM: use of QtQuickControls1 and/or PlasmaComponents labels causes blurry pixellated text with non-integer scale factors

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=391692

--- Comment #2 from Nate Graham  ---
Git commit a21bc11fe11651f6d211489ebfc8435cef877194 by Nathaniel Graham.
Committed on 16/03/2018 at 22:26.
Pushed by ngraham into branch 'master'.

Fix text scaling with non-integer scale factors when PLASMA_USE_QT_SCALING=1 is
set

Summary:
When `PLASMA_USE_QT_SCALING=1` is set, Plasma uses native Qt scaling. This
works fine for integer scale factors, and fixes a lot of bugs (see
[[https://bugs.kde.org/show_bug.cgi?id=356446|Bug 356446]]) but it introduces a
new one: with non-integer scale factors, text becomes blurry and pixellated
because of a bug in `Text.NativeRendering`:
https://bugreports.qt.io/browse/QTBUG-67007

QQC2-desktop-style forces the use of `Text.QtRendering` rendering for
non-integer scale factors, successfully working around the problem. But
PlasmaComponents QML objects don't implement the same workaround, so we see the
issue in Plasma. This patch fixes that, and gets us one step closer to being
able to use Qt scaling in Plasmashell.

There is no effect when `PLASMA_USE_QT_SCALING=1` is not being used.

FIXED-IN 5.13
Related: bug 391691, bug 384031, bug 386216, bug 391695, bug 391694, bug
385547, bug 356446

Test Plan:
Before: `PLASMA_USE_QT_SCALING=1` set, 1.2 scale factor: Plasma text looks
awful:
{F5749797}

After: `PLASMA_USE_QT_SCALING=1` set, 1.2 scale factor: Plasma text looks
amazing!
{F5749798}

Note that we still get sub-pixel anti-aliasing and good kerning. There appear
to be no layout regressions.

Without both `PLASMA_USE_QT_SCALING=1` and a non-integer scale factor set,
there is no visual change compared to the status quo.

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: mart, broulik, #frameworks

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D11244

M  +4-2examples/applets/testtheme/contents/ui/FontGizmo.qml
M  +5-1src/declarativeimports/plasmacomponents/qml/Label.qml
M  +5-1   
src/declarativeimports/plasmacomponents/qml/private/DualStateButton.qml
M  +4-0src/declarativeimports/plasmacomponents3/ComboBox.qml
M  +5-1src/declarativeimports/plasmacomponents3/Label.qml
M  +5-1src/declarativeimports/plasmacomponents3/TextArea.qml
M  +5-1src/declarativeimports/plasmacomponents3/TextField.qml
M  +5-0src/declarativeimports/plasmastyle/ComboBoxStyle.qml
M  +4-1src/declarativeimports/plasmastyle/SpinBoxStyle.qml
M  +4-1src/declarativeimports/plasmastyle/TextAreaStyle.qml
M  +4-1src/declarativeimports/plasmastyle/TextFieldStyle.qml

https://commits.kde.org/plasma-framework/a21bc11fe11651f6d211489ebfc8435cef877194

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-pa] [Bug 391692] Multimedia/Audio Volume KCM: use of QtQuickControls1 and/or PlasmaComponents labels causes blurry pixellated text with non-integer scale factors

[David Rosca]

https://bugs.kde.org/show_bug.cgi?id=391692

--- Comment #1 from David Rosca  ---
Non-integer scaling is not officially supported by Qt, QQC1 is not the only
thing that breaks, see https://doc.qt.io/qt-5/highdpi.html

In that sense, this bug is invalid, although it should be ported to QQC2 for
other reasons.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-pa] [Bug 391692] Multimedia/Audio Volume KCM: use of QtQuickControls1 and/or PlasmaComponents labels causes blurry pixellated text with non-integer scale factors

[Dr . Chapatin]

https://bugs.kde.org/show_bug.cgi?id=391692

Dr. Chapatin  changed:

   What|Removed |Added

 CC||bugsefor...@gmx.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-pa] [Bug 391692] Multimedia/Audio Volume KCM: use of QtQuickControls1 and/or PlasmaComponents labels causes blurry pixellated text with non-integer scale factors

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=391692

Nate Graham  changed:

   What|Removed |Added

Summary|Multimedia/Audio Volume |Multimedia/Audio Volume
   |KCM: use of |KCM: use of
   |QtQuickControls1 causes |QtQuickControls1 and/or
   |blurry pixellated text with |PlasmaComponents labels
   |non-integer scale factors   |causes blurry pixellated
   ||text with non-integer scale
   ||factors

-- 
You are receiving this mail because:
You are watching all bug changes.