[plasma-pa] [Bug 417607] Re-add manual port switching to the KCM

2020-03-03 Thread gvgeo 
https://bugs.kde.org/show_bug.cgi?id=417607

gvgeo  changed:

   What|Removed |Added

   Version Fixed In||5.19.0
 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED
  Latest Commit||https://commits.kde.org/pla
   ||sma-pa/606c6499750a1d776d73
   ||b052eab828dc5eedca07

--- Comment #5 from gvgeo  ---
Git commit 606c6499750a1d776d73b052eab828dc5eedca07 by George Vogiatzis.
Committed on 03/03/2020 at 17:49.
Pushed by gvgeo into branch 'master'.

[KCM]Update Device item layout based on applet

Summary:
Remove device icon.
Remove separation line between devices and increase spacing.
Use radioboxes for default device selection.
Always allow port selection.
Fix mute tooltip.
Use small spacing instead of default.
Use plasma components 3 instead of qtquick controls 2.
Remove unused imports.
Related: bug 417447
FIXED-IN: 5.19.0

Doesn't depend, but needs D27420 to activate an unavailable port.

Test Plan:
Before:
Was not possible to select an unavailable port.
Combobox could drive the default button out of the layout.
After:
Combobox row appears for devices that have at least two ports.

{F8106609}

Reviewers: #plasma, drosca, ngraham, #vdg

Reviewed By: ngraham, #vdg

Subscribers: davidedmundson, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27422

M  +66   -53   src/kcm/package/contents/ui/DeviceListItem.qml
M  +6-3src/kcm/package/contents/ui/Devices.qml
M  +2-1src/kcm/package/contents/ui/MuteButton.qml
M  +1-0src/kcm/package/contents/ui/StreamListItem.qml

https://commits.kde.org/plasma-pa/606c6499750a1d776d73b052eab828dc5eedca07

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-pa] [Bug 417607] Re-add manual port switching to the KCM

2020-02-15 Thread gvgeo 
https://bugs.kde.org/show_bug.cgi?id=417607

--- Comment #4 from gvgeo  ---
https://phabricator.kde.org/D27420 BugFix
https://phabricator.kde.org/D27422 Restore KCM

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-pa] [Bug 417607] Re-add manual port switching to the KCM

2020-02-14 Thread Nate Graham 
https://bugs.kde.org/show_bug.cgi?id=417607

Nate Graham  changed:

   What|Removed |Added

 CC||gv...@protonmail.com
  Component|applet  |kcm
 Ever confirmed|0   |1
 Status|NEEDSINFO   |CONFIRMED
Summary|No longer able to switch|Re-add manual port
   |ports   |switching to the KCM
 Resolution|WAITINGFORINFO  |---

--- Comment #3 from Nate Graham  ---
(In reply to David Polák from comment #2)
> It's a hardware issue, the detector is broken. Could it be added back, it
> doesn't have to be in the same location.
I'm tempted to say that using pavucontrol is an acceptable workaround in such
an edge-case scenario, but perhaps we should re-add the port selector in the
KCM, where we have more room. As you can see, we didn't consider this use case.
Perhaps we should have.

Our design goal was to de-clutter the System Tray popup as much as possible as
it was quite complicated and confusing for many people before. But maybe we can
accept a bit more power in the KCM.

George, what do you think?

-- 
You are receiving this mail because:
You are watching all bug changes.