[plasma-systemmonitor] [Bug 452581] Horizontal Bars style unable to show empty and low states

2022-05-05 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=452581 Nate Graham changed: What|Removed |Added Latest Commit||https://invent.kde.org/plas |

[plasma-systemmonitor] [Bug 452581] Horizontal Bars style unable to show empty and low states

2022-04-22 Thread Trent M
https://bugs.kde.org/show_bug.cgi?id=452581 --- Comment #9 from Trent M --- Created attachment 148302 --> https://bugs.kde.org/attachment.cgi?id=148302=edit Patch to Bar.qml to use smaller circles than the parent's height for low values, now clamping to values that fit evenly within parent.

[plasma-systemmonitor] [Bug 452581] Horizontal Bars style unable to show empty and low states

2022-04-22 Thread Trent M
https://bugs.kde.org/show_bug.cgi?id=452581 --- Comment #8 from Trent M --- I'm not sure if the bar can or can't have an odd-numbered height, but in my earlier implementation, the inner bar *could* have an odd-numbered height, which would result in more space on bottom than on top. I figured out

[plasma-systemmonitor] [Bug 452581] Horizontal Bars style unable to show empty and low states

2022-04-18 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=452581 --- Comment #7 from Nate Graham --- I don't think the bar can have an odd-numbered height... or if it can, that's a bug we should fix in our qqc2-desktop-style. So I don't think it's something you need to worry about per se. That said, it's good

[plasma-systemmonitor] [Bug 452581] Horizontal Bars style unable to show empty and low states

2022-04-18 Thread Trent M
https://bugs.kde.org/show_bug.cgi?id=452581 --- Comment #6 from Trent M --- (In reply to Nate Graham from comment #5) > Looks like a legitimate issue, and your change seems sane to me. Would you > be interested in submitting a merge request with it? I can help! Definitely! And I would very much

[plasma-systemmonitor] [Bug 452581] Horizontal Bars style unable to show empty and low states

2022-04-18 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=452581 Nate Graham changed: What|Removed |Added Keywords||usability Status|REPORTED

[plasma-systemmonitor] [Bug 452581] Horizontal Bars style unable to show empty and low states

2022-04-13 Thread Trent M
https://bugs.kde.org/show_bug.cgi?id=452581 Trent M changed: What|Removed |Added Attachment #148141|0 |1 is obsolete||

[plasma-systemmonitor] [Bug 452581] Horizontal Bars style unable to show empty and low states

2022-04-13 Thread Trent M
https://bugs.kde.org/show_bug.cgi?id=452581 --- Comment #3 from Trent M --- Created attachment 148141 --> https://bugs.kde.org/attachment.cgi?id=148141=edit Patch to Bar.qml to allow for using smaller circles than the parent's height for low values. -- You are receiving this mail because:

[plasma-systemmonitor] [Bug 452581] Horizontal Bars style unable to show empty and low states

2022-04-13 Thread Trent M
https://bugs.kde.org/show_bug.cgi?id=452581 --- Comment #2 from Trent M --- Created attachment 148140 --> https://bugs.kde.org/attachment.cgi?id=148140=edit Screenshot of horizontal bars after patch, using smaller circles for low values. -- You are receiving this mail because: You are

[plasma-systemmonitor] [Bug 452581] Horizontal Bars style unable to show empty and low states

2022-04-13 Thread Trent M
https://bugs.kde.org/show_bug.cgi?id=452581 --- Comment #1 from Trent M --- I did manage to come up with something. By centering the second rectangle vertically within the parent and then making the height the minimum between parent.height and width x percentage, it at least looks better than no