[plasmashell] [Bug 371576] AppIndicator GTK apps fail to find icons in custom GTK icon theme folder and crash

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=371576

David Edmundson  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

--- Comment #8 from David Edmundson  ---
Only open part of this bug was about 5.8, and that's not getting any changes
for this.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 371576] AppIndicator GTK apps fail to find icons in custom GTK icon theme folder and crash

[Alexander Mentyu]

https://bugs.kde.org/show_bug.cgi?id=371576

Alexander Mentyu  changed:

   What|Removed |Added

 CC||notux...@gmail.com

--- Comment #7 from Alexander Mentyu  ---
The app icons are looking ok in:

Plasma: 5.12.2
Apps: 17.12.2
Frameworks: 5.43.0
Qt: 5.10.1
Kernel: 4.14.20-2-MANJARO
OS: Netrunner Rolling
fcitx-4.2.9.6-1

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 371576] AppIndicator GTK apps fail to find icons in custom GTK icon theme folder and crash

[Marco Martin]

https://bugs.kde.org/show_bug.cgi?id=371576

--- Comment #6 from Marco Martin  ---
Created attachment 102104
  --> https://bugs.kde.org/attachment.cgi?id=102104=edit
application runnin showing the correct icon

Thanks.
I tried your application on master, but seems to work fine.
It starts good, the nvidia icon is shown, if i click "force nvidia off" the
icon gets replaced by the intel logo as expected.
On distro packages (5.8.0) no crash happens, but the icon is broken
so would need a bit of testing to make sure it's really ok in master and
current 5.8 branch

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 371576] AppIndicator GTK apps fail to find icons in custom GTK icon theme folder and crash

[André Brait]

https://bugs.kde.org/show_bug.cgi?id=371576

--- Comment #5 from André Brait  ---
Full >>>path<<< to the icon file, sorry for the typo.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 371576] AppIndicator GTK apps fail to find icons in custom GTK icon theme folder and crash

[André Brait]

https://bugs.kde.org/show_bug.cgi?id=371576

--- Comment #4 from André Brait  ---
(In reply to Marco Martin from comment #3)
> do you have an application that can reproduce the problem that doesn't
> require any particular hardware?

I have modified one of mine to behave like it used to when using the default
options, and also to not depend on any specific hardware:

https://github.com/andrebrait/nvidia-power-indicator-fake

If you change the icon option to 'color', however, it sets the full icon to the
icon file and it works ok.

It seems that it now appears, but no icon is displayed. I can't get the same
message as the user got, but I'm on Arch Linux, so many things have changed
between when this bug was reported and now. At the time, the user was running
KDE Neon.

Please let me know if I can be of any help.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 371576] AppIndicator GTK apps fail to find icons in custom GTK icon theme folder and crash

[Marco Martin]

https://bugs.kde.org/show_bug.cgi?id=371576

Marco Martin  changed:

   What|Removed |Added

 CC||notm...@gmail.com

--- Comment #3 from Marco Martin  ---
do you have an application that can reproduce the problem that doesn't require
any particular hardware?

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 371576] AppIndicator GTK apps fail to find icons in custom GTK icon theme folder and crash

[André Brait via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=371576

--- Comment #2 from André Brait  ---
(In reply to David Edmundson from comment #1)
> >- KDE 5.8 now demands custom icon folders have their names ended in "icons". 
> 
> It always had. 
> The path should match a valid icon directory as specified in 
> https://standards.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html
> 
> i.e yourpath/icons/hi-color/48x48/blah.png
> 
> you would have been getting this warning before, just maybe silently working.
> 
> 
> Though we shouldn't have changed behaviour in minor releases

Oh, my bad then. Yeah, it used to work ok, but I don't recall getting the
warning. It still works in other DE's, I think they don't check this stuff.
Enforcing correctness is ok.

The change was apparently somewhere between 5.6 and 5.8. Are these considered
to be minor releases?

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 371576] AppIndicator GTK apps fail to find icons in custom GTK icon theme folder and crash

[David Edmundson via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=371576

David Edmundson  changed:

   What|Removed |Added

 CC||k...@davidedmundson.co.uk

--- Comment #1 from David Edmundson  ---
>- KDE 5.8 now demands custom icon folders have their names ended in "icons". 

It always had. 
The path should match a valid icon directory as specified in 
https://standards.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html

i.e yourpath/icons/hi-color/48x48/blah.png

you would have been getting this warning before, just maybe silently working.


Though we shouldn't have changed behaviour in minor releases

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 371576] AppIndicator GTK apps fail to find icons in custom GTK icon theme folder and crash

[André Brait via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=371576

André Brait  changed:

   What|Removed |Added

 CC||andrebr...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.