[plasmashell] [Bug 382571] Icon pinned to task manager shows wide tooltip in just started plasma session

[Eike Hein]

https://bugs.kde.org/show_bug.cgi?id=382571

Eike Hein  changed:

   What|Removed |Added

  Latest Commit|https://commits.kde.org/pla |https://commits.kde.org/pla
   |sma-desktop/24803dc9dc4000e |sma-desktop/1e218b405bee4d7
   |06edb60a3a8afe5925f0d72d7   |5a5d26a4c28da2724d967953a

--- Comment #18 from Eike Hein  ---
Git commit 1e218b405bee4d75a5d26a4c28da2724d967953a by Eike Hein.
Committed on 22/06/2018 at 21:05.
Pushed by hein into branch 'Plasma/5.12'.

Fix tooltip woes

Summary:
Users have reported a number of bugs against TM tooltips, e.g. initially
coming up with crazy sizes, or showing window duplicates. This all comes
down to a race conditions causing stale data and ugly code that's using
visible props to swap between two alternate UI implementations instead
of doing clean conditional loading.

With this cleanup patch the problems should be gone, as well as various
ReferenceErrors spewed onto the tty.
Related: bug 385947, bug 389469, bug 388749

Reviewers: broulik, davidedmundson, romangg

Reviewed By: davidedmundson

Subscribers: rikmills, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D13602

M  +1-1applets/taskmanager/package/contents/ui/Task.qml
M  +33   -18   applets/taskmanager/package/contents/ui/ToolTipDelegate.qml
M  +1-1applets/taskmanager/package/contents/ui/ToolTipInstance.qml

https://commits.kde.org/plasma-desktop/1e218b405bee4d75a5d26a4c28da2724d967953a

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 382571] Icon pinned to task manager shows wide tooltip in just started plasma session

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=382571

--- Comment #17 from David Edmundson  ---
Git commit 1ab6ae9a8a36068294c487896dd512c693332b08 by David Edmundson.
Committed on 20/06/2018 at 07:16.
Pushed by davidedmundson into branch 'Plasma/5.12'.

Revert "Fix tooltip woes"

This reverts commit 24803dc9dc4000e06edb60a3a8afe5925f0d72d7.

Even though this commit is perfectly sensible it seems to introduce a
crash on startup for Qt 5.10.

Will revert for now, we can revisit later
Related: bug 385947, bug 389469, bug 388749

M  +1-1applets/taskmanager/package/contents/ui/Task.qml
M  +11   -27   applets/taskmanager/package/contents/ui/ToolTipDelegate.qml
M  +1-1applets/taskmanager/package/contents/ui/ToolTipInstance.qml

https://commits.kde.org/plasma-desktop/1ab6ae9a8a36068294c487896dd512c693332b08

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 382571] Icon pinned to task manager shows wide tooltip in just started plasma session

[Eike Hein]

https://bugs.kde.org/show_bug.cgi?id=382571

Eike Hein  changed:

   What|Removed |Added

  Latest Commit||https://commits.kde.org/pla
   ||sma-desktop/24803dc9dc4000e
   ||06edb60a3a8afe5925f0d72d7
 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED

--- Comment #16 from Eike Hein  ---
Git commit 24803dc9dc4000e06edb60a3a8afe5925f0d72d7 by Eike Hein.
Committed on 19/06/2018 at 11:22.
Pushed by hein into branch 'Plasma/5.12'.

Fix tooltip woes

Summary:
Users have reported a number of bugs against TM tooltips, e.g. initially
coming up with crazy sizes, or showing window duplicates. This all comes
down to a race conditions causing stale data and ugly code that's using
visible props to swap between two alternate UI implementations instead
of doing clean conditional loading.

With this cleanup patch the problems should be gone, as well as various
ReferenceErrors spewed onto the tty.
Related: bug 385947, bug 389469, bug 388749

Reviewers: broulik, davidedmundson, romangg

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D13602

M  +1-1applets/taskmanager/package/contents/ui/Task.qml
M  +27   -11   applets/taskmanager/package/contents/ui/ToolTipDelegate.qml
M  +1-1applets/taskmanager/package/contents/ui/ToolTipInstance.qml

https://commits.kde.org/plasma-desktop/24803dc9dc4000e06edb60a3a8afe5925f0d72d7

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 382571] Icon pinned to task manager shows wide tooltip in just started plasma session

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=382571

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 382571] Icon pinned to task manager shows wide tooltip in just started plasma session

[Eike Hein]

https://bugs.kde.org/show_bug.cgi?id=382571

Eike Hein  changed:

   What|Removed |Added

 Status|REOPENED|CONFIRMED

--- Comment #15 from Eike Hein  ---
That last bit of information was critical. I can reproduce now.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 382571] Icon pinned to task manager shows wide tooltip in just started plasma session

[Dr . Chapatin]

https://bugs.kde.org/show_bug.cgi?id=382571

Dr. Chapatin  changed:

   What|Removed |Added

Version|5.12.4  |5.13.0

--- Comment #14 from Dr. Chapatin  ---
Reproducible on Arch Linux ruuning plasma 5.13 when I have two or more icons
pinned to my plasma panel. Tooltip width increases according amount of pinned
icons.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 382571] Icon pinned to task manager shows wide tooltip in just started plasma session

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=382571

Nate Graham  changed:

   What|Removed |Added

 CC||petr.ne...@gmail.com

--- Comment #13 from Nate Graham  ---
*** Bug 393717 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 382571] Icon pinned to task manager shows wide tooltip in just started plasma session

[Dr . Chapatin]

https://bugs.kde.org/show_bug.cgi?id=382571

Dr. Chapatin  changed:

   What|Removed |Added

Summary|Icon pinned to task manager |Icon pinned to task manager
   |shows wide tooltip  |shows wide tooltip in just
   ||started plasma session
Version|5.10.4  |5.12.4

-- 
You are receiving this mail because:
You are watching all bug changes.