[plasmashell] [Bug 418318] The hover state should be clarifying, but not main
https://bugs.kde.org/show_bug.cgi?id=418318 Nate Graham changed: What|Removed |Added Latest Commit||https://commits.kde.org/pla ||sma-desktop/488c4b746d68e07 ||a44e538e8507229577a2c1bf8 Resolution|--- |FIXED Status|REPORTED|RESOLVED --- Comment #10 from Nate Graham --- Git commit 488c4b746d68e07a44e538e8507229577a2c1bf8 by Nate Graham, on behalf of Eugene Popov. Committed on 27/03/2020 at 04:10. Pushed by ngraham into branch 'master'. [applets/taskmanager] Make the hover state clarifying, but not main Summary: I'm trying to make a custom appearance of the Task Manager by creating a new theme, but I ran into some issue. I expected that there are three main states (minimized, normal and active) and one clarifying state (hover). But I was surprised to find that there are four main states (minimized, normal, active and hover), and the hover state is also main, but not clarifying. I believe that the hover state should be clarifying for the main states, i.e. there must be three main states (minimized, normal and active) and three additional (minimzed-hover, normal-hover, active-hover). See https://phabricator.kde.org/P555 Reviewers: davidedmundson, #vdg Reviewed By: davidedmundson Subscribers: broulik, ngraham, epopov, plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D28306 M +2-10 applets/taskmanager/package/contents/ui/Task.qml M +13 -0applets/taskmanager/package/contents/ui/code/tools.js https://commits.kde.org/plasma-desktop/488c4b746d68e07a44e538e8507229577a2c1bf8 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 418318] The hover state should be clarifying, but not main
https://bugs.kde.org/show_bug.cgi?id=418318 Nate Graham changed: What|Removed |Added Version Fixed In||5.19.0 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 418318] The hover state should be clarifying, but not main
https://bugs.kde.org/show_bug.cgi?id=418318 --- Comment #9 from popov895 --- https://phabricator.kde.org/D28306 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 418318] The hover state should be clarifying, but not main
https://bugs.kde.org/show_bug.cgi?id=418318 --- Comment #8 from popov895 --- Found the reason for this behavior and filled a bug 419236 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 418318] The hover state should be clarifying, but not main
https://bugs.kde.org/show_bug.cgi?id=418318 --- Comment #7 from popov895 --- I have strange behaviour of the task manager after some manipulations with the /usr/share/plasma/plasmoids/org.kde.plasma.taskmanager/contents/ui/Task.qml. Before that, I tested the patch from Comment 2 on a virtual machine and everything worked fine. But now I have started testing it on a real machine, and after applying this patch and rebooting, I noticed that the task manager stopped displaying the minimized state. Then I restored the original file and rebooted, but the task manager still didn't display the minimized state. Having decided that the problem is with the QML cache, I cleared the ~/.cache folder and rebooted, but this also didn't solve my problem. So, the task manager still doesn't display minimized state. Any ideas? -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 418318] The hover state should be clarifying, but not main
https://bugs.kde.org/show_bug.cgi?id=418318 --- Comment #6 from Nate Graham --- Yes, feel free to take that code and submit it on https://phabricator.kde.org/differential/diff/create/, with any modifications you find necessary. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 418318] The hover state should be clarifying, but not main
https://bugs.kde.org/show_bug.cgi?id=418318 popov895 changed: What|Removed |Added Status|NEEDSINFO |REPORTED Resolution|WAITINGFORINFO |--- --- Comment #5 from popov895 --- What do you mean by saying "do something useful with the patch"? Do I need to submit the patch myself? -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 418318] The hover state should be clarifying, but not main
https://bugs.kde.org/show_bug.cgi?id=418318 --- Comment #4 from Bug Janitor Service --- Dear Bug Submitter, This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information as soon as possible and set the bug status as REPORTED. Due to regular bug tracker maintenance, if the bug is still in NEEDSINFO status with no change in 30 days the bug will be closed as RESOLVED > WORKSFORME due to lack of needed information. For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging If you have already provided the requested information, please mark the bug as REPORTED so that the KDE team knows that the bug is ready to be confirmed. Thank you for helping us make KDE software even better for everyone! -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 418318] The hover state should be clarifying, but not main
https://bugs.kde.org/show_bug.cgi?id=418318 --- Comment #3 from popov895 --- Yes, it's a pretty good solution. I tested it and it allows me to solve the specified problem, and also it doesn't break the current themes (at least breeze theme works fine). But I'd prefer to use SVG suffix instead of prefix: [west-normal-hover, normal-hover, west-hover, hover, west-normal, normal] -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 418318] The hover state should be clarifying, but not main
https://bugs.kde.org/show_bug.cgi?id=418318 David Edmundson changed: What|Removed |Added Resolution|--- |WAITINGFORINFO Status|REPORTED|NEEDSINFO --- Comment #2 from David Edmundson --- Something like https://phabricator.kde.org/P555 ^ as I had the code open to reply. Realistically I don't care for 3rd party themes, so if you want this change you have to reply to the above ordering, and then do something useful with the patch. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 418318] The hover state should be clarifying, but not main
https://bugs.kde.org/show_bug.cgi?id=418318 David Edmundson changed: What|Removed |Added Priority|NOR |LO Component|Theme - Breeze |Task Manager CC||k...@davidedmundson.co.uk Assignee|visual-des...@kde.org |h...@kde.org --- Comment #1 from David Edmundson --- Moving back as it requires no changes in Breeze, only task manager. I don't disagree with your original premise. Yes it should be a flag. It gets quite convoluted as it would be a theme break - and hover itself is already optional. I believe it means we would have to set the SVG prefix to be (in order): [west-hover-normal, hover-normal, west-hover, hover, west-normal, normal] is that correct? -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 418318] The hover state should be clarifying, but not main
https://bugs.kde.org/show_bug.cgi?id=418318 Nate Graham changed: What|Removed |Added CC||n...@kde.org Component|Task Manager|Theme - Breeze Assignee|h...@kde.org|visual-des...@kde.org -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 418318] The hover state should be clarifying, but not main
https://bugs.kde.org/show_bug.cgi?id=418318 popov895 changed: What|Removed |Added CC||popov...@ukr.net -- You are receiving this mail because: You are watching all bug changes.
